Received-SPF: pass (google.com: domain of linux-kernel+bounces-193203-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f0881f3b-036b-462a-9e0c-42ca81807b86@quicinc.com>
Date: Tue, 28 May 2024 15:50:25 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/4] soc: qcom: smem: Add
 qcom_smem_bust_hwspin_lock_by_host()
To: Bjorn Andersson <andersson@kernel.org>
CC: Baolin Wang <baolin.wang@linux.alibaba.com>,
        Peter Zijlstra
	<peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Will Deacon
	<will@kernel.org>, Waiman Long <longman@redhat.com>,
        Boqun Feng
	<boqun.feng@gmail.com>, Jonathan Corbet <corbet@lwn.net>,
        Mathieu Poirier
	<mathieu.poirier@linaro.org>,
        Rob Herring <robh@kernel.org>,
        Krzysztof
 Kozlowski <krzk+dt@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <20240524-hwspinlock-bust-v2-0-fb88fd17ca0b@quicinc.com>
 <20240524-hwspinlock-bust-v2-3-fb88fd17ca0b@quicinc.com>
 <nwoeg22jg5yd4amgqqegplygy6aickehvfc6eanmody74h6nss@cmixbwx6vpx4>
Content-Language: en-US
From: Chris Lew <quic_clew@quicinc.com>
In-Reply-To: <nwoeg22jg5yd4amgqqegplygy6aickehvfc6eanmody74h6nss@cmixbwx6vpx4>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 5/28/2024 2:55 PM, Bjorn Andersson wrote:
> On Fri, May 24, 2024 at 06:26:42PM GMT, Chris Lew wrote:
>> Add qcom_smem_bust_hwspin_lock_by_host to enable remoteproc to bust the
>> hwspin_lock owned by smem. In the event the remoteproc crashes
>> unexpectedly, the remoteproc driver can invoke this API to try and bust
>> the hwspin_lock and release the lock if still held by the remoteproc
>> device.
>>
>> Signed-off-by: Chris Lew <quic_clew@quicinc.com>
>> ---
>>   drivers/soc/qcom/smem.c       | 28 ++++++++++++++++++++++++++++
>>   include/linux/soc/qcom/smem.h |  2 ++
>>   2 files changed, 30 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
>> index 7191fa0c087f..683599990387 100644
>> --- a/drivers/soc/qcom/smem.c
>> +++ b/drivers/soc/qcom/smem.c
..
>> + *
>> + * Context: Process context.
>> + *
>> + * Returns: 0 on success, otherwise negative errno.
>> + */
>> +int qcom_smem_bust_hwspin_lock_by_host(unsigned host)
>> +{
>> +	if (!__smem)
>> +		return -EPROBE_DEFER;
> 
> This would be called at a time where -EPROBE_DEFER isn't appropriate,
> the client should invoke qcom_smem_is_available() at probe time to guard
> against this.
> 

Should we keep the null pointer check to prevent null pointer 
dereference and return 0? Or would it be better to allow the null 
pointer deference to go through so we can catch misuse of the API and 
ask clients to use qcom_smem_is_available()?