Received-SPF: pass (google.com: domain of linux-kernel+bounces-193323-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a1ceff08-164f-d0b4-36b6-41a7798b82be@redhat.com>
Date: Tue, 28 May 2024 22:00:21 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] dm vdo indexer: Use swap() instead of open coding it
Content-Language: en-US
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
 Abaci Robot <abaci@linux.alibaba.com>, Mike Snitzer <snitzer@kernel.org>
References: <20240524074109.13433-1-jiapeng.chong@linux.alibaba.com>
From: Matthew Sakai <msakai@redhat.com>
In-Reply-To: <20240524074109.13433-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/24/24 03:41, Jiapeng Chong wrote:
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
> 
> ./drivers/md/dm-vdo/indexer/index.c:207:43-44: WARNING opportunity for swap().
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9173
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Matthew Sakai <msakai@redhat.com>

Mike, can you make sure this gets applied with the rest of the pending 
dm patches?

> ---
>   drivers/md/dm-vdo/indexer/index.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/md/dm-vdo/indexer/index.c b/drivers/md/dm-vdo/indexer/index.c
> index 1ba767144426..df4934846244 100644
> --- a/drivers/md/dm-vdo/indexer/index.c
> +++ b/drivers/md/dm-vdo/indexer/index.c
> @@ -197,15 +197,12 @@ static int finish_previous_chapter(struct uds_index *index, u64 current_chapter_
>   static int swap_open_chapter(struct index_zone *zone)
>   {
>   	int result;
> -	struct open_chapter_zone *temporary_chapter;
>   
>   	result = finish_previous_chapter(zone->index, zone->newest_virtual_chapter);
>   	if (result != UDS_SUCCESS)
>   		return result;
>   
> -	temporary_chapter = zone->open_chapter;
> -	zone->open_chapter = zone->writing_chapter;
> -	zone->writing_chapter = temporary_chapter;
> +	swap(zone->open_chapter, zone->writing_chapter);
>   	return UDS_SUCCESS;
>   }
>