Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp358885lqb; Tue, 28 May 2024 19:07:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU3gsAhW5zxBsr+jcdsS+NDRqrCSWAA+WW31CML92pO204ek3745aesWHYK1gI2wcu9+nLLRVXkCyExz9igs0BKUuik1sMV6NQKqwKNfg== X-Google-Smtp-Source: AGHT+IFrjsGN6qrwjL4xCefJ1dgynLxD1Lp0AR8WCIo0LcJYIHj8pXDoNPbv76dOl2qbZLY7EKp1 X-Received: by 2002:a17:902:ce09:b0:1f4:a392:ac5b with SMTP id d9443c01a7336-1f4a392ad48mr78684165ad.57.1716948426895; Tue, 28 May 2024 19:07:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716948426; cv=pass; d=google.com; s=arc-20160816; b=XZM0VLp7CEaFdjmnlOg4Z61qA++rS0kUuT2o8oMv3JSCzURv+zBTwxBxRg+m8r4nRb yy1Ut4z+ZQyRgcgi7rgxAaI8MLw5tQz5KOk2PfNxN039N2Zl9/ESMCajh+mv3Vx4vLTL zmGG32Fi5Q3ofBjJjkobRoNATCexaMqQ9Qr11hD4z6NKmoRkJjQK9eVaDi8xClaNeu89 VK/1vjj1XlqwZtMzuKZj4rZU72avhJxrgw7bAiFaPWX1wki/BNdoL3rohD/fSazVAND/ P9mxR8w1E9uzWCBW269alRkvGGcqxYfhKKWh/7k98yG2Ww+2A1YI9Cum6Ex7i1+icLfG K8qw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Vggj3AVAWlaXghWgYdJLYUGVcRLfqGcr4AtcLurDv2c=; fh=mI3aDlESfS5PdJdJlVt1IXhf/1nAwBA1kF638d/uzCY=; b=tIeezERshHf8RcTlvt7k8yGwSw+bttE1saoNewM/89iAkA1BII1AhGez5PsXzKuSM7 o1XI0LaOJ2AYri6i/E1zysEII5Wjvq3LBvUgsIDJ71wRVgWINnARCsObjaiL6p/ZpkVy igzWxdJkP2eRfbvkMBCH+i/Gsn1NTw3BwFshE/noGwLQ+4q3DdDSsiHThehBAdteJbw2 VxNVdJtrMQC0bIVZxFHxZoq6SzHeGB9KvkIVYg8jueHpNAzvjQp5SmZSX5q3HxeDg1s1 u1fsLWR9moNnlfXVLqb3ye/eaE4pymTYuRcWlFCn2PmAiJEFptkbed7yf/H1rGuBv90E 6Qvg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="LevB1H/D"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-193336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-193336-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c785d18si90271765ad.3.2024.05.28.19.07.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 19:07:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-193336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="LevB1H/D"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-193336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-193336-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 55AC128B2EE for ; Wed, 29 May 2024 02:05:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DBFE71649DF; Wed, 29 May 2024 02:02:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LevB1H/D" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0323D161935; Wed, 29 May 2024 02:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716948147; cv=none; b=kfzr940Z+SplqmvoDq5/EbCfOqTRemxrfF5JkGA1jmExBOrxCmVptseOk2MYngnJUtE3nfs5vzFIjAmnp4FPFlCdKPTGL/9+EU1mFqZu+e90X9fymmRk0njbhFHR2IapLK/36t82rZgqHRj7+xDQ1zVKlk2GQAgLog5CqKojZlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716948147; c=relaxed/simple; bh=XU5WPu1gwPIwO83oy0ulPSZYeOGgR4c91Iore08em+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sFcs0kE8aNSX/EdVKf61WOBF5PGi6TQBo3XhRpeo1utiMQ2DQ+8e8QNcv8/wfMD+yx/ixdClq/43AIX64wlg+zRaMZT+akmbZz4Z0C7RKusMxhSgHA2+OWZFC9KPTpv4LbC6mQlD8j6zIIZ8yf4z6fBRWa/wMU41PZq/Hy46+UM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LevB1H/D; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B652C4AF0C; Wed, 29 May 2024 02:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716948146; bh=XU5WPu1gwPIwO83oy0ulPSZYeOGgR4c91Iore08em+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LevB1H/DY2oRekSbRe0chbmFa1wqcS9dJT8sZekQfc3X4fg38oUtDid4cdomktYj9 OH4l+eXdkD6t6zY2ExYtc4w3pm/eezXwEcTevtccpNDInvGvu5GDjZKcKLh1CPXRrz GaqPjFNQ3drDcTNaQfKzArk5XtQvGXHv6f5pGOYxFlBkAUXvcyr7pG5dXOpHg9Otwn /oFmloJ5QrQiKkBit67zDJVLf7kVa0yJ+qgraJQ15YfuYuSggeFg65wsb/LET+aYTj NLXyVN1Imv4VQraKJDB8rq18ugo2Ap16MM7efwcTAlPgImKuSmfMybFQRzhYhqOO0H Pa9k/2rwYLPmg== From: Bjorn Andersson To: mturquette@baylibre.com, sboyd@kernel.org, bhupesh.sharma@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Md Sadre Alam Cc: quic_srichara@quicinc.com, quic_varada@quicinc.com, stable@vger.kernel.org Subject: Re: [PATCH v3] clk: qcom: gcc-ipq9574: Add BRANCH_HALT_VOTED flag Date: Tue, 28 May 2024 21:02:00 -0500 Message-ID: <171694812082.574781.5852055342473098003.b4-ty@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240509105405.1262369-1-quic_mdalam@quicinc.com> References: <20240509105405.1262369-1-quic_mdalam@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 09 May 2024 16:24:05 +0530, Md Sadre Alam wrote: > The crypto_ahb and crypto_axi clks are hardware voteable. > This means that the halt bit isn't reliable because some > other voter in the system, e.g. TrustZone, could be keeping > the clk enabled when the kernel turns it off from clk_disable(). > Make these clks use voting mode by changing the halt check to > BRANCH_HALT_VOTED and toggle the voting bit in the voting register > instead of directly controlling the branch by writing to the branch > register. This fixes stuck clk warnings seen on ipq9574 and saves > power by actually turning the clk off. > > [...] Applied, thanks! [1/1] clk: qcom: gcc-ipq9574: Add BRANCH_HALT_VOTED flag commit: 72ceafb587a56e26c905472418c7dc2033c294d3 Best regards, -- Bjorn Andersson