Received-SPF: pass (google.com: domain of linux-kernel+bounces-193344-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 28 May 2024 19:09:34 -0700
From: Bjorn Andersson <andersson@kernel.org>
To: Chris Lew <quic_clew@quicinc.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>, 
	Waiman Long <longman@redhat.com>, Boqun Feng <boqun.feng@gmail.com>, 
	Jonathan Corbet <corbet@lwn.net>, Mathieu Poirier <mathieu.poirier@linaro.org>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, 
	Konrad Dybcio <konrad.dybcio@linaro.org>, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, 
	Richard Maina <quic_rmaina@quicinc.com>
Subject: Re: [PATCH v2 2/4] hwspinlock: qcom: implement bust operation
Message-ID: <upfsdgmg3vvx6ebehlem2u6rm6y3jxwlgvdbagtntstqsdvusp@gogo2jidnop5>
References: <20240524-hwspinlock-bust-v2-0-fb88fd17ca0b@quicinc.com>
 <20240524-hwspinlock-bust-v2-2-fb88fd17ca0b@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240524-hwspinlock-bust-v2-2-fb88fd17ca0b@quicinc.com>

On Fri, May 24, 2024 at 06:26:41PM -0700, Chris Lew wrote:
> From: Richard Maina <quic_rmaina@quicinc.com>
> 
> Implement a new operation qcom_hwspinlock_bust() which can be invoked
> to bust any locks that are in use when a remoteproc is stopped or
> crashed.
> 
> Signed-off-by: Richard Maina <quic_rmaina@quicinc.com>
> Signed-off-by: Chris Lew <quic_clew@quicinc.com>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
>  drivers/hwspinlock/qcom_hwspinlock.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c
> index 814dfe8697bf..0390979fd765 100644
> --- a/drivers/hwspinlock/qcom_hwspinlock.c
> +++ b/drivers/hwspinlock/qcom_hwspinlock.c
> @@ -64,9 +64,34 @@ static void qcom_hwspinlock_unlock(struct hwspinlock *lock)
>  		pr_err("%s: failed to unlock spinlock\n", __func__);
>  }
>  
> +static int qcom_hwspinlock_bust(struct hwspinlock *lock, unsigned int id)
> +{
> +	struct regmap_field *field = lock->priv;
> +	u32 owner;
> +	int ret;
> +
> +	ret = regmap_field_read(field, &owner);
> +	if (ret) {
> +		dev_err(lock->bank->dev, "unable to query spinlock owner\n");
> +		return ret;
> +	}
> +
> +	if (owner != id)
> +		return 0;
> +
> +	ret = regmap_field_write(field, 0);
> +	if (ret) {
> +		dev_err(lock->bank->dev, "failed to bust spinlock\n");
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +
>  static const struct hwspinlock_ops qcom_hwspinlock_ops = {
>  	.trylock	= qcom_hwspinlock_trylock,
>  	.unlock		= qcom_hwspinlock_unlock,
> +	.bust		= qcom_hwspinlock_bust,
>  };
>  
>  static const struct regmap_config sfpb_mutex_config = {
> 
> -- 
> 2.25.1
>