Received-SPF: pass (google.com: domain of linux-kernel+bounces-193356-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Huang, Ying" <ying.huang@intel.com>
To: Byungchul Park <byungchul@sk.com>
Cc: Dave Hansen <dave.hansen@intel.com>,  <linux-kernel@vger.kernel.org>,
  <linux-mm@kvack.org>,  <kernel_team@skhynix.com>,
  <akpm@linux-foundation.org>,  <vernhao@tencent.com>,
  <mgorman@techsingularity.net>,  <hughd@google.com>,
  <willy@infradead.org>,  <david@redhat.com>,  <peterz@infradead.org>,
  <luto@kernel.org>,  <tglx@linutronix.de>,  <mingo@redhat.com>,
  <bp@alien8.de>,  <dave.hansen@linux.intel.com>,  <rjgolo@gmail.com>
Subject: Re: [PATCH v10 00/12] LUF(Lazy Unmap Flush) reducing tlb numbers
 over 90%
In-Reply-To: <20240527225843.GA50818@system.software.com> (Byungchul Park's
	message of "Tue, 28 May 2024 07:58:43 +0900")
References: <20240510065206.76078-1-byungchul@sk.com>
	<982317c0-7faa-45f0-82a1-29978c3c9f4d@intel.com>
	<20240527015732.GA61604@system.software.com>
	<a28df276-069c-4d4d-abaf-efc24983211e@intel.com>
	<20240527225843.GA50818@system.software.com>
Date: Wed, 29 May 2024 10:16:26 +0800
Message-ID: <87le3t5pmt.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii

Byungchul Park <byungchul@sk.com> writes:

> On Sun, May 26, 2024 at 07:43:10PM -0700, Dave Hansen wrote:
>> It has absolutely not been tested nor reviewed enough.  <fud>I hope the
>
> It has been tested enough on my side, and it should be reviewed enough
> for sure.

I believe that you have tested and reviewed the patchset by yourself.
But there are some other cases that you haven't thought about enough
before, as Dave pointed out.

So, I suggest you to try to find out more possible weakness of your
patchset.  Begin with what Dave and David pointed out.

> I will respin after rebasing the current mm-unstble and
> working on vfs shortly.
>
> 	Byungchul
>
>> performance gains stick around once more of the bugs are gone.</fud>

--
Best Regards,
Huang, Ying