Received-SPF: pass (google.com: domain of linux-kernel+bounces-193126-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: i5ec1447f:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-491-g033e30d24-fm-20240520.001-g033e30d2
Precedence: bulk
MIME-Version: 1.0
Message-Id: <a476aebc-fb31-4236-81cf-70a9e1e564a3@app.fastmail.com>
In-Reply-To: <4660daf1-f42f-9b65-eaf5-30daf2931058@linux.intel.com>
References: <20240528013626.14066-1-luke@ljones.dev>
 <20240528013626.14066-8-luke@ljones.dev>
 <4660daf1-f42f-9b65-eaf5-30daf2931058@linux.intel.com>
Date: Wed, 29 May 2024 09:37:32 +1200
From: "Luke Jones" <luke@ljones.dev>
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 "Hans de Goede" <hdegoede@redhat.com>
Cc: corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/9] platform/x86: asus-wmi: add enable/disable CPU cores
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable


On Tue, 28 May 2024, at 9:27 PM, Ilpo J=C3=A4rvinen wrote:
> Hi,
>=20
> Hans, please check my question below.
>=20
> On Tue, 28 May 2024, Luke D. Jones wrote:
>=20
> > Exposes the WMI functions for enable/disable of performance and
> > efficiency cores on some laptop models (largely Intel only).
> >=20
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > ---
>=20
> > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Doc=
umentation/ABI/testing/sysfs-platform-asus-wmi
> > index 3b4eeea75b7b..ac881e72e374 100644
> > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > @@ -226,3 +226,22 @@ Description:
> >  Set panel to UHD or FHD mode
> >  * 0 - UHD,
> >  * 1 - FHD
> > +
> > +What: /sys/devices/platform/<platform>/cores_enabled
> > +Date: Jun 2024
> > +KernelVersion: 6.11
> > +Contact: "Luke Jones" <luke@ljones.dev>
> > +Description:
> > + Enable/disable efficiency and performance cores. The format is
> > + 0x[E][P] where [E] is the efficiency core count, and [P] is
> > + the perfromance core count. If the core count is a single digit
>=20
> performance
>=20
> > + it is preceded by a 0 such as 0x0406; E=3D4, P=3D6, 0x1006; E=3D10=
, P=3D6
> > +
> > +What: /sys/devices/platform/<platform>/cores_max
> > +Date: Jun 2024
> > +KernelVersion: 6.11
> > +Contact: "Luke Jones" <luke@ljones.dev>
> > +Description:
> > + Show the maximum performance and efficiency core countin format
> > + 0x[E][P] where [E] is the efficiency core count, and [P] is
> > + the perfromance core count.
>=20
> performance
>=20
> > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/=
asus-wmi.c
> > index 4b045f1828f1..f62a36dfcd4b 100644
> > --- a/drivers/platform/x86/asus-wmi.c
> > +++ b/drivers/platform/x86/asus-wmi.c
> > @@ -815,6 +815,46 @@ static ssize_t panel_fhd_store(struct device *d=
ev,
> >  WMI_SIMPLE_SHOW(panel_fhd, "%d\n", ASUS_WMI_DEVID_PANEL_FHD);
> >  static DEVICE_ATTR_RW(panel_fhd);
> > =20
> > +/* Efficiency and Performance core control ************************=
**********/
> > +static ssize_t cores_enabled_store(struct device *dev,
> > +     struct device_attribute *attr,
> > +     const char *buf, size_t count)
> > +{
> > + struct asus_wmi *asus =3D dev_get_drvdata(dev);
> > + int result, err;
> > + u32 cores, max;
> > +
> > + result =3D kstrtou32(buf, 16, &cores);
> > + if (result)
> > + return result;
> > +
> > + err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_CORES_MAX, &max=
);
> > + if (err < 0)
> > + return err;
> > +
> > + if (cores > max) {
>=20
> This only checks one part of it and the P part can contain whatever=20
> garbage as long as E is small enough?
>=20
> But I'm not sure if it's good idea to have these two changed through t=
he=20
> same sysfs file, I'm leaning more on that it would be better to split =
the=20
> interface for P and E.
>=20
> Hans, what you think about this?

I'm inclined to agree. It's no issue to change it.

Ack all reviews. I'll work through them over the week but with a lower p=
riority while I await both yours and Hans response in other replies with=
 Mario regarding the firmware_attributes change/use.

>=20
> > + pr_warn("Core count 0x%x exceeds max: 0x%x\n", cores, max);
> > + return -EIO;
> > + }
> > +
> > + err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_CORES_SET, cores, &re=
sult);
> > + if (err) {
> > + pr_warn("Failed to set cores_enabled: %d\n", err);
> > + return err;
> > + }
> > +
> > + pr_info("Enabled core count changed, reboot required\n");
> > + sysfs_notify(&asus->platform_device->dev.kobj, NULL, "cores_enable=
d");
> > +
> > + return count;
> > +}
>=20
> > @@ -4131,6 +4173,9 @@ static umode_t asus_sysfs_is_visible(struct ko=
bject *kobj,
> >  devid =3D ASUS_WMI_DEVID_PANEL_OD;
> >  else if (attr =3D=3D &dev_attr_panel_fhd.attr)
> >  devid =3D ASUS_WMI_DEVID_PANEL_FHD;
> > + else if (attr =3D=3D &dev_attr_cores_enabled.attr
> > + || attr =3D=3D &dev_attr_cores_max.attr)
>=20
> Wrong alignment.
>=20
> --=20
> i.
>=20
>=20