Received-SPF: pass (google.com: domain of linux-kernel+bounces-193404-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 29 May 2024 08:56:53 +0530
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: <admiyo@os.amperecomputing.com>
CC: Sudeep Holla <sudeep.holla@arm.com>,
        Jassi Brar
	<jassisinghbrar@gmail.com>,
        Robert Moore <robert.moore@intel.com>,
        "Rafael J.
 Wysocki" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] mctp pcc: Check before sending MCTP PCC response
 ACK
Message-ID: <20240529032653.GB2452291@maili.marvell.com>
References: <20240513173546.679061-1-admiyo@os.amperecomputing.com>
 <20240528191823.17775-1-admiyo@os.amperecomputing.com>
 <20240528191823.17775-2-admiyo@os.amperecomputing.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240528191823.17775-2-admiyo@os.amperecomputing.com>

On 2024-05-29 at 00:48:21, admiyo@os.amperecomputing.com (admiyo@os.amperecomputing.com) wrote:
> From: Adam Young <admiyo@amperecomputing.com>
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index 94885e411085..774727b89693 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -280,6 +280,7 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
>  {
>  	struct pcc_chan_info *pchan;
>  	struct mbox_chan *chan = p;
> +	struct pcc_mbox_chan *pmchan;
Reverse xmas tree.

>  	u64 val;
>  	int ret;
>
>