Received-SPF: pass (google.com: domain of linux-kernel+bounces-193473-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6c907190-f084-a6b9-ea43-9a6d3dacda05@amd.com>
Date: Wed, 29 May 2024 11:09:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: =?UTF-8?Q?Re=3a_=5bPATCH=5d_sched=3a_core=3a_Remove_unnecessary_?=
 =?UTF-8?B?4oCYTlVMTOKAmSB2YWx1ZXMgZnJvbSBwZW5kaW5n?=
Content-Language: en-US
To: kunyu <kunyu@nfschina.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, juri.lelli@redhat.com,
 peterz@infradead.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
 rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
 bristot@redhat.com, vschneid@redhat.com
References: <20240528064532.42532-1-kunyu@nfschina.com>
From: K Prateek Nayak <kprateek.nayak@amd.com>
In-Reply-To: <20240528064532.42532-1-kunyu@nfschina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cUowTXhFVW1qK3IyUWhzMHV4SFNyRHV3clIzdHNRUE1HZ0lsMjBDN3I4Z3Qx?=
 =?utf-8?B?THFPT0FEVW1BT3ROWmhRVlNQLyt0OXZQeW9yakFQNnJnV0UrNTN1WkhFdHEr?=
 =?utf-8?B?dXJJWEsycVdJRkdRMUZLb2E0UEs4RFVKN1pTQlc5N0lNYU1qRlRHNFp3T0tT?=
 =?utf-8?B?M1M0OForWG03ZFF6cURyakdkeURRWHJKb2VubGY1K1AwSitIcVA3RUZuZDl5?=
 =?utf-8?B?akMzSC9BYmJvUEpZNW84L2Zja1N0eU5ISlVnYUErckVuZUlOMWRKSi9NdjY4?=
 =?utf-8?B?cisrdzVlSW0rMTZCL1ovejh6K1Yza1BWNTJJR2NjeHArWFlLejR3dzMvWlpM?=
 =?utf-8?B?YStPZTMrZ3VmYysvN3hKWVZpK0FnZlZtRzlRZzdkekF6YU9Ld3FXTWVkbnZ5?=
 =?utf-8?B?T3doS2tUdE1PbktUOWhRYThoeGsrc0p5UXl0NUVtYitCY3A0WTRDM1lDQ2ox?=
 =?utf-8?B?WGhOUzNKM3UxdlFaNDBRS2VyUkFib3NHZ3hwS3A0TUdWL2FXVHAxRVF5d2p0?=
 =?utf-8?B?TzhmWlhpNkx6cWZhWU1PK000YjNxWUg2Y2kwV25iMzI2NDBiY3VTRzE5RVpD?=
 =?utf-8?B?WktvRE1iRTRrcytud3lvUVoySnorQVJvUVltNGZuS21pL1FCTmR6Zm9HSHNo?=
 =?utf-8?B?YkNMTTNtYWNldGVNTDhiY2s5TjJuQ2tJOXRNTkQ4VGJMUEZuVmxpUjFkZUhL?=
 =?utf-8?B?TzdwZnV1V3BwUm9VYWV6R29IZXVRYnVUOUh4U2w4OVFheTY1UXVhUXNhMW8z?=
 =?utf-8?B?ZndONDdtSENONlRic1RCb2dwcDFVeVlrc3c4Ny9ZRmVzUWxIeW1kVG9vOWhn?=
 =?utf-8?B?RnVBTkFIU2l6a2ZwbSs0emJJb2cxam1NY1pKWmJQM1loQndwSXBlYnN6YVh2?=
 =?utf-8?B?N091bEZ1Y3o3OFdZSHJEdG1KR1p4OEp2aHo4Y1ZQbytGRG5FUXJ4YTNoVnVY?=
 =?utf-8?B?bmhYRjYwUFVTRXlZbExzcnA4MC9panhYWmVHaGlYY3o4UHZkaHV0MzJQVyt1?=
 =?utf-8?B?Rkw4ZFRLaWRadVljSkFuNWhiNVlmclBkVkZNb3ZHVmk3OTM3MTZOWkg2MklQ?=
 =?utf-8?B?MnRER09jSW1pNm5JMlk5aFd1Y0hqUWx3cEQ3S0l3dUIzS25TSTNPT3JFSTFm?=
 =?utf-8?B?d2E0UjFJWjQvUmMxb21BMzdzaDZkeXREL012czNTR3RhR3hyQSs3Q3ppekl1?=
 =?utf-8?B?clRyMjdQVi8yY1M0ZjNNeTlaTWV5ZG9taW92c2NHVWEvWWxGdGJkaFNlQkRz?=
 =?utf-8?B?bmtncGU4UXdBMVlWcCsyS1VDSWRJcjFYeE5uUWk0T1NVK1g4MWcvODJ6YlRR?=
 =?utf-8?B?ZUJ0SlZRL05DVXFmZFFVQ0tCZ1JHYWFBTWx3QjZkQkljOEJOelVPaWlSVFVm?=
 =?utf-8?B?SXdyT0tUZHN3aTNacFl2Q204NCtEUkVNemtxdGVSY3hhNDN0QjFPMFFOMGU3?=
 =?utf-8?B?QjFhWmU1dWlsRDdRM2llRFJqZWNXWXd4VlZiM3NsOGd4bnl0M1B2VElyZjdF?=
 =?utf-8?B?RFNjcHQ3dFM1VVRqdHJZMzRzUUZDcmZhQWs5T1RseXAwQTd5VWpISmh4U2JB?=
 =?utf-8?B?dkROYUJaeHJuVFhsQmN0ZlRWbXIvemtZL2RpSXVsQkFKSUl6RVJqdFREaVR3?=
 =?utf-8?B?dFBPWVU3YTBicTEwYUpsSjVGajlaeXB4ZlFnYi9jOURXckJTdEtSbmh2Y1FD?=
 =?utf-8?B?aWJHQWQ0YjBCTGsrZ2lOUWdYR2djRERyM0wxVGNabW5XeklieDFDdCtKOGtU?=
 =?utf-8?B?VU5xUnJ0R2x2eEVLVVBMS1l0UGcybFBEd0tyZkhWR200MzVoQmt4SU4yc1RM?=
 =?utf-8?B?MjJsaXJ2bHRPVk41eGI0eFFGTW9qNlFjeWhld0hlVXJaU2NyL2U5bHhJZUR5?=
 =?utf-8?B?WUo2b0g0TnA4blRqbkhsZ0Y2cG13bmtZcFhCbmZHMk5xSmtHMkdTSTJvVlYw?=
 =?utf-8?B?UVVIR0MwZ3YxMDdnTVpaY3dGdU8rYm5aWTZFcXFUY05HdWtkRU9aR1VTWmxP?=
 =?utf-8?B?aENSbnd5b3RRS3JNNHNGc3VGcUUzTWo3TlhGL2hHWVdjRkhjSzlQZ3JvQ2FD?=
 =?utf-8?B?SFdyRzVoNllJWkE3Y3kyQnZhSEtsaU1kUVlsU3dORTVxcUkwejY2dklGRy9V?=
 =?utf-8?Q?UFucn9jfbHuyrs9jqxcbocT3Z?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19e8129c-f1e4-41f4-17bb-08dc7fa1bc29
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2379.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 05:39:40.7696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lBRyJPqlt8D7pr24S4DI7OqcL3Nc1s7nDrGfLEQPtXYg84ByqLcz1p/Bv+SsY+r0enyCoJ6w8eBrabITUszf9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6193

Hello Kunyu,

On 5/28/2024 12:15 PM, kunyu wrote:
> pending is assigned first, so it does not need to initialize the
> assignment.
> 
> Signed-off-by: kunyu <kunyu@nfschina.com>
> ---
>  kernel/sched/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index bcf2c4cc0522..e32fea8f5830 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2969,7 +2969,7 @@ static int affine_move_task(struct rq *rq, struct task_struct *p, struct rq_flag
>  	__releases(rq->lock)
>  	__releases(p->pi_lock)
>  {
> -	struct set_affinity_pending my_pending = { }, *pending = NULL;
> +	struct set_affinity_pending my_pending = { }, *pending;

Can "pending" here be initialized to "p->migration_pending" and later
be changed to the updated value of "p->migration_pending" for the
SCA_MIGRATE_ENABLE case?

	if (!(flags & SCA_MIGRATE_ENABLE)) {
		/* serialized by p->pi_lock */
		if (!p->migration_pending) {
			...

			/* Update pending to new value of p->migration_pending */
			pending = p->migration_pending = &my_pending;
		} else {
			...
		}
	}
--

Rest of the initial assignments to "pending" can be dropped then.
Thoughts?

>  	bool stop_pending, complete = false;
>  
>  	/* Can the task run on the task's current CPU? If so, we're done */

--
Thanks and Regards,
Prateek