Received-SPF: pass (google.com: domain of linux-kernel+bounces-193503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a0969967-c3ed-41ad-b7bb-805227281bbd@huawei.com>
Date: Wed, 29 May 2024 14:20:45 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] sched/fair: set burst to zero when set max to cpu.max
To: Benjamin Segall <bsegall@google.com>
CC: <mingo@redhat.com>, <peterz@infradead.org>, <juri.lelli@redhat.com>,
	<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
	<rostedt@goodmis.org>, <mgorman@suse.de>, <bristot@redhat.com>,
	<vschneid@redhat.com>, <changhuaixin@linux.alibaba.com>,
	<shanpeic@linux.alibaba.com>, <dtcccc@linux.alibaba.com>, <tj@kernel.org>,
	<linux-kernel@vger.kernel.org>, <zhangqiao22@huawei.com>,
	<judy.chenhui@huawei.com>, <yusongping@huawei.com>, <zhaowenhui8@huawei.com>,
	<liaoqixin@huawei.com>
References: <20240522031007.643498-1-serein.chengyu@huawei.com>
 <20240522031007.643498-3-serein.chengyu@huawei.com>
 <xm268qzt4jnx.fsf@google.com>
Content-Language: en-US
From: Cheng Yu <serein.chengyu@huawei.com>
In-Reply-To: <xm268qzt4jnx.fsf@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 2024/5/29 7:10, Benjamin Segall wrote:
> Cheng Yu <serein.chengyu@huawei.com> writes:
> 
>> In the cgroup v2 cpu subsystem, assuming we have a cgroup named 'test',
>> and we set cpu.max and cpu.max.burst:
>>     # echo 1000000 > /sys/fs/cgroup/test/cpu.max
>>     # echo 1000000 > /sys/fs/cgroup/test/cpu.max.burst
>>
>> Next we remove the restriction on cfs bandwidth:
>>     # echo max > /sys/fs/cgroup/test/cpu.max
>>     # cat /sys/fs/cgroup/test/cpu.max
>>     max 100000
>>     # cat /sys/fs/cgroup/test/cpu.max.burst
>>     1000000
>>
>> Now we expect that the value of burst should be 0. When the burst is 0,
>> it means that the restriction on burst is cancelled.
>>
>> Fixes: f4183717b370 ("sched/fair: Introduce the burstable CFS controller")
>> Reported-by: Qixin Liao <liaoqixin@huawei.com>
>> Signed-off-by: Cheng Yu <serein.chengyu@huawei.com>
> 
> Yeah, makes sense. My general assumption would be to put these in one
> patch, but if there's a convention to separate v1 and v2 that I've
> missed, I have no opinion.
> 
> Reviewed-by: Ben Segall <bsegall@google.com>
> 
Thanks for the advice. I will submit a v2 patch that includes both cgroup v1 and v2 modification.

>> ---
>>  kernel/sched/core.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index e9198e30bb74..982d357b3983 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -11414,8 +11414,11 @@ static ssize_t cpu_max_write(struct kernfs_open_file *of,
>>  	int ret;
>>  
>>  	ret = cpu_period_quota_parse(buf, &period, &quota);
>> -	if (!ret)
>> +	if (!ret) {
>> +		if (quota == RUNTIME_INF)
>> +			burst = 0;
>>  		ret = tg_set_cfs_bandwidth(tg, period, quota, burst);
>> +	}
>>  	return ret ?: nbytes;
>>  }
>>  #endif