Received-SPF: pass (google.com: domain of linux-kernel+bounces-193544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Zhang, Lixu" <lixu.zhang@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, Srinivas Pandruvada
	<srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>, "linux-input@vger.kernel.org"
	<linux-input@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] HID: intel-ish-hid: fix cache management mistake
Thread-Topic: [PATCH 1/2] HID: intel-ish-hid: fix cache management mistake
Thread-Index: AQHasPZUv9c8QpESZEiMh4a/JLYAj7GtvJ2w
Date: Wed, 29 May 2024 06:46:49 +0000
Message-ID: <DM4PR11MB5995875EEC9ACCFC43D8B86A93F22@DM4PR11MB5995.namprd11.prod.outlook.com>
References: <20240528115802.3122955-1-arnd@kernel.org>
In-Reply-To: <20240528115802.3122955-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3hutsPL6J9NHP4ldcHRHFlW1CyrNTIoB2gNhmNIfJiRsmFRQUBB7dZ2fSc5b?=
 =?us-ascii?Q?I/vdk9HIleBa4R7IeSV5BKkl30hN+ISFOuJR4XKxiI6e50gLae6dJl5ZsDxM?=
 =?us-ascii?Q?xiPFvPs9yR9SSY4yKBg9bq3cXu/U7AtBUKwVPeL7mmO3IhDf0R7C6xOdM+oW?=
 =?us-ascii?Q?3z0YaMxooq2anVTFG7pvKoUQaypzpLrUMl9L2xssAj9tVr57Dv9Bqy9ucn1V?=
 =?us-ascii?Q?xMCL6AI5bgS/TQDU0EBQHrzS2zqn43Q+uyotGOviKPmvYmpGspXfejZKR49P?=
 =?us-ascii?Q?ZpSsXYQdbs6YLsNdps5jf4NT6h1Ghsng6kuw18AMEwrFqdji6sAaxZDKEQ0f?=
 =?us-ascii?Q?CIhGdka43G30Yq0Q5FeANiyP4waCqZqDfTGL8E3dbRlrfsQI1/t/7vwQFKHh?=
 =?us-ascii?Q?XprATnlAkxkv+tYk8koZ8tZ/1xU0eXjKD/xcj9tqcm49fSM3w//sBuPyrd1f?=
 =?us-ascii?Q?0IEofrfy3CQ1xtefGduOR0OSGlDb+FBIhV/l0Oyzlg5FpMy6WjScrGsuJJB1?=
 =?us-ascii?Q?9BRKY/LckEYOZkv6g88x0OiESi+ecOWx5UMqNeKPsWy7C8og5/4K6gbyk84K?=
 =?us-ascii?Q?P7o15AGReVL1mZgaln7ujZN7qoEIfNkN7EG29XGBh93RX4awO+yJBWq3TNDM?=
 =?us-ascii?Q?wAeI0rMBu6YZEf77HGXjQnWk1PCYNC4dcY6t/010zXN2EDsuGLzD2PJpkzzZ?=
 =?us-ascii?Q?dBf4MBeomMtBIvZCScaR6nZCmMUFfywOJWpaAZ2ob5HuptI2tU9lBUwlsvQ2?=
 =?us-ascii?Q?mgjC4CdAsbhSbdkHiuSPswFEnQC+NcUtzwiFTiEU54gmdYy23GVhXEslN0vh?=
 =?us-ascii?Q?XFo0GARmYpngPKZT8h9Ch90pVwchhFyhxulxmdyXaUaZSbFYuvbND9Ted3fZ?=
 =?us-ascii?Q?vxTVn/nuycAXshkpGpqNUVdfwZx2RjAWZ056uX/Vr8jdh/iya8MTqJXRm+5t?=
 =?us-ascii?Q?XjYfXF21jPA1VMaG2gULuxgmyfOHyfOogeOKMprmXGT1nIW9Yug9MLkCbepC?=
 =?us-ascii?Q?TN1NWAB4tN3uidmy6cmRNBsITzzN1kgIHRX0zeqK4WMMLXBzd8lNGns0LLFN?=
 =?us-ascii?Q?RFm5tGLXyD0PALPSi+GUeNYbW46+5cMLrVCOnxGzHk5vXJkxHhKIhf4YtR5o?=
 =?us-ascii?Q?Ue9d64d5vHwQQrJ9R60uzg5A/os3NzMfoTj0k3vMz9Zc/niB/thH1w9J6UsK?=
 =?us-ascii?Q?aXebazHs8dCaSBL/iaQOcQ0xkI8pe7ckw7X5nBOp03annj5e3cCPJ4xx9wLB?=
 =?us-ascii?Q?+UtEbkQE5bgdYYA1xVGZyybS0SzVGG1FVMIBGm805I8HmzxLndQEsSnlCeq5?=
 =?us-ascii?Q?rZ9CPp1vFG1TWrxC8P5u5DUcV7qgc8xd2TZQJlCv5/c8LryxnlcD+/1pZ/rf?=
 =?us-ascii?Q?qUgoi5RzrcYvXHXKEbxDJmg5gpud2PAQ4xLKHjZxszKOoliA8pgMszbXBU4L?=
 =?us-ascii?Q?FDaIwsd4OCWIXKKsA2Q988cvDHBrsF9OTApaB2j6OjH0pmMU2h2gV0O8BlLY?=
 =?us-ascii?Q?Rxm8elMjiB0nVhpGFtItkez9agrIj9Ve6awPzMoGyHUDCs4HjBJooxPcyosx?=
 =?us-ascii?Q?hO0m+aWWBXJVvMNo0uQb7PvPjrqfVk0SYehkzt4R?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35b88b9b-4b3f-4cdc-1d3a-08dc7fab1e0a
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 06:46:49.9745
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nq8ZS+WsJZ2VF1zIlkALfEtUnG0Og4a/DmgGifTHmaUNPgTE/q2klEUDm6Ubmttm3XoG1lg66Ltly3hLxxrLsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5818
X-OriginatorOrg: intel.com


>-----Original Message-----
>From: Arnd Bergmann <arnd@kernel.org>
>Sent: Tuesday, May 28, 2024 7:58 PM
>To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>; Jiri Kosina
><jikos@kernel.org>; Benjamin Tissoires <bentiss@kernel.org>; Zhang, Lixu
><lixu.zhang@intel.com>
>Cc: Arnd Bergmann <arnd@arndb.de>; linux-input@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH 1/2] HID: intel-ish-hid: fix cache management mistake
>
>From: Arnd Bergmann <arnd@arndb.de>
>
>The low-level cache operation on a coherent buffer is incorrect, as cohere=
nt
>DMA memory may not actually be cached. Instead, use a DMA barrier that
>ensures that the data is visible to the DMA master before the address is a=
nd
>move the memcpy() before the reference.
>
>Fixes: 579a267e4617 ("HID: intel-ish-hid: Implement loading firmware from
>host feature")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
>I noticed this one while looking at the bug that was fixed in
>236049723826 ("HID: intel-ish-hid: Fix build error for COMPILE_TEST")
>---
> drivers/hid/intel-ish-hid/ishtp/loader.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/hid/intel-ish-hid/ishtp/loader.c b/drivers/hid/intel-=
ish-
>hid/ishtp/loader.c
>index 2785b04a2f5a..062d1b25eaa7 100644
>--- a/drivers/hid/intel-ish-hid/ishtp/loader.c
>+++ b/drivers/hid/intel-ish-hid/ishtp/loader.c
>@@ -33,7 +33,6 @@
>
> #define dev_fmt(fmt) "ISH loader: " fmt
>
>-#include <linux/cacheflush.h>
> #include <linux/container_of.h>
> #include <linux/dev_printk.h>
> #include <linux/dma-mapping.h>
>@@ -175,10 +174,11 @@ static int prepare_dma_bufs(struct ishtp_device
>*dev,
> 			return -ENOMEM;
>
> 		fragment->fragment_tbl[i].ddr_adrs =3D
>cpu_to_le64(dma_addr);
>+
>+		memcpy(dma_bufs[i], ish_fw->data + offset, fragment-
>>fragment_tbl[i].length);
fragment->fragment_tbl[i].length was used before assignment.
=20
>+		dma_wmb();
I tested it on the platform, but it didn't wok.

Thanks,
Lixu

> 		fragment->fragment_tbl[i].length =3D clamp(ish_fw->size -
>offset, 0, fragment_size);
> 		fragment->fragment_tbl[i].fw_off =3D offset;
>-		memcpy(dma_bufs[i], ish_fw->data + offset, fragment-
>>fragment_tbl[i].length);
>-		clflush_cache_range(dma_bufs[i], fragment_size);
>
> 		offset +=3D fragment->fragment_tbl[i].length;
> 	}
>--
>2.39.2