Received-SPF: pass (google.com: domain of linux-kernel+bounces-193557-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Zhang, Lixu" <lixu.zhang@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, Srinivas Pandruvada
	<srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>, "linux-input@vger.kernel.org"
	<linux-input@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion
Thread-Topic: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion
Thread-Index: AQHasPZdLbKTLNL+i0Gcu6hPPaUAiLGtyQNA
Date: Wed, 29 May 2024 07:05:28 +0000
Message-ID: <DM4PR11MB59959F1AE3E9BDA36642000B93F22@DM4PR11MB5995.namprd11.prod.outlook.com>
References: <20240528115802.3122955-1-arnd@kernel.org>
 <20240528115802.3122955-2-arnd@kernel.org>
In-Reply-To: <20240528115802.3122955-2-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ibisiAygxKMp3qTS2W4ecSaX8HRkq4tbx+JwUFUl4uAm5TxCTERMV0LsoG0a?=
 =?us-ascii?Q?YDEIfDC9CNe6xE0Pnk2rsFElndDWiwokwnyCc3PdGmujNfZx4LnWA5mOS/Q5?=
 =?us-ascii?Q?vcdJnTeB+ez43qJJl2/iDV2rFEnJr7cpHUWlAq02E2PNhVjJNoQoZTrdG503?=
 =?us-ascii?Q?WDb+o9dUWua6za642Xy/LcS5ZCuNjAR+c3aEcjdI+v5TlcJVF/Epi3wKlEXN?=
 =?us-ascii?Q?1XYUqPdD9oiVONkxmE8VyvzJxrtuKMweWqdY1Wmb+26k7sLHejiTZWZB9n5k?=
 =?us-ascii?Q?RVm8TfLWMIENFesXEieJNZTVaKu1u4jhkhg4ulPKj/2wJLAyfRPezgV6HW2V?=
 =?us-ascii?Q?JaMCN9+3D5D8Gfmp5HpSnmlAXeuLfqufa+liSHG0o8tKvlgHM2fMV/tg9vkm?=
 =?us-ascii?Q?i69N3xszxOmJjW2AqrbgyLRxiuvM6lJBloprH6qbkmfGgAE7TuU3YwB1ZI98?=
 =?us-ascii?Q?k7K7UrktDqhA6NM1YPoJEs21jgl02OcR4gX0takzR88TuukvX68ih4Kfc+Mt?=
 =?us-ascii?Q?jS+D9Vqqdn4VwN+9oX4Kk1GNBvSPpHpKwW9ft8nNNLteyIFrmeqCElF589kz?=
 =?us-ascii?Q?56gr9DVrYiuF4q5s+qgwo3Hy7sJSsBgYryEMtL8L3TKlH3f11UaxhU8X4FZU?=
 =?us-ascii?Q?FZrcaQVHi/11op5/GsOZ4kH0doivb7rPt6HodIm0p74Y5tSE/2BQsbrtXSp+?=
 =?us-ascii?Q?srkDQEqYJ9juK6uhtkGb3OJMTO/tQzQGCidnqAx45FXQW2HU3W9NXswYALv7?=
 =?us-ascii?Q?Hi13m7OU8vXtkhMaCfIny5GGqccOt3GdS1SjvMzKGx9IGk0ooXydSbmZxMdz?=
 =?us-ascii?Q?dVARBcVszAlqN4mxoIUN9JZa5xYDF9UVWcHQEh7jpzBCZ+DzbGzmIZJK5ked?=
 =?us-ascii?Q?EpO3Uivymt+BBalIhnZ8iP/j4WCtPvzmZ9mUaR3Zn73kTfgKTZc+0l0D77Jr?=
 =?us-ascii?Q?aY8Tu1eRNuYrDrF0f7zGlReRoxJBfcVUr5hMTs/2ALF6ScsonNIrvYd9I9LN?=
 =?us-ascii?Q?xyAL8j5Mg60bwCkFAHZRwOTzQYM7RNbYJQ0Zr+hEqS5cPE8f7a91rF9ZfPaE?=
 =?us-ascii?Q?2pUFeFqcU/dVFLrfSU2hvJ4wWS8f1WfMtTCqaLxH9uYzYAieFjdTFZegAI/0?=
 =?us-ascii?Q?rdsTRr2GJgfUdT1fPjlH1jEi8um3DG085tNvhtqn3hyiWAbKzaMQu3n54erf?=
 =?us-ascii?Q?2qW6Ae8gAwuLToQys1vIknmabVJD15tAW/fQAMiMwwp0wvXhVVYPL9I09vhk?=
 =?us-ascii?Q?hXpeVxL5y0HnmNPy7RNVqdHrnWDSydaf98F+9vN/eCE/lRzrRMkwCsVGhmhj?=
 =?us-ascii?Q?BKwhZG+vzZ5zhqKRWX8eqzakxNOsa9ASFMRvT6Bm9+A23f5csGUWvYWFLGi6?=
 =?us-ascii?Q?juPxtue9yGuLXgHx99JDCf/st1vniRFcNdPE8da5YHwXj5/LBP3g6hmGyeE6?=
 =?us-ascii?Q?q4xNnlZqHms5md/2TSkpvmx4d6EFSgq3THkU3Wbji8tsNITuk668zwmSZfni?=
 =?us-ascii?Q?R7jKBU4HFzWo7breif2Mew2upFpx0ZEiYWkwDkqcaIjdGkW62LMm+T3typXz?=
 =?us-ascii?Q?t3zqIiVwsr1Y+CzNKwd2treA1sVq2qx8ka0VAPN7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f331904e-3b9e-41d7-b6b9-08dc7fadb897
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 07:05:28.2690
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2H6JauasEHk5KrGRUc94xyvsGaGn+1Xedxyd5S18NQ2MiGY6p8VPoq4/UbLmjo5/JeHdj23fanZp9eWougxzqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5127
X-OriginatorOrg: intel.com

>-----Original Message-----
>From: Arnd Bergmann <arnd@kernel.org>
>Sent: Tuesday, May 28, 2024 7:58 PM
>To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>; Jiri Kosina
><jikos@kernel.org>; Benjamin Tissoires <bentiss@kernel.org>; Zhang, Lixu
><lixu.zhang@intel.com>
>Cc: Arnd Bergmann <arnd@arndb.de>; linux-input@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion
>
>From: Arnd Bergmann <arnd@arndb.de>
>
>The newly added file causes a ton of sparse warnings about the incorrect u=
se of
>__le32 and similar types:
>
>drivers/hid/intel-ish-hid/ishtp/loader.c:179:17: warning: cast from restri=
cted
>__le32
>drivers/hid/intel-ish-hid/ishtp/loader.c:182:50: warning: incorrect type i=
n
>assignment (different base types)
>drivers/hid/intel-ish-hid/ishtp/loader.c:182:50:    expected restricted __=
le32
>[usertype] length
>drivers/hid/intel-ish-hid/ishtp/loader.c:182:50:    got restricted __le16
>[usertype]
>drivers/hid/intel-ish-hid/ishtp/loader.c:183:50: warning: incorrect type i=
n
>assignment (different base types)
>drivers/hid/intel-ish-hid/ishtp/loader.c:183:50:    expected restricted __=
le32
>[usertype] fw_off
>drivers/hid/intel-ish-hid/ishtp/loader.c:183:50:    got restricted __le16
>[usertype]
>
>Add the necessary conversions and use temporary variables where appropriat=
e
>to avoid converting back.
>
>Fixes: 579a267e4617 ("HID: intel-ish-hid: Implement loading firmware from
>host feature")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
>I noticed this one while looking at the bug that was fixed in
>236049723826 ("HID: intel-ish-hid: Fix build error for COMPILE_TEST")
>---
> drivers/hid/intel-ish-hid/ishtp/loader.c | 69 +++++++++++++-----------
>drivers/hid/intel-ish-hid/ishtp/loader.h | 33 +++++++-----
> 2 files changed, 58 insertions(+), 44 deletions(-)
>
>diff --git a/drivers/hid/intel-ish-hid/ishtp/loader.c b/drivers/hid/intel-=
ish-
>hid/ishtp/loader.c
>index 062d1b25eaa7..1d4cb99d2130 100644
>--- a/drivers/hid/intel-ish-hid/ishtp/loader.c
>+++ b/drivers/hid/intel-ish-hid/ishtp/loader.c
..

>@@ -162,25 +165,30 @@ static void release_dma_bufs(struct ishtp_device
>*dev,  static int prepare_dma_bufs(struct ishtp_device *dev,
> 			    const struct firmware *ish_fw,
> 			    struct loader_xfer_dma_fragment *fragment,
>-			    void **dma_bufs, u32 fragment_size)
>+			    void **dma_bufs, u32 fragment_size, u32
>fragment_count)
See below.

> {
> 	dma_addr_t dma_addr;
> 	u32 offset =3D 0;
>+	u32 length;
> 	int i;
>
> 	for (i =3D 0; i < fragment->fragment_cnt && offset < ish_fw->size; i++) =
{
You added a parameter fragment_count, but you didn't use it. Did you intend=
 to use it here?

Thanks,
Lixu
> 		dma_bufs[i] =3D dma_alloc_coherent(dev->devc, fragment_size,
>&dma_addr, GFP_KERNEL);
>+		dma_bufs[i] =3D dma_alloc_coherent(dev->devc, fragment_size,
>+						 &dma, GFP_KERNEL);
> 		if (!dma_bufs[i])
> 			return -ENOMEM;