Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp460373lqb; Wed, 29 May 2024 00:13:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVGRiyNSvpNz7bM6gm5JMclkFw5c4PsraCs3x9+tq1u6cP6c5eDXTpOHBKfdove5girh/S+CVv8A9pfZ6VylsUxcvFlXoPxfaAXfiXwFw== X-Google-Smtp-Source: AGHT+IE+GxTP7vrL8gx+77lC0KdNvfO0h/SOMTCqIr7F7+lvAsezru78fSRc5efjLQ2tmcII3ktk X-Received: by 2002:a81:6e45:0:b0:618:8a27:f06 with SMTP id 00721157ae682-62a08d759e7mr159587897b3.9.1716966831555; Wed, 29 May 2024 00:13:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716966831; cv=pass; d=google.com; s=arc-20160816; b=ofDV75aIopdbW9r1n5PiQN6wtjP0mduZZL6jjbGdltadrnrogBKaji8AG+TeRSMG9F hQRCQ7m19bkgNAzFn7W9lSfBvcjqRvcMIQSVl72a/rwKXHG+VKvlQMfDEIJAIPOwd6VM 5FsT0MAXJ7gA62+vnbCTEydDqqxrdqzGjpCxN2s37uRdBJmPuylLR7Du8CVcFIOvXgc4 16J6eRba7P5mpJWPgx1Xrs7QW6x9M3Wja2WxhSYnHpYuG+TgdxbUEc4qtDwU6uJQD0Yg s3JQMflOghfWItqTFFqqZ+c3cCRe5ISj4h9Jlfkb2yVGe9jCtmS07XLjWnwAffxprp9N q9Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q6bYzyZnFYI4qrsZB34ycSG1lMjbB+dLnkiJDJkyrtc=; fh=bniBxiaoEXld5IzwWJ6Xi4AANjfuF1YHidIuBw0dwkk=; b=NQpqJtI0y07+U77XBPWsiAN66NuafyTZfdJvFqFgepRMeGkwmSZ9wIvzS3+te611jT hjBv77ykTrj//I078UQgkbysO1VKnNdOB0G+fRJJu7ci4s1wwVGnyJxnMkEfyUgTbaJA aPKHXLHNec1aD70uEinsjoy6N4WLBtTAyB0a7o3myFSITHxcgpEEhfVH6kIz+eDiNf0p doDS9dF11FytYPrykQ5cVLGQQY97A+32oSVUg457ZAHSX8f4vSCP5Zd7YRFMkvjUWU5W 1X+35Cy2mgXhGqGxC6Aqu8CZuVrqBapwI3nRb1Y9473E/QH2YV0+fczPlaNYVVl2MofZ 0JGA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ABCHHcqy; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-193565-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-193565-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-794abd15ed0si1178707585a.370.2024.05.29.00.13.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 00:13:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-193565-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ABCHHcqy; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-193565-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-193565-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 67E1C1C23AEE for ; Wed, 29 May 2024 07:12:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4FCCB1667CE; Wed, 29 May 2024 07:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ABCHHcqy" Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 472E515B99A for ; Wed, 29 May 2024 07:12:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716966768; cv=none; b=kciw/q79z4SgOvgJUGvrFupWmY7lNBjtL+kUy4CXCeKsV2DKQjEMVTL00y3I+EuYgVIziNKXhxIPADcBX6DYfC32hLpqy/vOTUBB4vto6g9jemO7gaJXn+al/153C7qk+MXSBode1Vn1w5ee2oRmxHyrubYy/lw1CPGwyda5wUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716966768; c=relaxed/simple; bh=cAQbvBmUpMCA3gTxY1IDXFVX17vOV0Rw+rnvXDMYKiA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O52AFulTewnZxfxUiePKhoUHBhmzyiIcy0yx4u2SPl2jgLnjAWkiuZJtuGU+2CLzjUQR9+Agm3Sjxe25nlaYoLP9erapBJK/3oUz3IB+GtxgLsNv4/7mMZSxIl5xPTehBfeJFIzZNxZw4dvEDIiCxTEnRS9L4gnrpyShMMGlrmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ABCHHcqy; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1f48bd643a0so13082445ad.3 for ; Wed, 29 May 2024 00:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716966766; x=1717571566; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Q6bYzyZnFYI4qrsZB34ycSG1lMjbB+dLnkiJDJkyrtc=; b=ABCHHcqyf7tcOOdhjgl6YVaIW0brYMjmgedFmpqM0BzLF28Hp+Y8crXOpp+gymYupr fzObq6gNQ7Gnm556LEjXZh0AgaLdXYcGv8+ur9htYjxg/X9q+URJWe3d//Qv1ubsrP+J w/dA+ObFFTblwFO/kq38sAK9NYOhE/2EIISLEKZz1UuQ3m6IlzpUmfaOr6gR28zbVhzs SIMwIGF66Y4CzzyIWbJTpBT76WWRrVo3c8tz/XuQZch3/yG84Iudp5jGVKa9lm1fHIhM i/3PwXLIBtDJRyzhO4niEagOR+ESWBiXWzH48k7JLeRbkQvyUP44SXH065VZjnRq+HcI K3Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716966766; x=1717571566; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q6bYzyZnFYI4qrsZB34ycSG1lMjbB+dLnkiJDJkyrtc=; b=G2Lzy0THj3eihDl5WkyDcTmNNfsNRXVQqwzISmasXoz2tIF43M4Kx60/Rxqa2PU6Xz Cf1yKGihcVDwyExhhGr1VuwKkZA70WH0kKXJTGvizHg4nla8Y9l9vaZmUmawfox9+r7H EMkpPjULe0SwH501zTmlWDWbtADX8udp31gARQSAcY+uCEwoO7VwRb73cUbGcDTOgM2I KMgwfo5jnMtTqYyR9N78BRe+S3sfcliw/kdX9+lVIfw514IgBtmW21oFefyjKrT5jTp/ RXWGvFO1h7wVdCtNOilXst3l9JhsqPzLFofyTi9J/BCp7l80N8XE1EZUSpO/Bk1gkukD 3yPg== X-Forwarded-Encrypted: i=1; AJvYcCWRXOcnfNs7Rn7auRNS7zjM7vmtJrWjhE/5W+PheJ5BGGJytDGjwyQgV9cixu4ZfP+oitpYpziVXoMuVtZ0lPaFiWc32XengFvlEHy7 X-Gm-Message-State: AOJu0Yzpo+Xg/C7FgogkHcbMeiD7YDjYNbNu0r6v6Mb+Di6L3fmlDJIk +efS0KRcUntDiQJOsDHeCCbYSOeN/wSJE5opa5H5RdwZ10iyrQrV0e2/1Mw4Fbs= X-Received: by 2002:a17:902:e750:b0:1f4:7d47:b889 with SMTP id d9443c01a7336-1f47d47bd5emr119995205ad.30.1716966766454; Wed, 29 May 2024 00:12:46 -0700 (PDT) Received: from localhost ([122.172.82.13]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f477d337cdsm67413355ad.71.2024.05.29.00.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 00:12:45 -0700 (PDT) Date: Wed, 29 May 2024 12:42:44 +0530 From: Viresh Kumar To: Riwen Lu Cc: rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Riwen Lu Subject: Re: [PATCH v2] cpufreq/cppc: Take policy->cur into judge when set target Message-ID: <20240529071244.vwognqagaa4347dm@vireshk-i7> References: <20240529053652.pzcjoyor7i23qc4i@vireshk-i7> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 29-05-24, 14:53, Riwen Lu wrote: > Yes, you are right, I didn't think it through. In this circumstance, the > policy->cur is the highest frequency, desired_perf converted from > target_freq is the same with cpu_data->perf_ctrls.desired_perf which > shouldn't. Please investigate more and see where the real problem is. -- viresh