Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp466940lqb; Wed, 29 May 2024 00:32:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUpA6Xn3ckVTdLiUoihK4CzqLKVJUnWT0voqj106aPdheq7dGHwdfGn/76YFndOX392NbEn8Bp284I0KN8ncCQr4p4VcNWTfkCZXGWJIw== X-Google-Smtp-Source: AGHT+IHXggtw0I9jhtNuSJ83fJpqskf0+RNamAO1XlzwC3vtxdMNPrfgnblEac4ad5w+OJ5kYbBL X-Received: by 2002:a50:a682:0:b0:578:4b46:7ac6 with SMTP id 4fb4d7f45d1cf-578519be672mr10052181a12.27.1716967952367; Wed, 29 May 2024 00:32:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716967952; cv=pass; d=google.com; s=arc-20160816; b=hLkbVui59YR8xwMqBvjvjWiEEWTg1tT6nFAQlMpPXR43tKwsqlBiBvZdWb/g35CH0i sifUBJqsxGx7ezggcry+XNBmic3+6eTEZwlZJ4eFmVUdem7uiR3+HWAPXASNzS7VQW9q cPKtbyWh6mIin7AyH5+iDpItXCRXyIc8Jnf5gPFKZ7YzXGIR2kxHcVVYHJl1x0vcNPFa 14l9HhNX10or4xHVhZ5IERVSr1QO+cNEba1LaR2bWs0hriEjZTvE6vUxvTwk1oiQcyXX xRlbhSjwwZ0PoGODTBr6m2S5czHUxOEagsFQRc/QC2MgpRZ+qEOiYmqicljKhQ7xNxwK hp6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=GM0A3blGp3ofiK+Cl5S1VLwDayXEVb1JbumqMZyU5dc=; fh=PUgK/+R5zKTCmY4zd/8A6YXkla42L9Z29s0jfB5hlew=; b=sPmKjLDUYQrCIN5ud2vwLdpzAECTtCu8pFU2yJ+FCCAMyNWabFpC9PqdiVeg1E6Mig BB6MHo0r8566thJ0cvd15SWOoP7f2y19aSwalWM+0TtQAh3+o7XsieKwy5JV7NkPYR87 MYjIR0oILCxGkEpcFjpt86O2YEatziHUTdUbKWZZCpFTYFN8oDij6coeKRItwYbTXpex bKBs3VuRGZWjLEoX7PTyijY/HGevRJPd6KKot1qVxvdlpCcAviI4WKoH+i7aMvonzofS Mo4YZcfpdUFXpORcfpIwJY4USGbJ37K65NbnK1C4qLek7GJxShqo3MqWvzEtdLiKM5cW APFg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=BrZRV001; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-193590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-193590-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-579bfa09cedsi4676942a12.3.2024.05.29.00.32.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 00:32:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-193590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=BrZRV001; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-193590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-193590-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1BD1D1F29D5C for ; Wed, 29 May 2024 07:32:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B5D016729D; Wed, 29 May 2024 07:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="BrZRV001" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EF8115CD6C; Wed, 29 May 2024 07:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716967942; cv=none; b=nNNbMOO22u/dUBVXdcn8+HlNbTw1aYbmIL60DGB6I3i1zYx5mZJSIsXIpZVm6yfVmsWmIey+LF3JjU2QOowBSEcibevqcvdVMkFZtb7c9TQjcQP9jY9zVJowmYXyZ6HAneK4S+OqqcYgY5El19+aEIB2YySoujuCznMg1BOgUa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716967942; c=relaxed/simple; bh=cADutWs2Dsx1o9inKNPez5xFnY+sOuOUeUDqJ44drFk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gDONJu1wkrfmtMV1xYr9zuk7MlnNxHFIEyrNZfG0QQGn6uQSk4jlVSYzDMUIZTCEeUxIOJbeTDTay1xxcymskNePcvyiiA4FrvLP4yWnti5Uc5tm/Usbqb1B+LBrJElqaVM96xHhlQDQbqz0ReiXT77GkC0hMYRTQbkKqqbaCE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=BrZRV001; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1716967939; bh=cADutWs2Dsx1o9inKNPez5xFnY+sOuOUeUDqJ44drFk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BrZRV001CJRtCqhATXy9C/FXVikr+5BdllJGZ2rStBbfQk7E4RecsGhHyLUYYTaIX DdX1+wJBWQFYV5tjrx9nrd9tQQJymjFfZSy6VjmJioLWGMpiRHvVXQcCdNqEjHg2nc 5Ofxh4snXgHT9f0visanV+QcHJiyJBN05ySKzTc3bXeWPSMtlxnPKH6PZ80J06d8dh S9WP60/wwTTEDRUGmWqBV3OvWMlJ/QKPqS3N9XUPm0tVd+j32q0IXhPWDAzVjl0jg6 RjMI6caeXqeU15q9tG1E37Yw3kWZXMAASFBGSEMNh/yZchKQ5k8TQK7AdofrfG5BSK Nino7JsVpA7dA== Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 0DFB63780627; Wed, 29 May 2024 07:32:18 +0000 (UTC) Date: Wed, 29 May 2024 09:32:16 +0200 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sumit Semwal , Christian =?UTF-8?B?S8O2bmln?= , Dmitry Osipenko , Zack Rusin , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v4 0/3] drm: Fix dma_resv deadlock at drm object pin time Message-ID: <20240529093216.6640d05d@collabora.com> In-Reply-To: <20240523113236.432585-1-adrian.larumbe@collabora.com> References: <20240523113236.432585-1-adrian.larumbe@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 23 May 2024 12:32:16 +0100 Adri=C3=A1n Larumbe wrote: > This is v4 of https://lore.kernel.org/lkml/20240521181817.097af5e1@collab= ora.com/T/ >=20 > The goal of this patch series is fixing a deadlock upon locking the dma r= eservation > of a DRM gem object when pinning it, at a prime import operation. >=20 > Changelog: > v3: > - Split driver fixes into separate commits for Panfrost and Lima > - Make drivers call drm_gem_shmem_pin_locked instead of drm_gem_shmem_ob= ject_pin > - Improved commit message for first patch to explain why dma resv lockin= g in the=20 > pin callback is no longer necessary. > v2: > - Removed comment explaining reason why an already-locked > pin function replaced the locked variant inside Panfrost's > object pin callback. > - Moved already-assigned attachment warning into generic > already-locked gem object pin function >=20 >=20 > Adri=C3=A1n Larumbe (3): > drm/panfrost: Fix dma_resv deadlock at drm object pin time > drm/lima: Fix dma_resv deadlock at drm object pin time > drm/gem-shmem: Add import attachment warning to locked pin function Queued to drm-misc-fixes. Thanks! Boris