Received-SPF: pass (google.com: domain of linux-kernel+bounces-193597-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 29 May 2024 08:58:41 +0100
From: Conor Dooley <conor.dooley@microchip.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
CC: <jdelvare@suse.com>, <linux@roeck-us.net>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <ukleinek@kernel.org>,
	<linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: hwmon: Add adt7475 fan/pwm properties
Message-ID: <20240529-faucet-vending-3e330f8eb67b@wendy>
References: <20240528225638.1211676-1-chris.packham@alliedtelesis.co.nz>
 <20240528225638.1211676-2-chris.packham@alliedtelesis.co.nz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="4wiA+HKJ9TqC3xZp"
Content-Disposition: inline
In-Reply-To: <20240528225638.1211676-2-chris.packham@alliedtelesis.co.nz>

--4wiA+HKJ9TqC3xZp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 29, 2024 at 10:56:36AM +1200, Chris Packham wrote:
> Add fan child nodes that allow describing the connections for the
> ADT7475 to the fans it controls. This also allows setting some
> initial values for the pwm duty cycle and frequency.
>=20
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>=20
> Notes:
>     I realise there is still some discussion about how to express the
>     frequency and duty cycle. I have a personal preference for using hertz
>     for the frequency and 0-255 for the duty cycle but if the consensus is
>     to express these things some other way I'm fine with doing some math.

Probably worth carrying a link to it here:
https://lore.kernel.org/all/4de798f3-069e-4028-a5b5-5e6a639277e3@alliedtele=
sis.co.nz/

I asked Uwe to take a look & it's on his todo list.

Thanks,
Conor.

>    =20
>     Changes in v4:
>     - 0 is not a valid frequency value
>     Changes in v3:
>     - Use the pwm provider/consumer bindings
>     Changes in v2:
>     - Document 0 as a valid value (leaves hardware as-is)
>=20
>  .../devicetree/bindings/hwmon/adt7475.yaml    | 25 ++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.yaml b/Docum=
entation/devicetree/bindings/hwmon/adt7475.yaml
> index 051c976ab711..bfef4c803bf7 100644
> --- a/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> @@ -51,6 +51,15 @@ properties:
>        enum: [0, 1]
>        default: 1
> =20
> +  "#pwm-cells":
> +    const: 4
> +    description: |
> +      Number of cells in a PWM specifier.
> +      - 0: The pwm channel
> +      - 1: The pwm frequency in hertz - 11, 14, 22, 29, 35, 44, 58, 88, =
22500
> +      - 2: PWM flags 0 or PWM_POLARITY_INVERTED
> +      - 3: The default pwm duty cycle - 0-255
> +
>  patternProperties:
>    "^adi,bypass-attenuator-in[0-4]$":
>      description: |
> @@ -81,6 +90,10 @@ patternProperties:
>        - smbalert#
>        - gpio
> =20
> +  "^fan-[0-9]+$":
> +    $ref: fan-common.yaml#
> +    unevaluatedProperties: false
> +
>  required:
>    - compatible
>    - reg
> @@ -89,11 +102,12 @@ additionalProperties: false
> =20
>  examples:
>    - |
> +    #include <dt-bindings/pwm/pwm.h>
>      i2c {
>        #address-cells =3D <1>;
>        #size-cells =3D <0>;
> =20
> -      hwmon@2e {
> +      pwm: hwmon@2e {
>          compatible =3D "adi,adt7476";
>          reg =3D <0x2e>;
>          adi,bypass-attenuator-in0 =3D <1>;
> @@ -101,5 +115,14 @@ examples:
>          adi,pwm-active-state =3D <1 0 1>;
>          adi,pin10-function =3D "smbalert#";
>          adi,pin14-function =3D "tach4";
> +        #pwm-cells =3D <4>;
> +
> +        fan-0 {
> +          pwms =3D <&pwm 0 22500 PWM_POLARITY_INVERTED 255>;
> +        };
> +
> +        fan-1 {
> +          pwms =3D <&pwm 2 22500 PWM_POLARITY_INVERTED 255>;
> +        };
>        };
>      };
> --=20
> 2.45.1
>=20

--4wiA+HKJ9TqC3xZp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZlbgLAAKCRB4tDGHoIJi
0tu6AP4/nFnJfrf121gHJBfzksW6XCKET471Txd1cGwJLuTE8QD+OUN7EKN/Vkag
6uwCY8eQG03BAO5DRYNaweHCiQSzdgQ=
=LSol
-----END PGP SIGNATURE-----

--4wiA+HKJ9TqC3xZp--