Received-SPF: pass (google.com: domain of linux-kernel+bounces-193474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 28 May 2024 22:44:03 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Li Nan <linan666@huaweicloud.com>
Cc: Christoph Hellwig <hch@infradead.org>, song@kernel.org,
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	yukuai3@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com,
	yangerkun@huawei.com
Subject: Re: [PATCH v2] md: make md_flush_request() more readable
Message-ID: <ZlbAo1XgsPAxQ2Qe@infradead.org>
References: <20240528203149.2383260-1-linan666@huaweicloud.com>
 <ZlXa5mFl9x4Lk4KQ@infradead.org>
 <bc582a25-2124-2aa8-f26b-94fd5a50f900@huaweicloud.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bc582a25-2124-2aa8-f26b-94fd5a50f900@huaweicloud.com>

On Tue, May 28, 2024 at 09:49:44PM +0800, Li Nan wrote:
> 
> 
> 在 2024/5/28 21:23, Christoph Hellwig 写道:
> > Looks good:
> > 
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > 
> > .
> As suggested by Kuai, I will use bio_sectors instead of bi_size in v3.
> 
> -       if (bio->bi_iter.bi_size == 0) {
> +       if (!bio_sectors(bio)) {

That looks weird.   bio_sectors literally just shifts
bio->bi_iter.bi_size to be in units of sectors, which doesn't
matter for comparing with 0.