Received-SPF: pass (google.com: domain of linux-kernel+bounces-193636-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <091f1d5c-0bff-4dcb-b823-b82989eac628@nxp.com>
Date: Wed, 29 May 2024 15:50:24 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
 Andrzej Hajda <andrzej.hajda@intel.com>,
 Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Fabio Estevam <festevam@gmail.com>
Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240529065400.461633-1-alexander.stein@ew.tq-group.com>
From: Liu Ying <victor.liu@nxp.com>
Content-Language: en-US
In-Reply-To: <20240529065400.461633-1-alexander.stein@ew.tq-group.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?RXJKUGFDaHFtWnBEWmdXdnJoMXo3S2tFRHJvSktONkFCa054VklCRlBxSWxP?=
 =?utf-8?B?VFVQZ1NBQU45L0RHbXdsK2dNcU5mQnJzZFFCNG85bGkrZmx2QW1SdXBDVTB3?=
 =?utf-8?B?TklHQS95RGExMHVnNUZnNVpZNGVEY21lMnQ5TndGYkUwTzk2NjA5SEo2bFh4?=
 =?utf-8?B?MmpyVHRjZ1UxU1BvYTd4VDZJaCszWEZKWE92Z0lUblVCR2FhbEpoUHRmRW5t?=
 =?utf-8?B?cFRIaFVycDg2MnJneGVsQXRKTVdnYXFCNktxOEtBb3VRVGhWTnRzcy9rcS8v?=
 =?utf-8?B?S3lJYVRnZlhYRWhKdHZQV3BnWlVTWllNeVp0YzM0TUZlT3dZOUpBWVhJaGRv?=
 =?utf-8?B?bFhUM0xJelpMd3JabEE2eEJvSHRpMWtpN0ZBQ3pNNVVpbUFJbHlZVUZidUta?=
 =?utf-8?B?VVpPUGN5QjlPRlhmd0MxSGE2Rmw0TUlXWjY0QzJ5dmQ5RTZnMmhSS2VvRlF2?=
 =?utf-8?B?T1JZMWZyaXZXb0NKUHhPa29aVDBqR3ZwaW55em9Td1QyWG5RUzB3YzJyOXVJ?=
 =?utf-8?B?QzIwVFF2MWpOZ21nc08vOVlpWFBHbXFORUtZOVFFUmNoTVdpVGxxakxBTmtC?=
 =?utf-8?B?aXl6NFljZnhXcU5ZeVh0cS8zeHhFM2hJU0pQQ1RUQkhudk1SYjlXL0x6VjRO?=
 =?utf-8?B?Y1JNUFpvcGdnUWRqU3RHT0cyK1VWMW9PdkFvT2ltNCtnLzdFVW1wZFM1bXM3?=
 =?utf-8?B?S1ZPZUtMN2ZwQjZSMUowK2tvd2Y3amtQZDhkWlBwU2tDT0R0aTR1T0x4Y0lD?=
 =?utf-8?B?TVp0T3d3SmhrZlJTUlRkTnF5V202M1FVNlp2Ymk5dkFPVFQvY2tDZjVkand3?=
 =?utf-8?B?TmNXdUxUM1huN0cxQ0FCakZ5dnpzcno1RDlSQVloYS9KNTZ4M1JzK1VFYkZw?=
 =?utf-8?B?QWFjOU1sV2pJSVRHSVNucVVaUmwwWFhPelFEeHgzaTJVU1VxY1htVklkbndz?=
 =?utf-8?B?KzVpSkpDa2RCbS9KNmw4SGVGNTBNWWNRT1paSWlXb1lhdVV4L3BiTnZxR2V5?=
 =?utf-8?B?TFZPd004UWRwR3I5UkV2Nm11UlNaQi9HNjFFR25VbGNWcVRLcXNWNC9zU1Rv?=
 =?utf-8?B?eENqZTBiSGpzTHYyTG5YWDZ2L29rZkVnNGVkVm5yZTB6aEtPMStmQm9mZTZY?=
 =?utf-8?B?bE5EdXFZeXREUjdxQmRMVXN1c2xtV3liOExleXZ5Q3M5WW1tZWRJWmwzUkxU?=
 =?utf-8?B?UGQyRVhlRk5KdmREY0tBYy9INy9UK3ZLNm9WYjg2L3MveUF4cm5KKzNYQndx?=
 =?utf-8?B?Wjg2ajI4VStVdFo1MGsxZ1BFc3hreWhIb1FzVWFsQ3ZsSnZONUwzZEFYM0Ey?=
 =?utf-8?B?cGZSUkFpdHNmZGhFMkoyRWRrdmUwTndYTk1DQ0d3VUxuQUhRZXB3WU9MbUtU?=
 =?utf-8?B?UjRYSFpmU2JJRzZuc2VtTmVISGJVTUxFcTcxbWxyVlY5bGgyVENFdVlOZDBt?=
 =?utf-8?B?S2FwbmZPa2lqODZrVllSeWxPV09NWmg5RGQvOHl3UWhDQ3N3TmIzMU9HUXQ2?=
 =?utf-8?B?OWJhMW41SmFJVWlhVTJ5WjltMzNMMml2eHUrdk9kOFNrcTRFRUduVy9vVCtS?=
 =?utf-8?B?V2d5TXBRK0hKUzRDSDRqeXBQd21HY2pBRlpkdnVzazVtRHd6Qk1BVmdnLzBl?=
 =?utf-8?B?OXRPaU1aMzR1eU5BWFoyUTVaaUROZjFHRWp0VWpkaHFvcDBYMU92dEtEa1Bz?=
 =?utf-8?B?aHc0ZWd0cWlxOGdzc1MraGkyVlZyNCtFWTZhNWx5RW90MDVaMUhLTC9KbXdj?=
 =?utf-8?B?ajFySmIyNFZzZWZYNWVlUmp0QzVnbmczdi8rbmFJTE40RVlTSUNuUURIUXJN?=
 =?utf-8?B?c092YnJHdlZ3NGlyWGdsaWVXTUNCck8rNWlFMjE1bXBhUGF5cjRzQ1ZaZmZ4?=
 =?utf-8?B?aGhHZGFJTmZvK3pUTWZnZnVHUTE5Nkg3aWlTNEFtcGNzeXcwdTI2Q0Y1QVY5?=
 =?utf-8?B?T0NmSFluVlBacUd2TUJqNHZWT0NjQkZJbHBpcWdVQ1VRdFdZbjNQeWJhaEc0?=
 =?utf-8?B?Zkw5emhET0VIYVYrbk1TVUlxeDZpem82MHdFVGpSRnUzZ2NWMXVVdk9TUkMx?=
 =?utf-8?B?Z05iSnlHWURINDZqUS8yc3RVTmNVV1VsbXRSMjdEV0ZHbzV6RHRCdW1jM2Yy?=
 =?utf-8?Q?BZiMjzeptkkqHQQnIDlPLSx1x?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bfd5537f-a34c-4c10-cfb6-08dc7fb3f476
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 07:50:05.8513
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7Nv2dQ6VxDd7t4/lxcLXsFaoE+pXi8FS1KxfxFahwySCfBYbdv555NvAtGqfI6fxDxPhKaEQ0R9Cod00ShcL0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8025

On 05/29/2024, Alexander Stein wrote:
> Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible
> removed), it lines up with the other error paths in probe function.

Why media_blk_ctrl needs 'syscon' compatible removed?

device_node_get_regmap may return error pointer other than
ERR_PTR(-EPROBE_DEFER), like ERR_PTR(-ENOMEM).

struct regmap *syscon_node_to_regmap(struct device_node *np)                     
{                                                                                
        if (!of_device_is_compatible(np, "syscon"))                              
                return ERR_PTR(-EINVAL);                                         
                                                                                 
        return device_node_get_regmap(np, true);                                 
}                                                                                
EXPORT_SYMBOL_GPL(syscon_node_to_regmap);

Regard,
Liu Ying

> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Removed unused variable
> * Added missing \n at end of string
> 
>  drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> index 2347f8dd632f9..13025f47f3902 100644
> --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> @@ -834,18 +834,15 @@ static int imx93_dsi_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct device_node *np = dev->of_node;
>  	struct imx93_dsi *dsi;
> -	int ret;
>  
>  	dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
>  	if (!dsi)
>  		return -ENOMEM;
>  
>  	dsi->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,media-blk-ctrl");
> -	if (IS_ERR(dsi->regmap)) {
> -		ret = PTR_ERR(dsi->regmap);
> -		dev_err(dev, "failed to get block ctrl regmap: %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(dsi->regmap))
> +		return dev_err_probe(dev, PTR_ERR(dsi->regmap),
> +				     "failed to get block ctrl regmap\n");
>  
>  	dsi->clk_pixel = devm_clk_get(dev, "pix");
>  	if (IS_ERR(dsi->clk_pixel))