Received-SPF: pass (google.com: domain of linux-kernel+bounces-193675-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 29 May 2024 15:54:26 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
CC: kernel test robot <lkp@intel.com>, <oe-kbuild-all@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [paulmck-rcu:dev.2024.05.18a 44/51] update.c:undefined reference
 to `cmpxchg_emu_u8'
Message-ID: <ZlbfMhpMmeGU+4aH@yujie-X299>
References: <202405271352.XYjxKyUi-lkp@intel.com>
 <df54d8ab-514d-409f-8522-b0790a12b953@paulmck-laptop>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <df54d8ab-514d-409f-8522-b0790a12b953@paulmck-laptop>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n9C3wrLKXLuQHd8XHrIuo01TrGEW2WJkki9PacDuOY2uzWPc/xzV68z+nkic?=
 =?us-ascii?Q?jCo5rn6lSpQluW+5pAzyu9+tyIR6InVj6ErB+OJrb7u0+z3ibA3D0jJ2ivBN?=
 =?us-ascii?Q?LduK5UdBCNQD1deto6U8733lCrJF49IPzm3zMF8yrzOAAy3Pa0BJas5F/Vbi?=
 =?us-ascii?Q?wCgx9MRlF9JlY8QsJkEkXR0mnwqiiskM5R5CmDyyiQYaMvJQ/xuCy7n1kRxJ?=
 =?us-ascii?Q?/5DciriLtcdOLIkF/Wj3noZ9leAmktINpAm270zkuPm/Ozv+gH9bN0foVIBU?=
 =?us-ascii?Q?sChpILJm3PZpOdEcuToiEx4e4fAQUGZ8cHhBZ2Mny7XZiCB8FrxDXqUUJdtE?=
 =?us-ascii?Q?xmDqtPNe+l0B/bt5Na2eAT9TuHEWJ9Qehel5XuhNCw65dro+xBPg4rANh9vU?=
 =?us-ascii?Q?p8HBjU+ciorskyOWGGPUDLYfTOjz5KYYu/RKFi2O1OWveCMr7T1jMeLbE0hm?=
 =?us-ascii?Q?SqQCeSIB60yHhJZ9Go4lkFWHonBoXCjbpBOpD4cmlJHscZAWxTZEvq2y+Q06?=
 =?us-ascii?Q?8KkE1Ek06Y2vZ8nKCY/smz5FkhAniQ/7WYzHZIYbvaPLpDLWr4gJ9QA26K4H?=
 =?us-ascii?Q?AYeEZmrpFwXB4IyPmaFKpimRU/aOlzjuP7beGptq7br+gN/f8CzeUlUK+/aC?=
 =?us-ascii?Q?QTQz8ImAmV2Wz0nrJ/bZxmLV8JPrwh3Y/97pc2JXesDrveLM30ps/gq56wiW?=
 =?us-ascii?Q?zQqCuqpKI3a3W+VYUSixSFVn2bHxZfy2OW5r0cwGyaZB1wHMxKzy0rf5oGpB?=
 =?us-ascii?Q?G7Ie9zCzq4iJ841wTyiOxZmwYTQ6dKSa7KErsWR3sxK59kFIag2GQKXm8u1R?=
 =?us-ascii?Q?lFK5DiiAtJR7cD4CQMgRd3t/nAnlcoz/mnxvlMYTNxUHW23NuXlULMP/Ps8L?=
 =?us-ascii?Q?I3b6WvOQoEwYLh8T8HhaVOvDEjuR8IZICxy6Up6/vuCWD++5Y/n/CjyDedtj?=
 =?us-ascii?Q?YayHdzX0K/Cbo3OV2n60j9iS3k4OKH/R5W29BFaEH+g3NdzLRHjSqbchSXER?=
 =?us-ascii?Q?3oTPx7clSG63Pqqt3v7pj4ipbVskw+P2KZ+eX0DYPBh59L/Os41gDFNBJ2SP?=
 =?us-ascii?Q?PNnsliaIzRbY/7zwhaupoiMOwi6MUEvguSQyNLBQ3evY6j1ilVm8umha0ZLn?=
 =?us-ascii?Q?tc4U+ja6EMpciajPeMuJqIapdZLVRcqCPWNg4AKgv1tvAfBFniMtwE9dcmnm?=
 =?us-ascii?Q?ClmUxstBsiTIfotIR6uk8iO+NPm1YXyFUnm8pC4uFbK7sCVxnYvYjfoSbkJt?=
 =?us-ascii?Q?SR8/KLBvnB27CIrocF+mhvXww415vP25m8CgWDWunWZ0aAT9UuVvtYVpeBGs?=
 =?us-ascii?Q?cOakVQb5G9GAEoCRgPLZBgdzvkj6KKegPP0r6QU3Psga1+AyTuqppAsCK2aj?=
 =?us-ascii?Q?jmt0XQXtZ8SRozMDYcZl57y1SZ8G6SAtQMjerU3mmpWGT5pgpQWNTLj/gwea?=
 =?us-ascii?Q?YtsDUKbc5KpMKHYba289UGFPcqT4zA77/TKEy7O2EZgHj16fzRhQwuWgnM6N?=
 =?us-ascii?Q?rp9yBCbKMo561E9f3nM3ntsK4akw2LZJgBsX6YGp5n/l0I21BVILJ8fzifjI?=
 =?us-ascii?Q?jNTFYjf6fVNX/lOFwaIMEgYj7/Q+M1cqf32Qjat3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d0412bf6-38e7-4325-b04e-08dc7fb5b768
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8393.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 08:02:42.3961
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dNwnvdGdzzQlxrtLP0BDgZvEdg0gfvFGbMMRSnEEpOKnUDXiG9DTq7zLOM3hS9rogt7SuEXbikbB2f9sh755GQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8192
X-OriginatorOrg: intel.com

On Tue, May 28, 2024 at 12:26:43PM -0700, Paul E. McKenney wrote:
> On Mon, May 27, 2024 at 01:25:58PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2024.05.18a
> > head:   0e3eb8082184e066eb389f5e6f9c7b8c2d452d66
> > commit: c48887df74a95090e633a29ffbcef00b71cdab66 [44/51] rcu-tasks: Remove open-coded one-byte cmpxchg() emulation
> > config: um-allyesconfig (https://download.01.org/0day-ci/archive/20240527/202405271352.XYjxKyUi-lkp@intel.com/config)
> > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240527/202405271352.XYjxKyUi-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202405271352.XYjxKyUi-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    /usr/bin/ld: kernel/rcu/update.o: in function `rcu_trc_cmpxchg_need_qs':
> > >> update.c:(.text+0x27d5): undefined reference to `cmpxchg_emu_u8'
> >    /usr/bin/ld: kernel/rcu/update.o: in function `trc_read_check_handler':
> >    update.c:(.text+0x2839): undefined reference to `cmpxchg_emu_u8'
> > >> /usr/bin/ld: update.c:(.text+0x2882): undefined reference to `cmpxchg_emu_u8'
> >    /usr/bin/ld: kernel/rcu/update.o: in function `trc_inspect_reader':
> >    update.c:(.text+0x52ce): undefined reference to `cmpxchg_emu_u8'
> >    /usr/bin/ld: update.c:(.text+0x5330): undefined reference to `cmpxchg_emu_u8'
> >    /usr/bin/ld: kernel/rcu/update.o:update.c:(.text+0x5933): more undefined references to `cmpxchg_emu_u8' follow
> > >> collect2: error: ld returned 1 exit status
> 
> Good catch!!!
> 
> Does the patch below clear this up?

The patch below will select ARCH_NEED_CMPXCHG_1_EMU by default on um
arch, so that cmpxchg-emu.o can be built, and it fixes the link error
for me.

Tested-by: Yujie Liu <yujie.liu@intel.com>

> 
> 							Thanx, Paul
> 
> ------------------------------------------------------------------------
> 
> commit 47450c70303a11da1bd650403844ad9e688f05a4
> Author: Paul E. McKenney <paulmck@kernel.org>
> Date:   Tue May 28 12:15:06 2024 -0700
> 
>     um: Emulate one-byte cmpxchg
>     
>     Use the new cmpxchg_emu_u8() to emulate one-byte cmpxchg() on um.
>     
>     Reported-by: kernel test robot <lkp@intel.com>
>     Closes: https://lore.kernel.org/all/202405271352.XYjxKyUi-lkp@intel.com/
>     Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>     Cc: Richard Weinberger <richard@nod.at>
>     Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>     Cc: Johannes Berg <johannes@sipsolutions.net>
>     Cc: <linux-um@lists.infradead.org>
> 
> diff --git a/arch/um/Kconfig b/arch/um/Kconfig
> index 93a5a8999b07e..5fc55e1d71122 100644
> --- a/arch/um/Kconfig
> +++ b/arch/um/Kconfig
> @@ -11,6 +11,7 @@ config UML
>  	select ARCH_HAS_KCOV
>  	select ARCH_HAS_STRNCPY_FROM_USER
>  	select ARCH_HAS_STRNLEN_USER
> +	select ARCH_NEED_CMPXCHG_1_EMU
>  	select ARCH_NO_PREEMPT
>  	select HAVE_ARCH_AUDITSYSCALL
>  	select HAVE_ARCH_KASAN if X86_64
>