Received-SPF: pass (google.com: domain of linux-kernel+bounces-193703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Thomas Gleixner <tglx@linutronix.de>
To: Jinjie Ruan <ruanjinjie@huawei.com>, linux-kernel@vger.kernel.org
Cc: ruanjinjie@huawei.com
Subject: Re: [PATCH] genirq/debugfs: Print irqdomain flags as human-readable
 strings
In-Reply-To: <20240528090917.3624463-1-ruanjinjie@huawei.com>
References: <20240528090917.3624463-1-ruanjinjie@huawei.com>
Date: Wed, 29 May 2024 10:10:25 +0200
Message-ID: <875xux9gy6.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Tue, May 28 2024 at 09:09, Jinjie Ruan wrote:
> This patch improves the readability of irqdomain debugging information in

git grep 'This patch' Documentation/process/

> debugfs by printing the flags field of domain files as human-readable
> strings instead of a raw bitmask, which aligned with the existing style
> used for irqchip flags in the irq debug files.
>  
> +struct irq_bit_descr {
> +	unsigned int	mask;
> +	char		*name;
> +};
> +
> +#define BIT_MASK_DESCR(m)	{ .mask = m, .name = #m }
> +
> +static inline void irq_debug_show_bits(struct seq_file *m, int ind,
> +				       unsigned int state,
> +				       const struct irq_bit_descr *sd, int size)
> +{
> +	int i;
> +
> +	for (i = 0; i < size; i++, sd++) {
> +		if (state & sd->mask)
> +			seq_printf(m, "%*s%s\n", ind + 12, "", sd->name);
> +	}
> +}

There is no point to inline this. Just keep it in debugfs.c and remove
the static.

Thanks,

        tglx