Received-SPF: pass (google.com: domain of linux-kernel+bounces-193700-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <73d7ba0e54a93696aa2c8cab3e6599038bddf533.camel@gmail.com>
Subject: Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>, Jonathan
 Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Nuno =?ISO-8859-1?Q?S=E1?=
 <nuno.sa@analog.com>, Dragos Bogdan <dragos.bogdan@analog.com>, Anshul
 Dalal <anshulusr@gmail.com>, Andrea Collamati <andrea.collamati@gmail.com>,
  linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 29 May 2024 10:09:28 +0200
In-Reply-To: <81ec1d1a-d8de-47e4-a5d4-eeaaf1e806a2@app.fastmail.com>
References: <20240528121304.3695252-1-arnd@kernel.org>
	 <539a815398a3c991c1bc1a53967fbcba282dfe3b.camel@gmail.com>
	 <81ec1d1a-d8de-47e4-a5d4-eeaaf1e806a2@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-05-29 at 09:23 +0200, Arnd Bergmann wrote:
> On Wed, May 29, 2024, at 09:20, Nuno S=C3=A1 wrote:
> > On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >=20
> > > Build testing without SPI results in a warning:
> > >=20
> > > WARNING: unmet direct dependencies detected for REGMAP_SPI
> > > =C2=A0 Depends on [n]: SPI [=3Dn]
> > > =C2=A0 Selected by [m]:
> > > =C2=A0 - AD9739A [=3Dm] && IIO [=3Dm] && (SPI [=3Dn] || COMPILE_TEST =
[=3Dy])
> > >=20
> > > There is no need for this particular COMPILE_TEST option, as allmodco=
nfig
> > > and randconfig testing can just assume that SPI is enabled separately=
.
> > >=20
> > > Drop it to avoid the warning.
> > >=20
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> >=20
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> >=20
> > Only for my understanding. When does COMPILE_TEST makes sense to add?
>=20
> The most common use is to enable building a driver
> that is platform specific on x86 allmodconfig
> or on randconfig, e.g.
>=20
> config LPC18XX_DAC
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tristate "NXP LPC18xx DAC driv=
er"
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on ARCH_LPC18XX || COM=
PILE_TEST
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on HAS_IOMEM
>=20
> Since ARCH_LPC18XX is only visible on arch/arm, the
> driver would never be build tested on anything else
> without the ||COMPILE_TEST.

Makes sense... Thanks!

- Nuno S=C3=A1