Received-SPF: pass (google.com: domain of linux-kernel+bounces-193752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Subject: Re: [PATCH MANUALSEL 4.19 1/2] KVM: x86: Handle SRCU initialization
 failure during page track init
To: Sasha Levin <sashal@kernel.org>
CC: Paolo Bonzini <pbonzini@redhat.com>, <linux-kernel@vger.kernel.org>,
	<stable@vger.kernel.org>, Haimin Zhang <tcs_kernel@tencent.com>, TCS Robot
	<tcs_robot@tencent.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
	<bp@alien8.de>, <x86@kernel.org>, <kvm@vger.kernel.org>
References: <20211006111259.264427-1-sashal@kernel.org>
 <0fd9f7e5-697f-6ad0-b1e3-40bd48a8efae@redhat.com>
From: Zenghui Yu <yuzenghui@huawei.com>
Message-ID: <9acccdfe-b7d8-b59d-7b00-d5a266b84d36@huawei.com>
Date: Wed, 29 May 2024 16:29:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <0fd9f7e5-697f-6ad0-b1e3-40bd48a8efae@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 2021/10/6 19:23, Paolo Bonzini wrote:
> On 06/10/21 13:12, Sasha Levin wrote:
> > From: Haimin Zhang <tcs_kernel@tencent.com>
> >
> > [ Upstream commit eb7511bf9182292ef1df1082d23039e856d1ddfb ]
> >
> > Check the return of init_srcu_struct(), which can fail due to OOM, when
> > initializing the page track mechanism.  Lack of checking leads to a NULL
> > pointer deref found by a modified syzkaller.
> >
> > Reported-by: TCS Robot <tcs_robot@tencent.com>
> > Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
> > Message-Id: <1630636626-12262-1-git-send-email-tcs_kernel@tencent.com>
> > [Move the call towards the beginning of kvm_arch_init_vm. - Paolo]
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Sasha, will this patch be applied for 4.19?

The same question for the 5.4 backport [*]. It looks like both of them
are missed for unknown reasons.

[*] https://lore.kernel.org/stable/20211006111250.264294-1-sashal@kernel.org