Received-SPF: pass (google.com: domain of linux-kernel+bounces-193751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240528203030.10839-1-aleksandr.mikhalitsyn@canonical.com> <20240529-orchester-abklatsch-2d29bd940e89@brauner>
In-Reply-To: <20240529-orchester-abklatsch-2d29bd940e89@brauner>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 29 May 2024 10:29:24 +0200
Message-ID: <CANn89iLOqXZO_nD0FBUvJypgTA6NTL2dKvXYDxpMuZReYZXFDQ@mail.gmail.com>
Subject: Re: [PATCH net] ipv4: correctly iterate over the target netns in inet_dump_ifaddr()
To: Christian Brauner <brauner@kernel.org>
Cc: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>, kuba@kernel.org, 
	dsahern@kernel.org, pabeni@redhat.com, stgraber@stgraber.org, 
	davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 29, 2024 at 9:49=E2=80=AFAM Christian Brauner <brauner@kernel.o=
rg> wrote:
>
> On Tue, May 28, 2024 at 10:30:30PM +0200, Alexander Mikhalitsyn wrote:
> > A recent change to inet_dump_ifaddr had the function incorrectly iterat=
e
> > over net rather than tgt_net, resulting in the data coming for the
> > incorrect network namespace.
> >
> > Fixes: cdb2f80f1c10 ("inet: use xa_array iterator to implement inet_dum=
p_ifaddr()")
> > Reported-by: St=C3=A9phane Graber <stgraber@stgraber.org>
> > Closes: https://github.com/lxc/incus/issues/892
> > Bisected-by: St=C3=A9phane Graber <stgraber@stgraber.org>
> > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.c=
om>
> > Tested-by: St=C3=A9phane Graber <stgraber@stgraber.org>
> > ---
>
> Acked-by: Christian Brauner <brauner@kernel.org>

Thanks a lot for the bisection and the fix !

Reviewed-by: Eric Dumazet <edumazet@google.com>