From: Frank Seidel <frank@f-seidel.de>
To: Rabin Vincent <rabin@rab.in>
Subject: Re: [PATCH] Remove unneeded code in sys_getpriority
Date: Sun, 3 Feb 2008 10:54:45 +0100
User-Agent: KMail/1.9.5
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
References: <20080203030429.GB7459@ubuntu>
In-Reply-To: <20080203030429.GB7459@ubuntu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802031054.45604.frank@f-seidel.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 696
Lines: 19

On Sunday 03 February 2008 04:04, Rabin Vincent wrote:
> This check is not required because the condition is always true.
> ...
> -				if (niceval > retval)
> -					retval = niceval;
> +				retval = 20 - task_nice(p);

Thats surely correct, but on the other hand currently those
case blocks are quite independet of their possition/could easily
be rearranged now .. or think of another case is put ahead.
Then this could mess up things.

Thanks,
Frank
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/