Received-SPF: pass (google.com: domain of linux-kernel+bounces-193725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Michael Ellerman <mpe@ellerman.id.au>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] selftests/openat2: Fix build warnings on ppc64
In-Reply-To: <94964224-1796-4610-a42d-3aacb4d47341@collabora.com>
References: <20240521030325.58095-1-mpe@ellerman.id.au>
 <94964224-1796-4610-a42d-3aacb4d47341@collabora.com>
Date: Wed, 29 May 2024 18:23:13 +1000
Message-ID: <87bk4p3u32.fsf@mail.lhotse>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Muhammad Usama Anjum <usama.anjum@collabora.com> writes:
> I was looking at if we can add this flag for ppc64 for all selftests
> somewhere. But there isn't any suitable place other than in KHDR_INCLUDES.
> But there is a series already trying to add _GNU_SOURCE to it.

IMHO adding other flags to KHDR_INCLUDES is not the right solution, it
conflates unrelated things. Some tests may want the kernel headers but
not _GNU_SOURCE, or vice versa.

Adding a separate define for "standard kselftest flags" would be
preferable, and then something like __SANE_USERSPACE_TYPES__ would make
sense being added to it.

> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

Thanks.

cheers

> On 5/20/24 8:03 PM, Michael Ellerman wrote:
>> Fix warnings like:
>>=20
>>   openat2_test.c: In function =E2=80=98test_openat2_flags=E2=80=99:
>>   openat2_test.c:303:73: warning: format =E2=80=98%llX=E2=80=99 expects =
argument of type
>>   =E2=80=98long long unsigned int=E2=80=99, but argument 5 has type =E2=
=80=98__u64=E2=80=99 {aka =E2=80=98long
>>   unsigned int=E2=80=99} [-Wformat=3D]
>>=20
>> By switching to unsigned long long for u64 for ppc64 builds.
>>=20
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> ---
>>  tools/testing/selftests/openat2/openat2_test.c | 1 +
>>  1 file changed, 1 insertion(+)
>>=20
>> diff --git a/tools/testing/selftests/openat2/openat2_test.c b/tools/test=
ing/selftests/openat2/openat2_test.c
>> index 9024754530b2..5790ab446527 100644
>> --- a/tools/testing/selftests/openat2/openat2_test.c
>> +++ b/tools/testing/selftests/openat2/openat2_test.c
>> @@ -5,6 +5,7 @@
>>   */
>>=20=20
>>  #define _GNU_SOURCE
>> +#define __SANE_USERSPACE_TYPES__ // Use ll64
>>  #include <fcntl.h>
>>  #include <sched.h>
>>  #include <sys/stat.h>
>
> --=20
> BR,
> Muhammad Usama Anjum