Received-SPF: pass (google.com: domain of linux-kernel+bounces-193811-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <58fa929b-1713-472e-953f-7944be428049@nvidia.com>
Date: Wed, 29 May 2024 09:59:34 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5.15 00/23] 5.15.160-rc1 review
To: NeilBrown <neilb@suse.de>, Chuck Lever III <chuck.lever@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
 linux-stable <stable@vger.kernel.org>,
 "patches@lists.linux.dev" <patches@lists.linux.dev>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 Linus Torvalds <torvalds@linux-foundation.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, "shuah@kernel.org" <shuah@kernel.org>,
 "patches@kernelci.org" <patches@kernelci.org>,
 "lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
 "pavel@denx.de" <pavel@denx.de>, "f.fainelli@gmail.com"
 <f.fainelli@gmail.com>,
 "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
 "srw@sladewatkins.net" <srw@sladewatkins.net>,
 "rwarsow@gmx.de" <rwarsow@gmx.de>, "conor@kernel.org" <conor@kernel.org>,
 "allen.lkml@gmail.com" <allen.lkml@gmail.com>,
 "broonie@kernel.org" <broonie@kernel.org>,
 "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
References: <> <0377C58A-6E28-4007-9C90-273DE234BC44@oracle.com>
 <171693366194.27191.14418409153038406865@noble.neil.brown.name>
 <171693973585.27191.10038342787850677423@noble.neil.brown.name>
From: Jon Hunter <jonathanh@nvidia.com>
Content-Language: en-US
In-Reply-To: <171693973585.27191.10038342787850677423@noble.neil.brown.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YUN3ZFRWRDlNMWRzK1YyMG5KbWk4ektnRjRKZVloVXpyN1o0VW84TEdJQXpH?=
 =?utf-8?B?RDhEY0YwNHMvWDNUMmpiakNCKzlwcFJWZFdxbzhMdmtJWW1zOHR2SWZ3eGNm?=
 =?utf-8?B?N2FGWnBzT1pkQTl4ell5d2dZVDlnenY0dnJrZFBHdStJUm55b29KS0tkclBO?=
 =?utf-8?B?L3F2TVVBS2ZBZ2RTbno3MHg2WkhtcXVIeUQyaVY5ZGh1Sm52ckdmVXNCQ1Bl?=
 =?utf-8?B?c0JValNuVGMyL0VOcm1TRStKcGxwbHVVeE0rRDFVTVZybFZEOFJGYmF1MVoy?=
 =?utf-8?B?ZkZmQVNmTiszbXRCV0M2K2ticlZLVlVIQWxOWFJlTXZYRXlqQnVKckc1M1hs?=
 =?utf-8?B?OUlSYkozQVdtMUR6N2tKODFPdkphNjlEaGthL0hkSkNRL050VU1kSHdHZnk0?=
 =?utf-8?B?clM3b0pCTXFrdW4zeTBjSmcvQ0k3dlpENjNiQXo4WEVGN0l0MkRiQkUybG9Y?=
 =?utf-8?B?eFhyL2ZFU1pYdlI5RG9RL0g5eTZTeFRRRE94MWNQVGc3SVMwYWRsT1BZdXBY?=
 =?utf-8?B?ZkRBTTB6dS9CcWpiYk9uQ3l3QVo3TW54VmZWbVk2RWlsVTYvZXJ6SjRvVEhP?=
 =?utf-8?B?MDBlNDVkcS9EMnhSdVRYWUZ5KzZZd3lzdVVUTWRUaVN6Z3BEU3UrdGFsODNU?=
 =?utf-8?B?SElUSEhoaHVabGtDbDA0L0pFb1hyVk5wTEk2bHZRZ0lNOGlubzFualp6LzM3?=
 =?utf-8?B?WGYvT0ZsRnVHS3YvWmx5K01wQ1AwSEpCbjZ4cFNENmVKNkYvZkFOamdjTUhm?=
 =?utf-8?B?MkJvbElNRUxOR0RXM1V1cS9lT20xampvVmNEdnhvUm54bUZkbnhESHFsaHg4?=
 =?utf-8?B?bnF6a21xNC9uN1pkSUgwRWRxSm80MTlkUmR1VXJxbUN6eHB1SnRnZFZUbnRj?=
 =?utf-8?B?T2NDT1lIL1FFZVQ2ZFhMR1V1QnRjLzNFb29PM0E2RVMyVUVkOHNDSmx0ZEJa?=
 =?utf-8?B?UTF2Zzc5MUtaSGR6OWNOOXdDTGUwMzFOaXRHQzZPM3E3dUFObDYxczB5WnRK?=
 =?utf-8?B?NlNLcG41ZnBvRGpPY2ltb0xDbXVwS0lWR0o2RG1ZYjFPRFZvR1ZPMlRLdWw2?=
 =?utf-8?B?QjB6SEl3K2xRUUEwTWhVQU1aNkVmL3RTNDJkU1hhMUhqTXJnSnNhdStBVjVy?=
 =?utf-8?B?Y3luK1lwOGpJa3piNTY1ajRVekUreUUzZnVKcWlaN0xiWWhaMTlUQnRIcEk3?=
 =?utf-8?B?UTU4NFBkZU4zVEdLMWhWMHorMmlob1pWZFY5RUgwdmtWQ204Wkx1Qm5GQzVm?=
 =?utf-8?B?QjZhNk9wVVViNk0wOTZlQU4wazYvYXpaYUx2RTl6SnFYaXVJZGRFdjRackNW?=
 =?utf-8?B?UnkrUlpWeVEzbEdraFhXSDVkZk1kVmovQ3o1UzJUUVJDZG4vUEN1V1dFYkJI?=
 =?utf-8?B?MngwNTZYWjFOUXJTL3UvNjRtSENFMUYyQ0tFN2IxbGxVQnhHQTV0MGlRWk9S?=
 =?utf-8?B?ZDVnS2NDaDczWTMxb2ExZDIyMjhWUVVEYlFiVWZsMTBFaVE5NXErVFBmSkFK?=
 =?utf-8?B?bDFQOFp6aG5UOUMwUmlpTmE4UmZQbWNvN29xWXUwOFhXcXBvREJRRE52ZU9W?=
 =?utf-8?B?bzhLZ3VrSmFtTXJ0WVk3YjFNMk56Qmo0VUc2V3ROQzJTVEIxMTdPeHRFQ1Na?=
 =?utf-8?B?amdlY0x3RnQ5aHNSS1RseHVrdS9NM2hwamtlLzIyZWd3bllRKzBiV1NTenlK?=
 =?utf-8?B?NFhCb1Qrd1pRSEkrcnVXUWRSb0JhN00vSHY4QWRkUDYva1Bnd09sV01POGd1?=
 =?utf-8?B?MW9CclJaU0xiSmtyRHpybHhqZlNCMFNuQ0J0UVY2bFpPcHE1MWNJNDFySG5i?=
 =?utf-8?B?WE80Q1J1NjZ6MlJmTGJ3TXFXcmU4b2N1Y0xOKzBxdTV0R2JkOTB4dnNrZ3A0?=
 =?utf-8?B?ak5ybi9jYXRQTnJuSEVLclBmZnVta1ZVQ3NxaU1tSktHU2ExZjBUcXBqdEVZ?=
 =?utf-8?B?NXhLWEdIUFBOaVp4VFhmREJJY1d2VGJFUWpSV0pJMVI0aWZFZENLWXNITjYz?=
 =?utf-8?B?c2NaL05Sb3I3ZlVYbHhWYjlqZGdQMWQxM1l3MHplTWlndzhobmpMQ294OGdh?=
 =?utf-8?B?bDZFZVhuS2lKTWRSaTVBYmNZNTMvcXgxV2FaVzhMNitNckZyRDM2VlZ0T2ox?=
 =?utf-8?B?Y2t2SzNJWHptbXVYNW91cWtNYkVCNnVLbjFLSTh2V1gxWDZJQXJEbmZvQW8r?=
 =?utf-8?B?VmdUdURFM2Jtb3czem5yWjlWMUl5elIrR2EwVXZiZk9YdW40dHdYQ2lyQmhj?=
 =?utf-8?B?SllxdEw2ejBCVlEzdEpWMGltNzNnPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5c2728e-688b-4820-b37b-08dc7fbdae35
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 08:59:43.0603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t/KiCuF70CkCZz/BS8MbxgJECqdcMxrZZkuRCNEWMXY5y7gPgEol2BpBqZnGDr/sJiH1iJAvBfttodA3rkY+KQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8769


On 29/05/2024 00:42, NeilBrown wrote:
> On Wed, 29 May 2024, NeilBrown wrote:
>>
>> We probably just need to add "| TASK_FREEZABLE" in one or two places.
>> I'll post a patch for testing in a little while.
> 
> There is no TASK_FREEZABLE before v6.1.
> This isn't due to a missed backport. It is simply because of differences
> in the freezer in older kernels.
> 
> Please test this patch.
> 
> Thanks,
> NeilBrown
> 
>  From 416bd6ae9a598e64931d34b76aa58f39b11841cd Mon Sep 17 00:00:00 2001
> From: NeilBrown <neilb@suse.de>
> Date: Wed, 29 May 2024 09:38:22 +1000
> Subject: [PATCH] sunrpc: exclude from freezer when waiting for requests:
> 
> Prior to v6.1, the freezer will only wake a kernel thread from an
> uninterruptible sleep.  Since we changed svc_get_next_xprt() to use and
> IDLE sleep the freezer cannot wake it.  we need to tell the freezer to
> ignore it instead.
> 
> Fixes: 9b8a8e5e8129 ("nfsd: don't allow nfsd threads to be signalled.")
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>   net/sunrpc/svc_xprt.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index b19592673eef..12e9293bd12b 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -764,10 +764,12 @@ static struct svc_xprt *svc_get_next_xprt(struct svc_rqst *rqstp, long timeout)
>   	clear_bit(RQ_BUSY, &rqstp->rq_flags);
>   	smp_mb__after_atomic();
>   
> +	freezer_do_not_count();
>   	if (likely(rqst_should_sleep(rqstp)))
>   		time_left = schedule_timeout(timeout);
>   	else
>   		__set_current_state(TASK_RUNNING);
> +	freezer_count();
>   
>   	try_to_freeze();
>   


Thanks. I gave this a try on top of v5.15.160-rc1, but I am still seeing
the following and the board hangs ...

Freezing of tasks failed after 20.004 seconds (1 tasks refusing to freeze, wq_busy=0):

So unfortunately this does not fix it :-(

Jon

-- 
nvpublic