Received-SPF: pass (google.com: domain of linux-kernel+bounces-193812-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <eedb1df0-e745-4b48-9261-faa0ff320ee9@intel.com>
Date: Wed, 29 May 2024 17:04:28 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 05/20] iommu: Add iommu_paging_domain_alloc() interface
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
CC: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, "Kalle
 Valo" <kvalo@kernel.org>, Bjorn Andersson <andersson@kernel.org>, "Mathieu
 Poirier" <mathieu.poirier@linaro.org>, Alex Williamson
	<alex.williamson@redhat.com>, <mst@redhat.com>, Jason Wang
	<jasowang@redhat.com>, Thierry Reding <thierry.reding@gmail.com>, "Jonathan
 Hunter" <jonathanh@nvidia.com>, Mikko Perttunen <mperttunen@nvidia.com>,
	<iommu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>
References: <20240529053250.91284-1-baolu.lu@linux.intel.com>
 <20240529053250.91284-6-baolu.lu@linux.intel.com>
Content-Language: en-US
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20240529053250.91284-6-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVg3M0p0akd1Tnl3SzRJQUhqRm9BMVNuai9sRjR6NUZtVW9oZ1V3Qk1kU3NP?=
 =?utf-8?B?NVlJd25idkFnQ0pzYml0SDlHVVVOaUI2dUM5SGx1d25aeTRLbkJ2cksyand0?=
 =?utf-8?B?N3RtWjk1OXpHWDNDK0RWREtQa1JOZCs3WEhWMkVxZUlkU21UeTNhNHlmWjhO?=
 =?utf-8?B?TjFBQ2s2OHl5UlBFU1EwMldZL0hUQ1h1MVV1V3dzVmdWZ1dPbUtZbC8rakxl?=
 =?utf-8?B?VlBJMHBoMjV3WTQ4V2FabUlkeS9rNUdWS3dMZHZMZTQrOThKdldzRHMzUE9w?=
 =?utf-8?B?NTIvK2FwWTY1c2Nod3VrTXRDVlFUSGdPU29ZVHF2WnByN3RGMi9ZUjF2cGFY?=
 =?utf-8?B?M3hOM1phR09yVHdZKzFFQXo0NXJwV0Yvc2lzZGxDYTFBS1llSkhIZCtSOUZq?=
 =?utf-8?B?M0R5ZitLS0FhWk50UUNHZFIrdWtwQldhT2F2bUszMThvNkZCczlWRFZEOWNZ?=
 =?utf-8?B?OEJEOFVqU3hPSXJ6ZzRBWFV3Q2YyZHlFVTI0OWNyWklhcjFrZ0Frci8zWWZR?=
 =?utf-8?B?M1RFUzhJYmh0eTRwMExSdXZzc3JGMGNneEY1YzhWZFdkTlhsSUNDUGVuZXJm?=
 =?utf-8?B?N3NwZDdqYitmMmJBTmM0d0tjZ1ZabWtxRkpQc0w2S2FsV0EyMTMzdVNZeHVp?=
 =?utf-8?B?UmhrZGo0bExWR050S2traER3bU1sVDRJRmEwN0NMc0JMOUVSQjJQU2x1QXlz?=
 =?utf-8?B?bDBtVW00MERqOTlrY1dwUzE2S1ZMNjFNWXVEOUo0U1NOZHdVL25pTm9PSkpp?=
 =?utf-8?B?L2NzZWVtbW1QbUU3ZEU3aFVzUlhmclZCcCtLd3BCR0xBY3JiNHFET2pMc1VP?=
 =?utf-8?B?NGdnM0w5b3ZEbjFaeXMzelhPQUxFc08rcWcyOWc3NmVxbFM5dVdZbkkwc2o3?=
 =?utf-8?B?Y3hEZWQrQ1JNZWtrc0Q2YTZ1T3ZTZjZ3MHF1NlRxbjRxTThWaTFobGkzcHRN?=
 =?utf-8?B?bk9XbTFVK0FlamNJdDg5ZkNwUFlzeU9TYzJUaklETkkvUWFsVHZBaVIzVU4r?=
 =?utf-8?B?eVVWSW9WSThqenQwOFRyZkxZRHlpRkZ1QkM2NGJyRVJwczVFK3BBQWdGMEQv?=
 =?utf-8?B?OXpMT2RFTDl4OTFoSWNZODdMcjF4YjNkVFZ0Z0lFOW5YcVJuUjIyUkFVb09I?=
 =?utf-8?B?TzF0SFNTd0VUTmhvNTlyYVBnWE1Xdmx4QmZnWThGZXhyeHNxSS9OQWV4eHRD?=
 =?utf-8?B?cTdleUlCUkdGcHc1Ykt5YUx4cFI3ZEoxWXVlSTVLSnY3SXpMWGpjTysrSzM5?=
 =?utf-8?B?bTY2bFA2S1ZqbjYyZnRGc1A3di9VRWxRQkVRQW94MDZFMXgya2dUdjF4Ny92?=
 =?utf-8?B?ZWgrT2NIcU1jOXJCTTV5UTk5S2dzOVJOMVF0YTI5QWJ1b2VjL0FINi9DS1Ax?=
 =?utf-8?B?aWwxK1JvREsyOXdKV3Z6cGtrUEVYcFZiYncrM0phcENsVXhjWVB5THF0aHdT?=
 =?utf-8?B?b09wTDJRQVROdFZGQ1lFcW1BQTZhVDZSWHM0cVBhSzhMZjA5N3BNUGcyUjYy?=
 =?utf-8?B?WGNCblF4a0lMUTlwbFNZeVpaN1dCQzhhY1RHamVzZk5ETkpWUkc1Smg1SFhk?=
 =?utf-8?B?ZVRXRXZoWk1RWGJHd0R0NFdoMXg0YURwNzdjckF4Vnk0RVNCVmxKZk54MmVC?=
 =?utf-8?B?NC93bFdFZWpqN3QxMldqbzRNMTR2S2tGS1pzeDJUeEtFUGd2UmpQZllnVzFq?=
 =?utf-8?B?cmFnUzZuUnNrei8zTExxenVzUjIrbDA1aDc3V1hCMHk4S1pxdjRVcnlQVnkr?=
 =?utf-8?B?WUlUdGs3dG1QZmlTN1NKS2Z2T1VYNDVFYmx3SFpCaHh6VkVGeUN1dUY3enBI?=
 =?utf-8?B?OHBnSVY2Nkd5dG1tQU5pd3Q0WG9iSWZBSGtIQXlYYW1LMW9GaEdGTVZDRC9o?=
 =?utf-8?B?YWRLeEVmeTk2OHg4VWJOVVNNbHpQdXdOL1l1OUY3K3ZiOWtKMXpsdzlBenRa?=
 =?utf-8?B?aE1JMXg1cU94aFNrcWZGTENrcm1zZzd0bTd2aUNOY2dOWGVLOWoxWE5YTTZt?=
 =?utf-8?B?Qng2ZkdRa3RMZlYyY0xJUGI1OU1zVlQ5N3FoM2pTRnRwdU5YTEpNUFhJbUhX?=
 =?utf-8?B?aE5iNmJtZ2FYTmpsYWh1VHd5KzFMbTZhNzdvWnRzU3A0TU5iREdUL0JYTUtI?=
 =?utf-8?Q?3Le6h49ko5vVt7uDBFvV23kEb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f41e92a0-ddd1-4074-8819-08dc7fbdcdfe
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 09:00:36.2251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EHk+RUewDMYAiTILFKBdl4oOc2MvepzGdL2QKD8FvpH/zq1huFOkeMtiR4AvTXpfDjzG/AB6RSq6ZKUlzGlzHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7832
X-OriginatorOrg: intel.com

On 2024/5/29 13:32, Lu Baolu wrote:
> Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from
> bus. The iommu subsystem no longer relies on bus for operations. So the
> bus parameter in iommu_domain_alloc() is no longer relevant.
> 
> Add a new interface named iommu_paging_domain_alloc(), which explicitly
> indicates the allocation of a paging domain for DMA managed by a kernel
> driver. The new interface takes a device pointer as its parameter, that
> better aligns with the current iommu subsystem.

you may want to move this patch before patch 03/04.

> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>   include/linux/iommu.h |  6 ++++++
>   drivers/iommu/iommu.c | 20 ++++++++++++++++++++
>   2 files changed, 26 insertions(+)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 6648b2415474..16401de7802d 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -781,6 +781,7 @@ extern bool device_iommu_capable(struct device *dev, enum iommu_cap cap);
>   extern bool iommu_group_has_isolated_msi(struct iommu_group *group);
>   extern struct iommu_domain *iommu_domain_alloc(const struct bus_type *bus);
>   struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u32 flags);
> +struct iommu_domain *iommu_paging_domain_alloc(struct device *dev);
>   extern void iommu_domain_free(struct iommu_domain *domain);
>   extern int iommu_attach_device(struct iommu_domain *domain,
>   			       struct device *dev);
> @@ -1092,6 +1093,11 @@ static inline struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u
>   	return ERR_PTR(-ENODEV);
>   }
>   
> +static inline struct iommu_domain *iommu_paging_domain_alloc(struct device *dev)
> +{
> +	return ERR_PTR(-ENODEV);
> +}
> +
>   static inline void iommu_domain_free(struct iommu_domain *domain)
>   {
>   }
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index f1416892ef8e..7df4a021b040 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -2016,6 +2016,10 @@ static int __iommu_domain_alloc_dev(struct device *dev, void *data)
>   	return 0;
>   }
>   
> +/*
> + * The iommu ops in bus has been retired. Do not use this interface in
> + * new drivers.
> + */
>   struct iommu_domain *iommu_domain_alloc(const struct bus_type *bus)
>   {
>   	const struct iommu_ops *ops = NULL;
> @@ -2074,6 +2078,22 @@ struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u32 flags)
>   }
>   EXPORT_SYMBOL_GPL(iommu_user_domain_alloc);
>   
> +/**
> + * iommu_paging_domain_alloc() - Allocate a paging domain
> + * @dev: device for which the domain is allocated
> + *
> + * Allocate a paging domain which will be managed by a kernel driver. Return
> + * allocated domain if successful, or a ERR pointer for failure.
> + */
> +struct iommu_domain *iommu_paging_domain_alloc(struct device *dev)
> +{
> +	if (!dev_has_iommu(dev))
> +		return ERR_PTR(-ENODEV);
> +
> +	return __iommu_domain_alloc(dev_iommu_ops(dev), dev, IOMMU_DOMAIN_UNMANAGED);
> +}
> +EXPORT_SYMBOL_GPL(iommu_paging_domain_alloc);
> +
>   void iommu_domain_free(struct iommu_domain *domain)
>   {
>   	if (domain->type == IOMMU_DOMAIN_SVA)

-- 
Regards,
Yi Liu