Received-SPF: pass (google.com: domain of linux-kernel+bounces-193755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <cc553f61-e494-45c0-84e9-8a0e275ba416@nxp.com>
Date: Wed, 29 May 2024 16:32:31 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
 Andrzej Hajda <andrzej.hajda@intel.com>,
 Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Fabio Estevam <festevam@gmail.com>
Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240529065400.461633-1-alexander.stein@ew.tq-group.com>
 <091f1d5c-0bff-4dcb-b823-b82989eac628@nxp.com> <6130653.lOV4Wx5bFT@steina-w>
From: Liu Ying <victor.liu@nxp.com>
Content-Language: en-US
In-Reply-To: <6130653.lOV4Wx5bFT@steina-w>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?bHQ0MkZVS2dLMW5neERIUGI1YUxiNnhsWWVFRE9jUWl5eXBScDJBUjFHLzht?=
 =?utf-8?B?ZU1wMVUzb25qb2hKNzAyUEdldldIZGo5aVBnYU9zZXloUW16RDRCREpMaHE3?=
 =?utf-8?B?b0J4T1NVNVBPUlFpY0pDZ2JIQVlQTmpnS0paNDljUDJrOHFjd1hZV28xak1P?=
 =?utf-8?B?SVpWV09pelM3NmR3S3d0UGFuSG1KVUFrclJZdm1nejR4djBKVWQxMEU0SEdv?=
 =?utf-8?B?NG9OTXluMW1JSHc4ZzA4dFM1bU5Da3JzMzZIaWZpZTVBS0QvU3Z5ZEp1RDg2?=
 =?utf-8?B?M204UDB0SlIvRXZzSHEvOUM3OStJTmZpSVIwWjZsL0JxcWtQNENTUnk0SUZC?=
 =?utf-8?B?c3cwTDZteXU3MXdMeWI0MHNEQW51cVVpdzVLRkIrNEEyMWMrd2RibVZvK3Q3?=
 =?utf-8?B?Q3oxVlMzZ24ydm1RNTJscDU1VGRCVitQYmdhWHRaVDF1eUw5VHprOTE4QnNL?=
 =?utf-8?B?bWlySUZXSmYzaktDUzM5cE5WVUJubjhaUGlSWmFya3c2MEdEeWRYZUhFMm5M?=
 =?utf-8?B?M0RacXVXWHVwVzlqaVV0endqUHJBOWQ3Ykd6cW1NMHJzZE9mN0JpN1ppbmh4?=
 =?utf-8?B?ejUySW1FMlR4VTR2Y0ZlcFgwemlUZDZ1a2ZpWThsTVI2dEwwdmhhZ003T2V1?=
 =?utf-8?B?UGp5N1RndFliMDBJeXRXd2hOdFhzbldON1p6WHFjK1MwbDlXOVE4M3Q1Q3B4?=
 =?utf-8?B?OThObHUyYnYrYm5rUDRuTGFsRTdMeFhWWWVFMVhLbXV5MnduRlkrM2VPcElr?=
 =?utf-8?B?U3NkbkUxamRCd0JiRmV4QmRaZytLVUdLcyt2aFVvS1lCc1VtRDhmbkdlMWpw?=
 =?utf-8?B?dWhrY1dJRmRybHovMlN1Mi9QOUplUVhPUUpPYTVVM3ZKWGxob1VsR1AyR1d3?=
 =?utf-8?B?YnRxTllsVnN3YzZIVHNIS05CQWtRWkR0cS9oOWxjSWNJenFBRWVucERESTdH?=
 =?utf-8?B?c0FDd1I2NkNXZlZZRWpFaWttYmRhOHVuVVlMZFR0N3ZHeDYzdzdOWHBySUc2?=
 =?utf-8?B?NEo3SWFIRVNzNEtmT0VISWJVbDhWbEpWU0xIRjlUaTJ5ejBHNUwzTEpvK0Rt?=
 =?utf-8?B?eDVnSkFZYkdlOTUrdGREN1V3Y3BlWGVVUUtucXltcFBlTjZ0ZUlVYlExSTh1?=
 =?utf-8?B?M0xkK1Fna2VKZ0ZVV3ZKNUI4QlIrUldHcXgvRUlnb0pNWTlmTGtFT21ac2x6?=
 =?utf-8?B?K1ptNVNOT05Od2JFL2huZ3I0aFJtaURIelB4Lys1UTV2YlNEMGNUT1M2dzV6?=
 =?utf-8?B?UnF0QS9LVlZ3WW5xRm53NzNaKzRJQjVHaG1PTnRyanFtMnl1eHBXME1rL28v?=
 =?utf-8?B?NUhzZ3QrUlhGNU9GTE9veGxXQytjRHJDZm5EWDZHM2FFcDQyTDlwT1lNTGYz?=
 =?utf-8?B?QmtudjZDd0hXSjJEY3NESHVZR3czaTlIOXkvMDVZdUx4SEFUNHkyUkJmRThM?=
 =?utf-8?B?VkhVVlBjS2xKVElBTkd3ejdtVHVMUXpFVzl2eUdORGNJMUZoanR1RStwZnBw?=
 =?utf-8?B?U2x3YTcrU1ZWUDFsZG0rZHh5VnA0Vzl6WUl5RFZKNE1YZUJkNTBacGUyMjNQ?=
 =?utf-8?B?azJmdnArUVdnV1RHLzZCUXdXUTdTTXVFMkIvek5NRW9CWGd0cjVBbE1vU25l?=
 =?utf-8?B?RElnaDg2cFNyN1R2dmx3L1NyRyt2TFdWMCtaYjZmQVRtZWtabHM5S3lTUC9G?=
 =?utf-8?B?MmtSS2J5Wkd0VHdSZmFkN3ZaNnhtcm5HTXk5d3pQVUxxV1hjMFlBMk5ZQ1BR?=
 =?utf-8?B?ZGIrNWNNeFRKRktkL2duKzFzWE90WGh2VWt6K2Q3dWZrQTlEOVQ2ZjZtZ1FR?=
 =?utf-8?B?cTd0Ym1PcHBnZWxNOG5iSmtYdU5pNHJEalFoMmRCOTBCVk40UThZMGZRc0wv?=
 =?utf-8?B?dUpqSHFWOVpPYnZKcTMvd1dDcHo1aGFyT05jdUc1M01oMWI0TktMZFlTZW0w?=
 =?utf-8?B?alRETGJ4Y3FYZ0R6b3h4MUtHdFhvSzhzQmN5SzBjM0h3azNFTTRZZHgxbCtl?=
 =?utf-8?B?VlVaUlplU1V1LzFjUmswN0g3N0FoVm9rM3JSbGgzOElUMkh0RThVU1NpUmdS?=
 =?utf-8?B?V0dVVjBxMmllcjFubC8rWjRaSlB4N1d1UlFZUnNXSEpML1pPVDBIOCtTV0Zy?=
 =?utf-8?Q?xOF6z2Um9wkhGydwCkSI+N6iW?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21a0f475-ce64-454f-2f4d-08dc7fb9d6fa
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 08:32:13.5270
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hhyww07zR830reUlA4WYcs35HUaMr1eUf8vU2vIkrK6p4+TAc90rZ3i5Sdca7amkyjQiDoOR8+oA5iU3aKKSOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7538

On 05/29/2024, Alexander Stein wrote:
> Hi,
> 
> Am Mittwoch, 29. Mai 2024, 09:50:24 CEST schrieb Liu Ying:
>> On 05/29/2024, Alexander Stein wrote:
>>> Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible
>>> removed), it lines up with the other error paths in probe function.
>>
>> Why media_blk_ctrl needs 'syscon' compatible removed?
> 
> No, it does not. As media_blk_ctrl is also used as power-domain the device
> will not even be probed if media_blk_ctrl is not available.
> I just mentioned it under which conditions this error path could happen.

The error path you mentioned returns ERR_PTR(-EINVAL) which
doesn't make sense to use dev_err_probe.  ERR_PTR(-EPROBE_DEFER)
is the one in question.

> 
> Best regards,
> Alexander
> 
>> device_node_get_regmap may return error pointer other than
>> ERR_PTR(-EPROBE_DEFER), like ERR_PTR(-ENOMEM).
>>
>> struct regmap *syscon_node_to_regmap(struct device_node *np)                     
>> {                                                                                
>>         if (!of_device_is_compatible(np, "syscon"))                              
>>                 return ERR_PTR(-EINVAL);                                         
>>                                                                                  
>>         return device_node_get_regmap(np, true);                                 
>> }                                                                                
>> EXPORT_SYMBOL_GPL(syscon_node_to_regmap);
>>
>> Regard,
>> Liu Ying
>>
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>> Changes in v2:
>>> * Removed unused variable
>>> * Added missing \n at end of string
>>>
>>>  drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 9 +++------
>>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
>>> index 2347f8dd632f9..13025f47f3902 100644
>>> --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
>>> +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
>>> @@ -834,18 +834,15 @@ static int imx93_dsi_probe(struct platform_device *pdev)
>>>  	struct device *dev = &pdev->dev;
>>>  	struct device_node *np = dev->of_node;
>>>  	struct imx93_dsi *dsi;
>>> -	int ret;
>>>  
>>>  	dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
>>>  	if (!dsi)
>>>  		return -ENOMEM;
>>>  
>>>  	dsi->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,media-blk-ctrl");
>>> -	if (IS_ERR(dsi->regmap)) {
>>> -		ret = PTR_ERR(dsi->regmap);
>>> -		dev_err(dev, "failed to get block ctrl regmap: %d\n", ret);
>>> -		return ret;
>>> -	}
>>> +	if (IS_ERR(dsi->regmap))
>>> +		return dev_err_probe(dev, PTR_ERR(dsi->regmap),
>>> +				     "failed to get block ctrl regmap\n");
>>>  
>>>  	dsi->clk_pixel = devm_clk_get(dev, "pix");
>>>  	if (IS_ERR(dsi->clk_pixel))
>>
>>
> 
> 
-- 
Regards,
Liu Ying