Received-SPF: pass (google.com: domain of linux-kernel+bounces-193810-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <efd902f6-eafc-4a26-8057-bdd9d7d6e535@intel.com>
Date: Wed, 29 May 2024 17:03:26 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 00/20] iommu: Refactoring domain allocation interface
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
CC: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, "Kalle
 Valo" <kvalo@kernel.org>, Bjorn Andersson <andersson@kernel.org>, "Mathieu
 Poirier" <mathieu.poirier@linaro.org>, Alex Williamson
	<alex.williamson@redhat.com>, <mst@redhat.com>, Jason Wang
	<jasowang@redhat.com>, Thierry Reding <thierry.reding@gmail.com>, "Jonathan
 Hunter" <jonathanh@nvidia.com>, Mikko Perttunen <mperttunen@nvidia.com>,
	<iommu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>
References: <20240529053250.91284-1-baolu.lu@linux.intel.com>
Content-Language: en-US
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20240529053250.91284-1-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXlhVFVYY1VSQkNMT3dLUmY1RjYxSlp1NDRNMWJmOXVEQ2lxUkJiN3pRMkYr?=
 =?utf-8?B?M1U4RUZSV1liN1B4ZHVBUThZODdENndUY2VQL09Jb01CdGpXZU9MeEZ3L21P?=
 =?utf-8?B?bUJyQTZ6YThhQ2dJK3ZmUUh3TVRYTm9BdXRLM25kcGk0NkM5VGJ3anJBclBi?=
 =?utf-8?B?VmFOKzZZWUtLeGlXOVhkMlVEdWFQd1Z3NTVubTEvU2MwVGZtUXhPTnBNYVNP?=
 =?utf-8?B?MGtVeDdhdWdPbWtROUwrSlBMNTZTeWJXeDJDK2x4NDZYdVFwRXhxTHYxVk4v?=
 =?utf-8?B?Mnl5a2xIbXNvSWdiSEp1K3pjN1g0eEFTK2VOdFJ2Vmh3Mm1BMFQza1dxcGto?=
 =?utf-8?B?SE5MRk5BU3BabXlSbTZrNWZMdHZCenNoVWFFeW8wc0dtOEFXNnVwVnVRY3Bt?=
 =?utf-8?B?b3RRMmcwS1F2cys5elZueVBZemFJZEhjVXBmVHlLRlRDakFwRmcvNmJFVFdv?=
 =?utf-8?B?c29ud0hheUhlYllCS3c5UkMreXJuWkpBd1Y0YlRpTktlK0c1ZkFRTFBKSVRJ?=
 =?utf-8?B?WUZpREpDL0JHNWhMZlNFbjk2K2RaSk9tNG9WN1ZlZzJmaGhQM3pURUZlSXNv?=
 =?utf-8?B?NWFLdjJsK0VaV2ZRQ2NDQWFqZjBhR05qQndBU3dNcHFpeThSajlLQkt6Sk1o?=
 =?utf-8?B?Q1RlcitXOVBBZHdYOVF1dGFGcnZDVStOK3RTVnNXd2FhZnI3Z1ZiNWpUcXls?=
 =?utf-8?B?RnZlbDNteHpla1RKNXlVVlJuZFQvWndxSGhLV2N6cXBmM2JwaDcxaHVlUVlP?=
 =?utf-8?B?TVRDOVNYOU5CMmExSWY2TVErNWhjSDZKSkRwdHlnM0VmZ0FYMXdIMkJkdFUv?=
 =?utf-8?B?VmVpZFcvTWhyazNvWER4TkQ5OFZFVGJaVVUraFpmL1NTUmJQbVA0N1ZqVklS?=
 =?utf-8?B?SnJ4cjNSZEY2TGp1cEVKb2hxMnJRVGs0cW0vQkYwUmJiOTJsc0NRS0JzenpC?=
 =?utf-8?B?cHBvZU80Y2ovNExrY0x5cUFxUHJpanVtSnQ5eW9zZTlBN3FPQVBzQWFRem83?=
 =?utf-8?B?RW40TnlQcVB0TW5BREJZU2ZYL05Ld2M4WmxPVGhyY2lEU295NURHdWN1Wjht?=
 =?utf-8?B?WWp3OGhEMHVwM3hEcmJNS0d5NjRqS3VCdGl6dFluRmFGTEN5cXhXeHlKS0dk?=
 =?utf-8?B?RFlYT01FZi9OVVErWll4aGNINXlhZHh5eDJkUTMxWnJFNG1WcHFrY0lib2VI?=
 =?utf-8?B?RHJsTG5jcmhWL1RWNStkUE5pLzgvc05RWFYwU0xrSzhmc09Ua09WN21Zemla?=
 =?utf-8?B?WWRJbEtDOG4yZ01LNHZVcHpBL3RmWm9VMXlTVjlybmRnM3BNREQ0WG9XZnQ2?=
 =?utf-8?B?Qld0VWEvYTBwellNcU9ZOHhHVndFK1g3R1dKMC8wekhEeVBSdkY3dmFyaTJS?=
 =?utf-8?B?akNrR0J5SnBWNmlLM1BOL0lUa0h5SmY4V2liWlJjaFhnd0lDZysxVmlHQmI1?=
 =?utf-8?B?RFpqSk0vdUIzVUhGQVlLMjlnQXJoeTVkZXA4WDFmTnIrOUoyUVEwY2hhRnJ6?=
 =?utf-8?B?QWNuSXNoRVE1ckViVjNJbXZsRjZHVXNPNTFPckVXcXJlRkdVODI2R0lwWEsx?=
 =?utf-8?B?RHFkZkp0WWJOdHBNa1d2elNuWm9tS0lsVVFYOWNHTTV4eUtiNDJiZ0dONUUv?=
 =?utf-8?B?Q29uV1hxRkxQeGFQSGhoR1JMWlV5UlU4RGlrd2VPT3hvSERHMTVlUXc4VWdp?=
 =?utf-8?B?VlVnQjlQNmU5ZFVNR0FOeHBGUWpZek9xbnhibmRhVUpiQmdDZmN1QkVoVjVM?=
 =?utf-8?B?MkhRRXVtUng2K0Z5MXp5dWl6RjBubUMrZ1ZyZUxFNlZCbExOaVZOZFBBSTFD?=
 =?utf-8?B?Vzh4NDh5a1dlZDM0NEpVSnlQcW8ya1RUdkZ2WHZ4R00rVlUzdEZKeUdxNXZQ?=
 =?utf-8?B?WUZUYXRLZEVNZ0Fka3h0alo0c1kyNnduN3R1aTVHN2J3dHRwKzhMalJSajhL?=
 =?utf-8?B?YVQ3MEVnWUE4TVUrQVBiekxvQVZPQmlZYlArcnRaMEVTekdkU0RXRGVvS1Rz?=
 =?utf-8?B?RHgyalYwaWNCYWR1OHA4VzB5TjlYUWVZekJhZ0JDdVpjSzNOMkdaWkRDR1g4?=
 =?utf-8?B?T3hoODcrUklIeEV3OEIrbFYvK21UNXF3SU9tQnlqSlV5SGFzMWZiQWRFMXNE?=
 =?utf-8?Q?64grs+ZyIcXD4tUgk3V5nVO5i?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 56f22144-01f7-49f2-e795-08dc7fbdaa9c
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 08:59:36.9115
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8qcXY9czoezNR3rsmqNeUknSWQ6bzX6jEnn4dezAICX4QWo1EoBExEbiKesk/2I5+rjpi1H2XE76uW2L4nLXdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7832
X-OriginatorOrg: intel.com

On 2024/5/29 13:32, Lu Baolu wrote:
> The IOMMU subsystem has undergone some changes, including the removal
> of iommu_ops from the bus structure. Consequently, the existing domain
> allocation interface, which relies on a bus type argument, is no longer
> relevant:
> 
>      struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)
> 
> This series is designed to refactor the use of this interface. It
> proposes two new interfaces to replace iommu_domain_alloc():
> 
> - iommu_user_domain_alloc(): This interface is intended for allocating
>    iommu domains managed by userspace for device passthrough scenarios,
>    such as those used by iommufd, vfio, and vdpa. It clearly indicates
>    that the domain is for user-managed device DMA.

user paging domain? It looks to me user domain includes the nested domains
as well.

>    If an IOMMU driver does not implement iommu_ops->domain_alloc_user,
>    this interface will rollback to the generic paging domain allocation.
> 
> - iommu_paging_domain_alloc(): This interface is for allocating iommu
>    domains managed by kernel drivers for kernel DMA purposes. It takes a
>    device pointer as a parameter, which better reflects the current
>    design of the IOMMU subsystem.
> 
> The majority of device drivers currently using iommu_domain_alloc() do
> so to allocate a domain for a specific device and then attach that
> domain to the device. These cases can be straightforwardly migrated to
> the new interfaces.
> 
> However, there are some drivers with more complex use cases that do
> not fit neatly into this new scheme. For example:
> 
> $ git grep "= iommu_domain_alloc"
> arch/arm/mm/dma-mapping.c:      mapping->domain = iommu_domain_alloc(bus);
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c:    private->domain = iommu_domain_alloc(private->iommu_dev->bus);
> drivers/gpu/drm/tegra/drm.c:            tegra->domain = iommu_domain_alloc(&platform_bus_type);
> drivers/infiniband/hw/usnic/usnic_uiom.c:       pd->domain = domain = iommu_domain_alloc(dev->bus);
> 
> This series leave those cases unchanged and keep iommu_domain_alloc()
> for their usage. But new drivers should not use it anymore.

does it mean there is still domains allocated via iommu_domain_alloc()
on VT-d platform?

> The whole series is also available on GitHub:
> https://github.com/LuBaolu/intel-iommu/commits/iommu-domain-allocation-refactor-v1
> 
> Lu Baolu (20):
>    iommu: Add iommu_user_domain_alloc() interface
>    iommufd: Use iommu_user_domain_alloc()
>    vfio/type1: Use iommu_paging_domain_alloc()
>    vhost-vdpa: Use iommu_user_domain_alloc()
>    iommu: Add iommu_paging_domain_alloc() interface
>    drm/msm: Use iommu_paging_domain_alloc()
>    drm/nouveau/tegra: Use iommu_paging_domain_alloc()
>    gpu: host1x: Use iommu_paging_domain_alloc()
>    media: nvidia: tegra: Use iommu_paging_domain_alloc()
>    media: venus: firmware: Use iommu_paging_domain_alloc()
>    ath10k: Use iommu_paging_domain_alloc()
>    wifi: ath11k: Use iommu_paging_domain_alloc()
>    remoteproc: Use iommu_paging_domain_alloc()
>    soc/fsl/qbman: Use iommu_paging_domain_alloc()
>    iommu/vt-d: Add helper to allocate paging domain
>    iommu/vt-d: Add domain_alloc_paging support
>    iommu/vt-d: Simplify compatibility check for identity domain
>    iommu/vt-d: Enhance compatibility check for paging domain attach
>    iommu/vt-d: Remove domain_update_iommu_cap()
>    iommu/vt-d: Remove domain_update_iommu_superpage()
> 
>   include/linux/iommu.h                         |  12 +
>   drivers/gpu/drm/msm/msm_iommu.c               |   8 +-
>   .../drm/nouveau/nvkm/engine/device/tegra.c    |   4 +-
>   drivers/gpu/host1x/dev.c                      |   6 +-
>   drivers/iommu/intel/iommu.c                   | 319 ++++++++----------
>   drivers/iommu/intel/pasid.c                   |  28 +-
>   drivers/iommu/iommu.c                         |  62 ++++
>   drivers/iommu/iommufd/hw_pagetable.c          |  20 +-
>   .../media/platform/nvidia/tegra-vde/iommu.c   |   6 +-
>   drivers/media/platform/qcom/venus/firmware.c  |   6 +-
>   drivers/net/wireless/ath/ath10k/snoc.c        |   6 +-
>   drivers/net/wireless/ath/ath11k/ahb.c         |   6 +-
>   drivers/remoteproc/remoteproc_core.c          |   6 +-
>   drivers/soc/fsl/qbman/qman_portal.c           |   4 +-
>   drivers/vfio/vfio_iommu_type1.c               |   7 +-
>   drivers/vhost/vdpa.c                          |  11 +-
>   16 files changed, 253 insertions(+), 258 deletions(-)
> 

-- 
Regards,
Yi Liu