Received-SPF: pass (google.com: domain of linux-kernel+bounces-193574-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-491-g033e30d24-fm-20240520.001-g033e30d2
Precedence: bulk
MIME-Version: 1.0
Message-Id: <81ec1d1a-d8de-47e4-a5d4-eeaaf1e806a2@app.fastmail.com>
In-Reply-To: <539a815398a3c991c1bc1a53967fbcba282dfe3b.camel@gmail.com>
References: <20240528121304.3695252-1-arnd@kernel.org>
 <539a815398a3c991c1bc1a53967fbcba282dfe3b.camel@gmail.com>
Date: Wed, 29 May 2024 09:23:11 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: =?UTF-8?Q?Nuno_S=C3=A1?= <noname.nuno@gmail.com>,
 "Arnd Bergmann" <arnd@kernel.org>, "Jonathan Cameron" <jic23@kernel.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
 =?UTF-8?Q?Nuno_S=C3=A1?= <nuno.sa@analog.com>,
 "Dragos Bogdan" <dragos.bogdan@analog.com>,
 "Anshul Dalal" <anshulusr@gmail.com>,
 "Andrea Collamati" <andrea.collamati@gmail.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, May 29, 2024, at 09:20, Nuno S=C3=A1 wrote:
> On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>=20
>> Build testing without SPI results in a warning:
>>=20
>> WARNING: unmet direct dependencies detected for REGMAP_SPI
>> =C2=A0 Depends on [n]: SPI [=3Dn]
>> =C2=A0 Selected by [m]:
>> =C2=A0 - AD9739A [=3Dm] && IIO [=3Dm] && (SPI [=3Dn] || COMPILE_TEST =
[=3Dy])
>>=20
>> There is no need for this particular COMPILE_TEST option, as allmodco=
nfig
>> and randconfig testing can just assume that SPI is enabled separately.
>>=20
>> Drop it to avoid the warning.
>>=20
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
> Only for my understanding. When does COMPILE_TEST makes sense to add?

The most common use is to enable building a driver
that is platform specific on x86 allmodconfig
or on randconfig, e.g.

config LPC18XX_DAC
        tristate "NXP LPC18xx DAC driver"
        depends on ARCH_LPC18XX || COMPILE_TEST
        depends on HAS_IOMEM

Since ARCH_LPC18XX is only visible on arch/arm, the
driver would never be build tested on anything else
without the ||COMPILE_TEST.

      Arnd