Received-SPF: pass (google.com: domain of linux-kernel+bounces-193856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <5757d0ff5754f537b16ae36f9e7b5c2399c2cb5e.camel@maquefel.me>
Subject: Re: [PATCH v2 0/3] dmaengine: ioatdma: Fix mem leakage series
From: Nikita Shubin <nikita.shubin@maquefel.me>
To: Dave Jiang <dave.jiang@intel.com>, n.shubin@yadro.com, Vinod Koul
	 <vkoul@kernel.org>, Logan Gunthorpe <logang@deltatee.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>, dmaengine@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux@yadro.com
Date: Wed, 29 May 2024 12:34:02 +0300
In-Reply-To: <e3ec5070-abb7-4adc-9cd1-c459ca27b531@intel.com>
References: <20240528-ioatdma-fixes-v2-0-a9f2fbe26ab1@yadro.com>
	 <e3ec5070-abb7-4adc-9cd1-c459ca27b531@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
Precedence: bulk
MIME-Version: 1.0

Hello Dave!

On Tue, 2024-05-28 at 09:08 -0700, Dave Jiang wrote:
>=20
>=20
> On 5/27/24 11:09 PM, Nikita Shubin via B4 Relay wrote:
> > Started with observing leakage in patch 3, investigating revealed
> > much
> > more problems in probing error path.
> >=20
> > Andy you are always welcome to review if you have a spare time.
> >=20
> > Thank you Andy and Markus for your comments.
> >=20
> > Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
> > ---
> > Changes in v2:
> > - dmaengine: ioatdma: Fix error path in ioat3_dma_probe():
> > =C2=A0 Markus:
> > =C2=A0=C2=A0=C2=A0 - fix typo
> >=20
> > - dmaengine: ioatdma: Fix kmemleak in ioat_pci_probe()
> > =C2=A0 Andy:
> > =C2=A0=C2=A0=C2=A0 - s/int/unsigned int/
> > =C2=A0=C2=A0=C2=A0 - fix spelling errors
> > =C2=A0=C2=A0=C2=A0 - trimmed kmemleak reports
> >=20
> > - Link to v1:
> > https://lore.kernel.org/r/20240524-ioatdma-fixes-v1-0-b785f1f7accc@yadr=
o.com
> >=20
> > ---
> > Nikita Shubin (3):
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dmaengine: ioatdma: Fix leaking on versi=
on mismatch
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dmaengine: ioatdma: Fix error path in io=
at3_dma_probe()
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dmaengine: ioatdma: Fix kmemleak in ioat=
_pci_probe()
> >=20
> > =C2=A0drivers/dma/ioat/init.c | 54 ++++++++++++++++++++++++++----------=
-
> > ------------
> > =C2=A01 file changed, 29 insertions(+), 25 deletions(-)
> > ---
> > base-commit: 6d69b6c12fce479fde7bc06f686212451688a102
> > change-id: 20240524-ioatdma-fixes-a8fccda9bd79
>=20
> Thanks for the fixes.=20

Glad i could help.

You might find this one useful:

https://patchwork.ozlabs.org/project/qemu-devel/patch/20240524114547.28801-=
1-nikita.shubin@maquefel.me/

I think sometimes it's much more faster to test something with QEMU
than tinkering with real hardware.

>=20
> Reviewed-by: Dave Jiang <dave.jiang@intel.com> for the series
>=20
> Would be nice if someone wants to move everything to the devm_*
> management APIs. Would make this a lot less messy. Probably not worth
> the effort though given how old the driver is and no more devices are
> being created to use this driver.=20
>=20
> >=20
> > Best regards,