Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp522562lqb; Wed, 29 May 2024 03:01:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXRFAfNBFyHjXo1X8b+iiRxvQetTGEXwT1EB8ktEjdEBV5n0f02KIlBLQ1t+PD1TmIXKRBJ0uD6u1ba1ZqbNkLHHsdbLEfjfFr4Lz+XTw== X-Google-Smtp-Source: AGHT+IFksowg8rC+3D9wQ4Zt03XBky8wkbW9Y8aA5xcTmI1OVUTQR5nW0yArmlQhE3DZrXeH3lar X-Received: by 2002:a50:8719:0:b0:574:c3e4:1fa3 with SMTP id 4fb4d7f45d1cf-57a041388d3mr1243817a12.20.1716976881540; Wed, 29 May 2024 03:01:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716976881; cv=pass; d=google.com; s=arc-20160816; b=wZgo5d14OIQQ4DWlv79YiHrH/JSWYWTlaBkK/Qws5QMfIOe3d9XC9F1bejQ8q7lOZl z+VVSGwDyE8VLECdVtLeGIoCGGVvwpEOrXdaGWZEw5uq7rA7LSoEipEAQexcmgU1Zye5 Yt7AzteF//2mp8pgyWKdJKb/NHt2pz0+paXk/pE/36YpZcBUmnE8i3x3J3CtgRcg8Npk B7j781M3KTBa8hLnpZTQheMV6fPKWAAVVz5kWrnDv2Ybv+0fO72idzorfFvpw8o5CRIt RbHLG9QLWLm9Byu/lk+U29CSfVRWQuq/kTAm9GnQ2akMDRW4MmCI8WnrXWrE/YNnWtU0 VhlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gWWZLrYgr5n5rjLK7MAKVKxQzA3cpYyocDHYPSXhL8I=; fh=jvdm2KhYhZhImzeT/AiaH1hIxRf3lozZ+Bj7dp4HJ9M=; b=WawD4nP9x9YzMWTbNdJLLCi4nA9sdUR3F4Fbu1hccLCwObhGfUci3yT64ELQMr+NgB 3r1aWXasNYqCKCwuiApUG+shFS22+gTbSf193K9sQwdNmW+6o1smRGrSXoEhfrqAckWy JkkL7HKN8f2b8aZ0AvX9AnSW/F8WgWAi55APgNoyS6RT1dAsPzhFy7lxTVhqezP19po5 iV/mmCqyg5Qs8GlgxG3wiN5hGyNiqODE4ZE3rwk9zsuxQWOwdlznQBgEC/r4aOsfBL8X PcvbSQoWvcLK4M5eEbkT2epQcdrAgGGRBjjNDlecGZiUPFSiX8irTiGEKJauQNYPiEez WKqQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z032jTVm; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-193904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-193904-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5785247ecbesi6035297a12.421.2024.05.29.03.01.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 03:01:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-193904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z032jTVm; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-193904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-193904-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3AADB1F220C7 for ; Wed, 29 May 2024 10:01:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D83AD17A938; Wed, 29 May 2024 10:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Z032jTVm" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A18017A902 for ; Wed, 29 May 2024 10:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716976850; cv=none; b=pAY4oelo3zff/nyvrcznsWGJ0uI7DoQTeyU+9Mt2WoG6+J2R1I1VFMqLsbHNaOps6y5q9ACW5fnzgapPRJtVwKyyeh+5UdDDKL1WqLJl5WUsN/J1azadw/x+18yobc9BnQKB6liShBKTrtDgKGVcWzd3K6AC3od66VNocfHQv3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716976850; c=relaxed/simple; bh=JkIX8xKo+lNY07uEq9QS69wNHFvrTozc/et+eiZHLE0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FxaIyhhj4gLnnfTCddqQphZp3bGnvh5K42rFDNDeWLl4ttu7sFmAAQduwQJxXJUi3/yyNlgnJPbZVVIIY26kkbfd+1AmqGw0CwQpQZd3BvqKoxOEeSDJoR23xvRDiwzs3TJcgxDzZgzcSq+YXxtuPtGH7l8Yjr+Dr48HOKd5EDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Z032jTVm; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12ECAC4AF08; Wed, 29 May 2024 10:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716976849; bh=JkIX8xKo+lNY07uEq9QS69wNHFvrTozc/et+eiZHLE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z032jTVmh53cyY1k9uthsBXu6CX9bXQIlZj3fBscYA0lGqhqfILLHqI86PXjP5vRp 2QgJRBewVMKiqOJs4Ouf+3StxL9/NpQFQNHpK/q1M3UwhOOeBAMQ69IsLSPVciU5tR rruJLA4t68ssP5VhkymRvzHKVzWiFmjrrRpzt9wY= Date: Wed, 29 May 2024 12:00:54 +0200 From: Greg KH To: Soumya Khasnis Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, festevam@denx.de, lee@kernel.org, benjamin.bara@skidata.com, dmitry.osipenko@collabora.com, ldmldm05@gmail.com, srinavasa.nagaraju@sony.com, Madhusudan.Bobbili@sony.com, shingo.takeuchi@sony.com, keita.aihara@sony.com, masaya.takahashi@sony.com Subject: Re: [PATCH] reboot: Add timeout for device shutdown Message-ID: <2024052935-think-gaffe-80d4@gregkh> References: <20240529083224.GA71473@sony.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240529083224.GA71473@sony.com> On Wed, May 29, 2024 at 08:32:24AM +0000, Soumya Khasnis wrote: > The device shutdown callbacks invoked during shutdown/reboot > are prone to errors depending on the device state or mishandling > by one or more driver. In order to prevent a device hang in such > scenarios, we bail out after a timeout while dumping a meaningful > call trace of the shutdown callback which blocks the shutdown or > reboot process. > > Change-Id: Ibfc63ca8f8aa45866cbe6b90401d438d95eca742 Any reason you didn't run this through checkpatch.pl first? :(