Received-SPF: pass (google.com: domain of linux-kernel+bounces-193971-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5c49ebd5-26ae-4a06-85e8-9f90777a904b@amd.com>
Date: Wed, 29 May 2024 16:13:28 +0530
User-Agent: Mozilla Thunderbird
From: Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v3 2/3] KVM: SEV-ES: Disallow SEV-ES guests when
 X86_FEATURE_LBRV is absent
To: Paolo Bonzini <pbonzini@redhat.com>, seanjc@google.com,
 nikunj.dadhania@amd.com
Cc: thomas.lendacky@amd.com, tglx@linutronix.de, mingo@redhat.com,
 bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 michael.roth@amd.com, pankaj.gupta@amd.com, kvm@vger.kernel.org,
 linux-kernel@vger.kernel.org, santosh.shukla@amd.com, ravi.bangoria@amd.com
References: <20240523121828.808-1-ravi.bangoria@amd.com>
 <20240523121828.808-3-ravi.bangoria@amd.com>
 <9626063d-40ed-4caa-8ac5-ba2e88b6e398@redhat.com>
Content-Language: en-US
In-Reply-To: <9626063d-40ed-4caa-8ac5-ba2e88b6e398@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U0k5Qk4vSG92MjkyYWJCL1A0SXJBQ1RFY0Q0L1JVYmExM2VFNU9JNkZGN09M?=
 =?utf-8?B?QWsxcnlJd0xlOEZNRnhneTg0SWNTOFgxOGs3WERCajhHb3M0WEpuRkNGelJB?=
 =?utf-8?B?REZ2U2NzVHg5aHFCMWRnQk53aWVuRkZJSXRQUkRkVzk2Z1E3SlJVdzdOWUZ3?=
 =?utf-8?B?ZTBFR08wbGNRZy9Nck9UVG5SbWt6MVpqOGtpU1VjaDFYaTViU1owd1pUaWVj?=
 =?utf-8?B?R3FXVEh2VHltNGRHaENBeFYyTGxJRmpTV0N0YlAvYWdPWnB4dDgyVks2dUoy?=
 =?utf-8?B?aDhVSFBST1BPbm8zeXZ1aUhlUnBGWlZaMU45a3NhYmVacUI5VnNZRW9GMWkr?=
 =?utf-8?B?UG5rbmFJNXlLV1VIMmNucHQxd3V5eWZKMWN1UmFobHJzcnhoTjltbkgxVENR?=
 =?utf-8?B?SUxPcG4vYkUzaGh4anJRVGlxRzh2TFB1MkRFNERMTjlEN0lnYUUyWGY4bnZN?=
 =?utf-8?B?M0cxOTdhOW9WVXZYSWlxZmhRNkNjb01lTzNITCtIWmRxR3lwNHdFOFJWcXpt?=
 =?utf-8?B?cmZtbnQ3VXN2TDkydkw3WEwwSlUzR1h3Q2ZiT25UazBESTg3c3Y1NnB5a3Zk?=
 =?utf-8?B?eU5ZQ2YycVZ2SW8zbnFwa2NsQVBEM3h3NU5pN1NFSHBTN0ZTZ2NPVERiM283?=
 =?utf-8?B?TWdWcFBWNGVZQUFqVHpSdkdReGc2Wm1zUVRiWjdGK3Q4WHZ1NW1GTDA2NXZs?=
 =?utf-8?B?NVdEWHJlT2Q2dnExYzJzRkt3RWFlTWZZc1B5eFVLa3REank2K1lhQmNOcSts?=
 =?utf-8?B?K1dSUFhxcUdTRmZ4SmgzTVlmWUJBanNWYnhpZVVnZStGT1dCYklVT2ppZjFo?=
 =?utf-8?B?VE5vNjdkZzlwNlB4bm9xblUyWWdySWt5NGRKbVF2TDZYSWh5bG5ocWtqeW83?=
 =?utf-8?B?T3I1M0c2L1JieUJjdlN1OW5qR1ZJOHNxRCszS1ZuMjFYMUgveXVCS3ErMkxo?=
 =?utf-8?B?U1VpNDNQd0tiUjdZSW0zQTI0cTBvMXBYTDJKRmdlSHVjZkhtSVgxdVpxREU1?=
 =?utf-8?B?ckRzaEhybTNBKzBRSllOUDA1M3YrdFhEdkRiYmF0elYxRGwzNGNqb1pSUXdk?=
 =?utf-8?B?NmtBdUhrTGxzMXBKTWdOWklvOHJpQ2hGUVYwUkJMQWpjTGV1ZU1sK2hkMDky?=
 =?utf-8?B?dTZYNmJjVkhMb2dqaW1BWlV1YzcrUk90L3Zyd1pybk12R0dQK0V5QkNUREJX?=
 =?utf-8?B?ZHdFN3p4cGhhTHZjU0NXbXUzT3FGWVlmZkpEOUhWZ1lNV28wZjBYZkZkTVpM?=
 =?utf-8?B?Nlh3a3A2V0JOK1ByRjNIQUxvaXpCdHVYUEVBcFFWaWxlbW1QTkZQVFZZOXBK?=
 =?utf-8?B?Tk13UEZFVmFVZUpwdXF3VUtTU3ZCUGtvSUhpaWpNQnBscDVUQmtEOHh5S0E5?=
 =?utf-8?B?RGdXMUEvV015MmVpeGpaMkhyV0M0elpLRnkyYmk2QlpxM3NPS0o2NThzWThm?=
 =?utf-8?B?U2s3cjhOKzJ4NWp3SG5oOTJSNkxjcFZVK2RHSWRsZUpKRmJhRFhxOEdlT3g2?=
 =?utf-8?B?SDlUV0p1STNrb0w5UzFCWlFkUzI1UjRGaGIyOXNZd2JmODNrSE5NUnN6Yk1h?=
 =?utf-8?B?eGJtK29jZEdzakpNNW9QVDUyaElXeXJwYUtCSlhXSW9QazZ0eEJaR0RmTnVV?=
 =?utf-8?B?cFA4VVhlaklGTmkzSU9qTzFqV21yRnJ1Y0FJRjRaNnRzdVhybHRvbnVtaFNB?=
 =?utf-8?B?cUdGc0hvVS9QWTVyeXdHWEV2aTBWRjU0b2kwMHlncmUrS2hsLzJ6YWdVRmt0?=
 =?utf-8?B?WHl3a3F4TUVaM0tmbWVTeitsQm04UXBzdldic2FOeko3SmwrQTVKQ3N6aTlV?=
 =?utf-8?B?b0ZIMThNSDFzT2o3dTJESDNMVEN0U0F1RzRrSDRBU2dvaGlSeEU5VUJhTkcv?=
 =?utf-8?B?b3FIa0dOakwrTGczU2t4LzkrbVY5YmJyVEhzV1A0MnVZM01VTkQvV0pYTGl0?=
 =?utf-8?B?eEN4QXJHTHZ5Sjd4dmFmMDBYbk92T1d2SGovaUg2ZVVhYjdlTkRRd0poU1h3?=
 =?utf-8?B?cEtKZ0VvZ0VBWTdJR09SdjlyYU9QclVxN3cvUS8zVUx5VCt6SitWdG56NkFY?=
 =?utf-8?B?WDZRYm56cWprZ2hxdXl6UlljZnNNQTBvaTlyTnY0S052WWRXdGxPQW84QUg5?=
 =?utf-8?Q?PhoLY1CtEyvShMJno8wwVotoF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a317f818-ec2d-4f17-8ae1-08dc7fcc338f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 10:43:39.8621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n83ENCok3uA/Z3NHB4QYdMI0ldiE9SfcUqpb+Kx0cF8uzgcWei7bgpP4ODyZ+9qvtfVtMS3CuNcyS6WVlKm5LQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7992

On 5/28/2024 10:03 PM, Paolo Bonzini wrote:
> On 5/23/24 14:18, Ravi Bangoria wrote:
>> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
>> index 489b0183f37d..dcb5eb00a4f5 100644
>> --- a/arch/x86/kvm/svm/svm.c
>> +++ b/arch/x86/kvm/svm/svm.c
>> @@ -5308,11 +5308,17 @@ static __init int svm_hardware_setup(void)
>>         nrips = nrips && boot_cpu_has(X86_FEATURE_NRIPS);
>>   +    if (lbrv) {
>> +        if (!boot_cpu_has(X86_FEATURE_LBRV))
>> +            lbrv = false;
>> +        else
>> +            pr_info("LBR virtualization supported\n");
>> +    }
>>       /*
>>        * Note, SEV setup consumes npt_enabled and enable_mmio_caching (which
>>        * may be modified by svm_adjust_mmio_mask()), as well as nrips.
>>        */
> 
> Since it consumes nrips, just make lbrv non-static:

Sure.

Thanks,
Ravi