Received-SPF: pass (google.com: domain of linux-kernel+bounces-193849-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 29 May 2024 11:32:03 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Ankur Arora <ankur.a.arora@oracle.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	torvalds@linux-foundation.org, paulmck@kernel.org,
	rostedt@goodmis.org, mark.rutland@arm.com, juri.lelli@redhat.com,
	joel@joelfernandes.org, raghavendra.kt@amd.com,
	sshegde@linux.ibm.com, boris.ostrovsky@oracle.com,
	konrad.wilk@oracle.com, Ingo Molnar <mingo@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH v2 21/35] sched: prepare for lazy rescheduling in
 resched_curr()
Message-ID: <20240529093203.GK26599@noisy.programming.kicks-ass.net>
References: <20240528003521.979836-1-ankur.a.arora@oracle.com>
 <20240528003521.979836-22-ankur.a.arora@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240528003521.979836-22-ankur.a.arora@oracle.com>

On Mon, May 27, 2024 at 05:35:07PM -0700, Ankur Arora wrote:

> @@ -1041,25 +1041,34 @@ void wake_up_q(struct wake_q_head *head)
>  void resched_curr(struct rq *rq)
>  {
>  	struct task_struct *curr = rq->curr;
> +	resched_t rs = RESCHED_NOW;
>  	int cpu;
>  
>  	lockdep_assert_rq_held(rq);
>  
> -	if (__test_tsk_need_resched(curr, RESCHED_NOW))
> +	/*
> +	 * TIF_NEED_RESCHED is the higher priority bit, so if it is already
> +	 * set, nothing more to be done.
> +	 */
> +	if (__test_tsk_need_resched(curr, RESCHED_NOW) ||
> +	    (rs == RESCHED_LAZY && __test_tsk_need_resched(curr, RESCHED_LAZY)))
>  		return;
>  
>  	cpu = cpu_of(rq);
>  
>  	if (cpu == smp_processor_id()) {
> -		__set_tsk_need_resched(curr, RESCHED_NOW);
> -		set_preempt_need_resched();
> +		__set_tsk_need_resched(curr, rs);
> +		if (rs == RESCHED_NOW)
> +			set_preempt_need_resched();
>  		return;
>  	}
>  
> -	if (set_nr_and_not_polling(curr))
> -		smp_send_reschedule(cpu);
> -	else
> +	if (set_nr_and_not_polling(curr, rs)) {
> +		if (rs == RESCHED_NOW)
> +			smp_send_reschedule(cpu);

I'm thinking this wants at least something like:

		WARN_ON_ONCE(rs == RESCHED_LAZY && is_idle_task(curr));


> +	} else {
>  		trace_sched_wake_idle_without_ipi(cpu);
> +	}
>  }
>  
>  void resched_cpu(int cpu)