Received-SPF: pass (google.com: domain of linux-kernel+bounces-194017-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <23d5359dca83dd803655b0990479f6fb0eadc61c.camel@gmail.com>
Subject: Re: [PATCH] staging: iio: adt7316: remove unused struct
 'adt7316_limit_regs'
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: linux@treblig.org, lars@metafoo.de, Michael.Hennerich@analog.com, 
	jic23@kernel.org
Cc: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, 
	linux-kernel@vger.kernel.org
Date: Wed, 29 May 2024 13:24:59 +0200
In-Reply-To: <20240528233008.191403-1-linux@treblig.org>
References: <20240528233008.191403-1-linux@treblig.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-05-29 at 00:30 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>=20
> 'adt7316_limit_regs' has never been used since the original
> commit 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9
> driver").
>=20
> The comment above it is a copy-and-paste from a different struct.
>=20
> Remove both the struct and the comment.
>=20
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/staging/iio/addac/adt7316.c | 8 --------
> =C2=A01 file changed, 8 deletions(-)
>=20
> diff --git a/drivers/staging/iio/addac/adt7316.c
> b/drivers/staging/iio/addac/adt7316.c
> index 79467f056a05..23d036d2802c 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -209,14 +209,6 @@ struct adt7316_chip_info {
> =C2=A0#define ADT7316_TEMP_AIN_INT_MASK	\
> =C2=A0	(ADT7316_TEMP_INT_MASK)
> =C2=A0
> -/*
> - * struct adt7316_chip_info - chip specific information
> - */
> -
> -struct adt7316_limit_regs {
> -	u16	data_high;
> -	u16	data_low;
> -};
> =C2=A0
> =C2=A0static ssize_t adt7316_show_enabled(struct device *dev,
> =C2=A0				=C2=A0=C2=A0=C2=A0 struct device_attribute *attr,