Received-SPF: pass (google.com: domain of linux-kernel+bounces-194020-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <674665d7-33b5-4c33-afd8-637222ebf04c@kernel.org>
Date: Wed, 29 May 2024 19:27:59 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] f2fs: avoid resetting non empty zone
To: Sheng Yong <shengyong@oppo.com>, jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
References: <20240529112411.380453-1-shengyong@oppo.com>
Content-Language: en-US
From: Chao Yu <chao@kernel.org>
In-Reply-To: <20240529112411.380453-1-shengyong@oppo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/5/29 19:24, Sheng Yong wrote:
> If curseg is not the first segment in its zone, the zone is not empty,
> and it should not be reset. This issue could be reproduced by:
> 
> 	modprobe null_blk nr_devices=1 zoned=1 zone_max_open=6 zone_max_active=6 zone_size=1024 gb=30
> 	# /dev/vda is 4G
> 	mkfs.f2fs -m -c /dev/nullb0 /dev/vda -f
> 
> 	while :; do
> 		mount /dev/vda /mnt/
> 		dd if=/dev/zero of=/mnt/file bs=4K count=11 conv=fsync status=none
> 		if [ $? -ne 0 ]; then
> 			umount /mnt
> 			break
> 		fi
> 		f2fs_io shutdown 1 /mnt/file
> 		umount /mnt
> 	done
> 
> And the error looks like:
> [  123.169852] I/O error, dev nullb0, sector 41951232 op 0x1:(WRITE) flags 0x800 phys_seg 10 prio class 0
> [  123.173070] F2FS-fs (vda): do_checkpoint failed err:-5, stop checkpoint
> dd: error writing '/mnt/testfile': Input/output error
> 
> Signed-off-by: Sheng Yong <shengyong@oppo.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,