Received-SPF: pass (google.com: domain of linux-kernel+bounces-194028-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <e00498fccf6dcbcf63bd24a137bfc7abd1b98345.1716967720.git.geert+renesas@glider.be>
 <Zlb_txl4CqCfxWZz@pluto>
In-Reply-To: <Zlb_txl4CqCfxWZz@pluto>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 29 May 2024 13:36:42 +0200
Message-ID: <CAMuHMdUyW_RxfUaxnyWVzPsdXQWqCQbgZ+avHskinXkrSFqhtw@mail.gmail.com>
Subject: Re: [PATCH] mailbox: ARM_MHU_V3 should depend on ARM64
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>, Jassi Brar <jassisinghbrar@gmail.com>, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Cristian,

On Wed, May 29, 2024 at 12:13=E2=80=AFPM Cristian Marussi
<cristian.marussi@arm.com> wrote:
> On Wed, May 29, 2024 at 09:30:45AM +0200, Geert Uytterhoeven wrote:
> > The ARM MHUv3 controller is only present on ARM64 SoCs.  Hence add a
> > dependency on ARM64, to prevent asking the user about this driver when
> > configuring a kernel for a different architecture than ARM64.
>
> the ARM64 dependency was dropped on purpose after a few iterations of
> this series since, despite this being an ARM IP, it has really no technic=
al
> dependency on ARM arch, not even the usual one on ARM AMBA bus, being thi=
s a
> platform driver, so it seemed an uneeded artificial restriction to impose=
..
> ...having said that, surely my live testing were performed only on arm64 =
models
> as of now.

For that, we have COMPILE_TEST=3Dy.

> So, I am not saying that I am against this proposed fix but what is the
> issue that is trying to solve, have you seen any compilation error ? or
> is it just to avoid the user-prompting ?

I did not see a compile error (I didn't enable it on any non-ARM
platform).

But it is rather futile to ask the user about (thousands of) drivers
for hardware that cannot possibly be present on the system he is
configuring a kernel for.

> > --- a/drivers/mailbox/Kconfig
> > +++ b/drivers/mailbox/Kconfig
> > @@ -25,6 +25,7 @@ config ARM_MHU_V2
> >
> >  config ARM_MHU_V3
> >       tristate "ARM MHUv3 Mailbox"
> > +     depends on ARM64 || COMPILE_TEST
> >       depends on HAS_IOMEM || COMPILE_TEST
> >       depends on OF
> >       help

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds