Received-SPF: pass (google.com: domain of linux-kernel+bounces-194033-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Jiri Olsa <olsajiri@gmail.com>
Date: Wed, 29 May 2024 13:39:10 +0200
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	KP Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>,
	Hao Luo <haoluo@google.com>, netdev@vger.kernel.org,
	bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf, devmap: Remove unnecessary if check in for loop
Message-ID: <ZlcT3kSfblBDiaTi@krava>
References: <20240529101900.103913-2-thorsten.blum@toblux.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240529101900.103913-2-thorsten.blum@toblux.com>

On Wed, May 29, 2024 at 12:19:01PM +0200, Thorsten Blum wrote:
> The iterator variable dst cannot be NULL and the if check can be
> removed.
> 
> Remove it and fix the following Coccinelle/coccicheck warning reported
> by itnull.cocci:
> 
> 	ERROR: iterator variable bound on line 762 cannot be NULL
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
>  kernel/bpf/devmap.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
> index 4e2cdbb5629f..7f3b34452243 100644
> --- a/kernel/bpf/devmap.c
> +++ b/kernel/bpf/devmap.c
> @@ -760,9 +760,6 @@ int dev_map_redirect_multi(struct net_device *dev, struct sk_buff *skb,
>  		for (i = 0; i < dtab->n_buckets; i++) {
>  			head = dev_map_index_hash(dtab, i);
>  			hlist_for_each_entry_safe(dst, next, head, index_hlist) {
> -				if (!dst)
> -					continue;
> -
>  				if (is_ifindex_excluded(excluded_devices, num_excluded,
>  							dst->dev->ifindex))
>  					continue;
> -- 
> 2.45.1
>