Received-SPF: pass (google.com: domain of linux-kernel+bounces-194062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 29 May 2024 14:13:23 +0200
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra
 <vigneshr@ti.com>, David Woodhouse <David.Woodhouse@intel.com>, Akinobu
 Mita <akinobu.mita@gmail.com>, Artem Bityutskiy
 <artem.bityutskiy@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>,
 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: make mtd_test.c a separate module
Message-ID: <20240529141323.7015f3d9@xps-13>
In-Reply-To: <20240529095049.1915393-1-arnd@kernel.org>
References: <20240529095049.1915393-1-arnd@kernel.org>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Arnd,

arnd@kernel.org wrote on Wed, 29 May 2024 11:50:39 +0200:

> From: Arnd Bergmann <arnd@arndb.de>
>=20
> This file gets linked into nine different modules, which causes a warning:
>=20
> scripts/Makefile.build:236: drivers/mtd/tests/Makefile: mtd_test.o is add=
ed to multiple modules: mtd_nandbiterrs mtd_oobtest mtd_pagetest mtd_readte=
st mtd_speedtest mtd_stresstest mtd_subpagetest mtd_torturetest

I've never experienced this warning myself, how did you produce it?

> Make it a separate module instead.

I'm not a total fan of this just because it now requires an additional
step to insert these test modules (they are likely used for
debugging/development purposes, so not properly installed in the
rootfs). Is there any chance we can find another way?

Thanks,
Miqu=C3=A8l