Received-SPF: pass (google.com: domain of linux-kernel+bounces-194065-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ca3a96c2-e4d9-d935-cf1b-114f7a59872e@axentia.se>
Date: Wed, 29 May 2024 14:16:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 3/3] i2c: mux: gpio: Add support for the
 'transition-delay-us' property
Content-Language: sv-SE, en-US
To: Bastien Curutchet <bastien.curutchet@bootlin.com>,
 Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Peter Korsgaard <peter.korsgaard@barco.com>,
 Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>, Herve Codina <herve.codina@bootlin.com>,
 Christopher Cordahi <christophercordahi@nanometrics.ca>
References: <20240529091739.10808-1-bastien.curutchet@bootlin.com>
 <20240529091739.10808-4-bastien.curutchet@bootlin.com>
From: Peter Rosin <peda@axentia.se>
In-Reply-To: <20240529091739.10808-4-bastien.curutchet@bootlin.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WmVnc2FtQW9ENjVFZUxhbEU5YnJOWTllSUd4ZGxra3hoczdXT29ENllVOWNI?=
 =?utf-8?B?d0U5R0I3NjBUUXZRS04vMG1udXR0a0crNHdmaXNTZ0tsNGdtSDc3dUUrRm8w?=
 =?utf-8?B?eXFscUFpeVNkTlJvQjIrd3JaUjlXZ3FFZXN0SW1MSU9tb2hDV213UUphZllM?=
 =?utf-8?B?aFFaa2dEb3UyV1JFRnFVbS9Cd1A2amlnOU9wdWVhRS94blVra2FzbXlzL0tB?=
 =?utf-8?B?S1o0SDlaaHBpaWFNck4rRFBCWEFRbmw1a3RhcmhnSy81MjBWNDNwUGw3czNK?=
 =?utf-8?B?N25DU3FRaXBiRlZ1Nk5wdHAyaVpHKzU5eTRXQWx3TnB6RGVreWJPc0lCWlVE?=
 =?utf-8?B?UERqbVJ3Mkcvc0J0MWtTbXhLZUZOWWpMUlFPZytIcXhoUlNKTyszL0FqSjhW?=
 =?utf-8?B?dUZsZWJUWDVBWVRvdTkxQ01iY1QxZkhGdUh6R2hyRk1BUlhVWERRMGVCQm9y?=
 =?utf-8?B?SUVqUjU3MlBwZGNEV21DbitZbDBmbkI2SHNVVEhUeS9jU0RjVDM1a2cyMnJ6?=
 =?utf-8?B?MUFDRzhkVXZwT3NabDFpc2R2WlNzVmxXNlh0UGdZeTZabDV0M2ZTWlN4K3o1?=
 =?utf-8?B?VElYV2ZJVWg2Nmg3ayttdENldkFiRUViVnk3dWpjaUdsOUd6NTVPMEdCenBF?=
 =?utf-8?B?eUk4RHFaQWt4R2I1ZmxlamU3a3FGWWxjZEs3L1ZOZUFPMkVhZUFRN2ZBQklo?=
 =?utf-8?B?L1lLYVVFOEZ3U3UxSGZwdks1NGNKV3VLTXZIWWwvVFlicGRubHZEOThNUFp5?=
 =?utf-8?B?ZzFxdXQ5YllTUXNBU1FHTUppd3h5SDQrNUR4Y296c1JldDdqbGt0UFpiV1hE?=
 =?utf-8?B?TVJVclYxa1hCN2EzZTZHTElLNSs1TGtXcjczcWJWS2R6eG9BNzJkbE5LeU1m?=
 =?utf-8?B?eW1pL25GWmFyaFo5NksrblJSRkFjbGtwMlFScDY1WlNNK29Jd3ljTzRwb3pn?=
 =?utf-8?B?bVVEaittSXczZFFwYTRUd3JsaWEwemY4QjgrcFRpblZhVEpwUlA4a2pQdzlG?=
 =?utf-8?B?YXRGMDNnOU9vQlU0MWloT0JhWVo5OFc3QTA1RnFDOEVmTTRsUnBEaC9EQ2pS?=
 =?utf-8?B?dVVLa3l3TklOOVlGdFBKdDgyNVVPWTJIMTI0eVlWRS9PZDdCVWdHSUZkWC9P?=
 =?utf-8?B?NEhNaC9WQXVFN2VGMTZTL21DVTlzWHltaVh1dTBrOHgvL2EyRjQ5QjlnL0hL?=
 =?utf-8?B?dTYra1ZZVWQxK2t1UnRnM1FqRHA4eHlQKzVUeFZ0MnFNMWhoZWxlTFFqVzNF?=
 =?utf-8?B?TXk0UHhkNDRaQ2FpdWx2SFY4OEsweVJyWWRkZE1xdmNoMExIRkFnSWZaZTJ5?=
 =?utf-8?B?SVNDUVVFREE4bERpbVM5WW9hRFJTVG9hYnJzd0RyWjNwczNDYWRwQ3FPb1N3?=
 =?utf-8?B?SFYyaUtBQ0I5UktCM3lQUXNxU1dTNkF5RCs0U25lcStjd0huZm85cGZ5L0JW?=
 =?utf-8?B?S1lsVW0zQnRuNmVlK1ZGbkRvQWxlM1dzYWJORWZmSEtZaXcxczMyVkxjQ3U4?=
 =?utf-8?B?WGF4dlNkOElLVUZwRU9GVlF6YlB3Qlg4cTYzUXY4REJJS3ZMOHpkSnd5cUgw?=
 =?utf-8?B?bVJVd00rVG41UlJsSE1BWExRYXA1MDdlRDRiRzBQV3pGRldJMVlGR3QzWFh6?=
 =?utf-8?B?aFNKWEMzTDNnVGRWK0VLOEFqRDVQTGpBUGhtKzFpQWlWQ2NaQ0NiR0RJYUNz?=
 =?utf-8?B?K01iTFlyanBDNmszQ0pLZEdKejZTQloyR2tVNXFHWWp4MzVCUjliamVoR2lP?=
 =?utf-8?B?YzFkclIzZnpHVnVGTjQ5b2NuQ05vbFQ2S1hHTGtFSGYvdHJUSEhuNG94TEpI?=
 =?utf-8?B?VmRUZ2pCMnZxa3d1RkI4dXN6MXNkLzgrR3pGenZWb1NHN3F1S1BRNTdHcXhs?=
 =?utf-8?B?SkZUQjUrKzZpajBacFlkWUxDVU56WjVWZTB2MDQ5MmVyN0hWT3dvM3hwbWc5?=
 =?utf-8?B?TzAyUG9zelZsa3Bndm9sTEpMWDRMNXl1ZWM3emppT0RyMi9IRU1ia00yVE5Z?=
 =?utf-8?B?ZUVVRHlNYmxTWFExaGx1cklvU2hwYi9WSWpEdjRUZm1EOGRvd0dkamRPQVIz?=
 =?utf-8?B?SWdxUzQ4ZHIxbEovdWtrNFFxVmJ0d2NzRXB3dDMwWVNqUHBiM2Z5WVVGYm1r?=
 =?utf-8?Q?bq7so3QjzWY/h4DBNilnfKkmq?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: dbf4e695-de6e-4112-3d47-08dc7fd93ded
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB8500.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 12:17:00.4923
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7V1zUQ0Pakt2Yk7C4dnga7X/JxLdlGNH2x9+npOmGtvKb1/ZEKqlT7e7m/JGKI9/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR02MB7116

Hi!

2024-05-29 at 11:17, Bastien Curutchet wrote:
> Some hardware need some time to switch from a bus to another. This can
> cause the first transfers following the selection of a bus to fail.
> There is no way to configure this kind of waiting time in the driver.
> 
> Add support for the 'transition-delay-us' device-tree property. When set,
> the i2c_mux_gpio_select() applies a delay before returning, leaving
> enough time to the hardware to switch to the new bus.
> 
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c           | 6 ++++++
>  include/linux/platform_data/i2c-mux-gpio.h | 2 ++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index c61e9d9ea695..b9cfc80660e2 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -6,6 +6,7 @@
>   */
>  
>  #include <linux/bits.h>
> +#include <linux/delay.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/gpio/driver.h>
>  #include <linux/i2c.h>
> @@ -37,6 +38,9 @@ static int i2c_mux_gpio_select(struct i2c_mux_core *muxc, u32 chan)
>  
>  	i2c_mux_gpio_set(mux, chan);
>  
> +	if (mux->data.transition_delay)
> +		udelay(mux->data.transition_delay);

fsleep() is appropriate here.

Cheers,
Peter