Received-SPF: pass (google.com: domain of linux-kernel+bounces-194081-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <2c5d3a53010055c2b996a5b8938c465884834b72.camel@gmail.com>
Subject: Re: [PATCH v3 2/6] iio: adc: ad7173: refactor channel configuration
 parsing
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 David Lechner <dlechner@baylibre.com>,  linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org, Dumitru Ceclan
 <mitrutzceclan@gmail.com>,  Jonathan Cameron <Jonathan.Cameron@huawei.com>
Date: Wed, 29 May 2024 14:24:48 +0200
In-Reply-To: <20240527-ad4111-v3-2-7e9eddbbd3eb@analog.com>
References: <20240527-ad4111-v3-0-7e9eddbbd3eb@analog.com>
	 <20240527-ad4111-v3-2-7e9eddbbd3eb@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-05-27 at 20:02 +0300, Dumitru Ceclan via B4 Relay wrote:
> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
>=20
> Move configurations regarding number of channels from
> *_fw_parse_device_config to *_fw_parse_channel_config.
>=20
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Link: https://lore.kernel.org/all/20240303162148.3ad91aa2@jic23-huawei/
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/adc/ad7173.c | 29 +++++++++++++++++------------
> =C2=A01 file changed, 17 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index ebacdacf64b9..9e507e2c66f0 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -913,7 +913,23 @@ static int ad7173_fw_parse_channel_config(struct iio=
_dev
> *indio_dev)
> =C2=A0	struct device *dev =3D indio_dev->dev.parent;
> =C2=A0	struct iio_chan_spec *chan_arr, *chan;
> =C2=A0	unsigned int ain[2], chan_index =3D 0;
> -	int ref_sel, ret;
> +	int ref_sel, ret, num_channels;
> +
> +	num_channels =3D device_get_child_node_count(dev);
> +
> +	if (st->info->has_temp)
> +		num_channels++;
> +
> +	if (num_channels =3D=3D 0)
> +		return dev_err_probe(dev, -ENODATA, "No channels specified\n");
> +
> +	if (num_channels > st->info->num_channels)
> +		return dev_err_probe(dev, -EINVAL,
> +			"Too many channels specified. Maximum is %d, not including
> temperature channel if supported.\n",
> +			st->info->num_channels);
> +
> +	indio_dev->num_channels =3D num_channels;
> +	st->num_channels =3D num_channels;
> =C2=A0
> =C2=A0	chan_arr =3D devm_kcalloc(dev, sizeof(*indio_dev->channels),
> =C2=A0				st->num_channels, GFP_KERNEL);
> @@ -1008,7 +1024,6 @@ static int ad7173_fw_parse_device_config(struct iio=
_dev
> *indio_dev)
> =C2=A0{
> =C2=A0	struct ad7173_state *st =3D iio_priv(indio_dev);
> =C2=A0	struct device *dev =3D indio_dev->dev.parent;
> -	unsigned int num_channels;
> =C2=A0	int ret;
> =C2=A0
> =C2=A0	st->regulators[0].supply =3D
> ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_EXT_REF];
> @@ -1067,16 +1082,6 @@ static int ad7173_fw_parse_device_config(struct ii=
o_dev
> *indio_dev)
> =C2=A0
> =C2=A0	ad7173_sigma_delta_info.irq_line =3D ret;
> =C2=A0
> -	num_channels =3D device_get_child_node_count(dev);
> -
> -	if (st->info->has_temp)
> -		num_channels++;
> -
> -	if (num_channels =3D=3D 0)
> -		return dev_err_probe(dev, -ENODATA, "No channels specified\n");
> -	indio_dev->num_channels =3D num_channels;
> -	st->num_channels =3D num_channels;
> -
> =C2=A0	return ad7173_fw_parse_channel_config(indio_dev);
> =C2=A0}
> =C2=A0
>=20