Received-SPF: pass (google.com: domain of linux-kernel+bounces-194087-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <3b2a1ce579251726a56bdad25bfdfe75bae91c2e.camel@gmail.com>
Subject: Re: [PATCH v3 4/6] iio: adc: ad7173: add support for special inputs
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 David Lechner <dlechner@baylibre.com>,  linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org, Dumitru Ceclan
 <mitrutzceclan@gmail.com>
Date: Wed, 29 May 2024 14:29:18 +0200
In-Reply-To: <20240527-ad4111-v3-4-7e9eddbbd3eb@analog.com>
References: <20240527-ad4111-v3-0-7e9eddbbd3eb@analog.com>
	 <20240527-ad4111-v3-4-7e9eddbbd3eb@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-05-27 at 20:02 +0300, Dumitru Ceclan via B4 Relay wrote:
> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
>=20
> =C2=A0Add support for selecting REF+ and REF- inputs on all models.
> =C2=A0Add support for selecting ((AVDD1 =E2=88=92 AVSS)/5) inputs
> =C2=A0 on supported models.
>=20
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/adc/ad7173.c | 21 +++++++++++++++++++++
> =C2=A01 file changed, 21 insertions(+)
>=20
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 8a53821c8e58..106a50dbabd4 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -65,6 +65,10 @@
> =C2=A0	 FIELD_PREP(AD7173_CH_SETUP_AINNEG_MASK, neg))
> =C2=A0#define AD7173_AIN_TEMP_POS	17
> =C2=A0#define AD7173_AIN_TEMP_NEG	18
> +#define AD7173_AIN_COM_IN_POS	19
> +#define AD7173_AIN_COM_IN_NEG	20
> +#define AD7173_AIN_REF_POS	21
> +#define AD7173_AIN_REF_NEG	22
> =C2=A0
> =C2=A0#define AD7172_2_ID			0x00d0
> =C2=A0#define AD7175_ID			0x0cd0
> @@ -145,6 +149,8 @@ struct ad7173_device_info {
> =C2=A0	unsigned int id;
> =C2=A0	char *name;
> =C2=A0	bool has_temp;
> +	/* ((AVDD1 =E2=88=92 AVSS)/5) */
> +	bool has_common_input;
> =C2=A0	bool has_input_buf;
> =C2=A0	bool has_int_ref;
> =C2=A0	bool has_ref2;
> @@ -215,6 +221,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {
> =C2=A0		.has_temp =3D true,
> =C2=A0		.has_input_buf =3D true,
> =C2=A0		.has_int_ref =3D true,
> +		.has_common_input =3D true,
> =C2=A0		.clock =3D 2 * HZ_PER_MHZ,
> =C2=A0		.sinc5_data_rates =3D ad7173_sinc5_data_rates,
> =C2=A0		.num_sinc5_data_rates =3D ARRAY_SIZE(ad7173_sinc5_data_rates),
> @@ -229,6 +236,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {
> =C2=A0		.has_temp =3D false,
> =C2=A0		.has_input_buf =3D true,
> =C2=A0		.has_ref2 =3D true,
> +		.has_common_input =3D true,
> =C2=A0		.clock =3D 2 * HZ_PER_MHZ,
> =C2=A0		.sinc5_data_rates =3D ad7173_sinc5_data_rates,
> =C2=A0		.num_sinc5_data_rates =3D ARRAY_SIZE(ad7173_sinc5_data_rates),
> @@ -244,6 +252,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {
> =C2=A0		.has_input_buf =3D true,
> =C2=A0		.has_int_ref =3D true,
> =C2=A0		.has_ref2 =3D true,
> +		.has_common_input =3D false,
> =C2=A0		.clock =3D 2 * HZ_PER_MHZ,
> =C2=A0		.sinc5_data_rates =3D ad7173_sinc5_data_rates,
> =C2=A0		.num_sinc5_data_rates =3D ARRAY_SIZE(ad7173_sinc5_data_rates),
> @@ -258,6 +267,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {
> =C2=A0		.has_temp =3D true,
> =C2=A0		.has_input_buf =3D true,
> =C2=A0		.has_int_ref =3D true,
> +		.has_common_input =3D true,
> =C2=A0		.clock =3D 16 * HZ_PER_MHZ,
> =C2=A0		.sinc5_data_rates =3D ad7175_sinc5_data_rates,
> =C2=A0		.num_sinc5_data_rates =3D ARRAY_SIZE(ad7175_sinc5_data_rates),
> @@ -273,6 +283,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {
> =C2=A0		.has_input_buf =3D true,
> =C2=A0		.has_int_ref =3D true,
> =C2=A0		.has_ref2 =3D true,
> +		.has_common_input =3D true,
> =C2=A0		.clock =3D 16 * HZ_PER_MHZ,
> =C2=A0		.sinc5_data_rates =3D ad7175_sinc5_data_rates,
> =C2=A0		.num_sinc5_data_rates =3D ARRAY_SIZE(ad7175_sinc5_data_rates),
> @@ -287,6 +298,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {
> =C2=A0		.has_temp =3D false,
> =C2=A0		.has_input_buf =3D false,
> =C2=A0		.has_int_ref =3D true,
> +		.has_common_input =3D false,
> =C2=A0		.clock =3D 16 * HZ_PER_MHZ,
> =C2=A0		.sinc5_data_rates =3D ad7175_sinc5_data_rates,
> =C2=A0		.num_sinc5_data_rates =3D ARRAY_SIZE(ad7175_sinc5_data_rates),
> @@ -301,6 +313,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {
> =C2=A0		.has_temp =3D true,
> =C2=A0		.has_input_buf =3D true,
> =C2=A0		.has_int_ref =3D true,
> +		.has_common_input =3D true,
> =C2=A0		.clock =3D 16 * HZ_PER_MHZ,
> =C2=A0		.odr_start_value =3D AD7177_ODR_START_VALUE,
> =C2=A0		.sinc5_data_rates =3D ad7175_sinc5_data_rates,
> @@ -915,6 +928,14 @@ static int ad7173_validate_voltage_ain_inputs(struct
> ad7173_state *st,
> =C2=A0		if (ain[i] < st->info->num_inputs)
> =C2=A0			continue;
> =C2=A0
> +		if (ain[i] =3D=3D AD7173_AIN_REF_POS || ain[i] =3D=3D AD7173_AIN_REF_N=
EG)
> +			continue;
> +
> +		if ((ain[i] =3D=3D AD7173_AIN_COM_IN_POS ||
> +		=C2=A0=C2=A0=C2=A0=C2=A0 ain[i] =3D=3D AD7173_AIN_COM_IN_NEG) &&
> +		=C2=A0=C2=A0=C2=A0 st->info->has_common_input)
> +			continue;
> +
> =C2=A0		return dev_err_probe(dev, -EINVAL,
> =C2=A0			"Input pin number out of range for pair (%d %d).\n",
> =C2=A0			ain[0], ain[1]);
>=20