Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp597812lqb; Wed, 29 May 2024 05:32:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXkUQVa03DXQwSNvPAst+mdlB74wcti8KyaF5BkpwMFwJ3UHq0n9HwbdudyTkJXWv9wisM5ghGKDgVCyN7XGMpc7pjju/whaqPrLTY/Ig== X-Google-Smtp-Source: AGHT+IHn1lUfoHfT+gHvrM8N4Yi4jRHlkFuINHesZsvJUgms1+kEmOBxUyZgZsjpUhcII1hvOCNH X-Received: by 2002:a50:d49e:0:b0:578:5dc5:a4fb with SMTP id 4fb4d7f45d1cf-5785dc5a6f2mr10087677a12.32.1716985924735; Wed, 29 May 2024 05:32:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716985924; cv=pass; d=google.com; s=arc-20160816; b=MF6YubBV7lKnPQUuO8TleZM6zEcQtddXHWr87VCun8dPXZ4+m1foTX3QQN1dq/Ms8+ munWy97ceMHFGlnLvXnnf8K7SK58JW0VxY55k5Fg+54rpkSNy1Es/Wb+RFtVrDwr1g0s rTs2N6Bt4X8SXZ9UNg+uKMhtVB/U/wbj7YuqAateX1cBQLoMIQz+oGZrT2NKqedLZqOQ YA+zaLyUz/yVn/rT7aFdQzwyhMgodF942I1YN1AyQuFN1TjFsvOOlUkwFLb7cuEdIroj g9/0Bm0aB29ZfKl+qSZ/+l6kWyhkGR3qoM4xFFn53MoV3EOzA38ERk9VT2Ma6mO5eMQP hJvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KdzT0+9n90R5cE9IxWh+perLJKy26d5okLkraXgd2qg=; fh=RDTCzXGxQCeObgsL86rYr81fUzqjx6BI/LOJy7tFFzM=; b=TMMdWVv12usEbEa4lW7cTZVz7zyVB3oSUQjZr5BzSxVPd3r8f8Ept5qbd7qu8HBnDH /rYB6wgjW2UY9aaPkQnaO8asTtQnTnIH1N9qDHi9l4OsNiejt97qMPKA01QSxA0/FM4+ J5lv47Ii4DsqPCy6xpxicT2sEonGSptDrDFQ1aXXnRsPYIbryb74FPWK4PFIIXtqPiEy Fu9bGujxMyXEd1jNJRsU3CIsaAZ8LCTkk429ZM9DoXH9mcpnEvvY9Vh8WB/5AbzN5uAF czpefSRFzzA2QvGoOsXUJPupT5wER7QFtwm2G3bAN5NIdJ2Ve/Q0yOWAahqHjo0ki+PB 5kzw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=jFPiF6S+; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-194090-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194090-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5785a3291desi6095612a12.489.2024.05.29.05.32.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 05:32:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194090-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=jFPiF6S+; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-194090-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194090-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 682461F2674A for ; Wed, 29 May 2024 12:32:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5794B181309; Wed, 29 May 2024 12:31:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="jFPiF6S+" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34145363; Wed, 29 May 2024 12:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716985916; cv=none; b=oz02FoO6odItkD9sI6mMHJhzym/KR3WCdOERGTrDNDGOIY5jc7ammzx4WHUbRUE/IIyGsWmDmWL5bOUIeq1iShbIkQG5pNZnIz74fMOamIW4AfkvIjkC2LJe8+L8TBYPF2Fx+wCS2WICnyCRfsvsTLf8GAmOiKoNEqmwFlq7hwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716985916; c=relaxed/simple; bh=2n/XTFTDPEUvw06aTQ9cHuTaiBzd5tPbKQQAhhvR7Q0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L5ZUoQPBKsQRkhya+r7u4QAYtF983kdYZet/YD1VlmE9MFUH7Qq/unrMtNviEpH4/yMwae/EqOC87+Du4VoPZyHIRPsgEKN/sxdt2v6DAEY2TSnHAxLy9D2VAGksK/y3e2BsztnY9SS6NPux6vsYWfxHzcHNEGSyqLZ4oe7JCp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=jFPiF6S+; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=KdzT0+9n90R5cE9IxWh+perLJKy26d5okLkraXgd2qg=; b=jFPiF6S+xcx5ohKu1DeV7AXByF H3aIgLOl+mSwshsCbm4G9T7brqTw1saDLo1t8G7e8+pD9sS9ppiKEmIuqDN20kGeoPctg5X+wxPZD aQzhkhxiAf/jWkr8qHdcdDg3cP79WMfkqQp7QdF7TNzIFJStFSF8uH4lsMmM4gWkOLNI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sCIT7-00GFlP-Nx; Wed, 29 May 2024 14:31:49 +0200 Date: Wed, 29 May 2024 14:31:49 +0200 From: Andrew Lunn To: Matthias Schiffer Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gregor Herburger , linux@ew.tq-group.com Subject: Re: [PATCH 4/8] gpio: tqmx86: introduce _tqmx86_gpio_update_bits() helper Message-ID: <37e3dff1-e901-4dfb-8f69-16947cb9fdf4@lunn.ch> References: <0a21e3f14742e9adcf29361f7f2867199cd0dd4a.1716967982.git.matthias.schiffer@ew.tq-group.com> <28f4d8aa-917d-4666-b59d-bed3ebfab2e2@lunn.ch> <9e4cfa2afe16c6b4dd5db425d8248592daa737c2.camel@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e4cfa2afe16c6b4dd5db425d8248592daa737c2.camel@ew.tq-group.com> > My intention was to mark functions that need to be called while holding the spinlock with a _ > prefix. Should I just remove the prefix and add a comment instead? Yes. You could also add sparse markup of the locks, or add an assert_spin_locked(lock); Andrew