Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp609424lqb; Wed, 29 May 2024 05:54:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCURWKiSVkucydmSe+jMwnjOpVPZADHan3lNW+pvCcdYrp3wUo4CRMDvAFC4JZHjGIKGFOG2RF2Xg90AJjjNGJMREz4d25G0bHCyeOIUIw== X-Google-Smtp-Source: AGHT+IHviw2B35i6zAOufokoPmZppm4SInPpeB+znTw4WEJc/oTllah/OiNxYkfjI1W+sS+OfUxE X-Received: by 2002:a50:cdde:0:b0:578:5cbb:7296 with SMTP id 4fb4d7f45d1cf-5785cbb7531mr11137675a12.36.1716987254668; Wed, 29 May 2024 05:54:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716987254; cv=pass; d=google.com; s=arc-20160816; b=Slsvss5AR3Q8LzBFPEajJxrCKX1Eb/usMwFXUQKd2HAdGiaq/AQPolHzOZIqzult6h CuZVsS/4v27TMMeyJKkROthWtfGWrpbx6+Hkgg0LJSMgjVIWvNOI7bCAUlH3B6w02C37 kcjnZNkigSuu7Kkrv1BAej17Na6BkdZXllh8Zd7StHCdGpsYSwO4yBli1h1EQbPAsDgg QgiebZ4XTTEWVNEw0FjoVMRn7Qs7srm3dhSd7lOMsu8C1G/0O8CQcak9D0wHLzZDS+a/ +Md3c2d1jLCMH3vrc4pRY/SzCv0Isda2xrjd7psfUH/KzIl705KfiAl+Vr1lbphRk5X5 j2cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Qs5PfHuvzI20DzQWq+7zZigsBJutSDi/7QzT1LxXORc=; fh=jvdm2KhYhZhImzeT/AiaH1hIxRf3lozZ+Bj7dp4HJ9M=; b=pwZ/9kJRBhJyBKvfcu6I25GFVNSOsYY8AlocfRZEs0PWop0QIS7WclFaMIBUpPTyhj wKz02ymVRsNE1RZVUFPo1iVce5Jm3jvC1BPtEbUwdmo/vk8c3PIFPEOTbFCKI+QVzAwx LuWJfwYq/oP3+h//uPHiH3T1YxHu47iuQEgOGd0I6F853r9USNtf9YwQmW6Vb3VNR0nN RRns15TwH1dRFFc6qbDXG3ulPGHsaHXLVfoc6cPwxwbtGqVIOHD+Wv6uU1wXseBBGJPk RkveFvyHVtWStuL2V/WGCJHEl/f8wdNJOIt6ooxiy/2yzNHA+SBg0cbHHIu6yIvaU1Wa PF8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=j25nFlDM; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-194105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194105-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57863a8b968si5543976a12.638.2024.05.29.05.54.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 05:54:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=j25nFlDM; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-194105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194105-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C3F651F27EE9 for ; Wed, 29 May 2024 12:47:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 48B6753A9; Wed, 29 May 2024 12:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="j25nFlDM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3FE3FEC for ; Wed, 29 May 2024 12:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716986841; cv=none; b=MbIAWNixyu3eEJ91Ra+8Cjt2ILwbNyBvCcKWVDXJ6PP/g1T3u8zOnaauHuXijuYBiztntBwXC4s94k7Ubahm2QUTKsdTBlmvhcDQvGIHP613H4oAEeQXz5C1fw3yQQKFGfuCBI7SquFzcDlkzw88Tent8hLvXzOsWU2h4xWXgts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716986841; c=relaxed/simple; bh=CGsvgngsO6XpqFwvG62HUsZhvb7vNNqlKSMluceXanY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kK+amarqmAgsRXPatloGNaKMEm7ZGh5njohYYluMXs6GLQXoJ2HZr1Vw7gZw6ZcGU8cdeJ7BJc3C4v8DfCsIrIFSCva8xlUCOm/W3a0xB3mJAOAhtuEZOr8rjnEk+66A/I95QB3n/+Bxu2p4Y3XZgbsE01zeEoaplHe34lLOXNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=j25nFlDM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31897C2BD10; Wed, 29 May 2024 12:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716986840; bh=CGsvgngsO6XpqFwvG62HUsZhvb7vNNqlKSMluceXanY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j25nFlDMMyGsKJFK0VsonPOJR7N2lc/4KRmtQgdjOyD+DZXgpuwSMk1693qr1FET1 6RjT3qGDVw8UFNORjP0zzwiDrVpiNVH/C/gVRf6uh0kBLQyu8MT2Zz7NWqFQCMwHLA 0yZt+Nw00ZVKtlTS40HuvxI+Hg0wzNTB2cL0fvrM= Date: Wed, 29 May 2024 14:47:25 +0200 From: Greg KH To: Soumya Khasnis Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, festevam@denx.de, lee@kernel.org, benjamin.bara@skidata.com, dmitry.osipenko@collabora.com, ldmldm05@gmail.com, srinavasa.nagaraju@sony.com, Madhusudan.Bobbili@sony.com, shingo.takeuchi@sony.com, keita.aihara@sony.com, masaya.takahashi@sony.com Subject: Re: [PATCH v2] reboot: Add timeout for device shutdown Message-ID: <2024052910-feminism-lantern-27f2@gregkh> References: <20240529110049.GA73111@sony.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240529110049.GA73111@sony.com> On Wed, May 29, 2024 at 11:00:49AM +0000, Soumya Khasnis wrote: > The device shutdown callbacks invoked during shutdown/reboot > are prone to errors depending on the device state or mishandling > by one or more driver. In order to prevent a device hang in such > scenarios, we bail out after a timeout while dumping a meaningful > call trace of the shutdown callback which blocks the shutdown or > reboot process. > > Signed-off-by: Soumya Khasnis > Signed-off-by: Srinavasa Nagaraju > --- > drivers/base/Kconfig | 15 +++++++++++++++ > kernel/reboot.c | 46 +++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 60 insertions(+), 1 deletion(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot