Date: Sun, 3 Feb 2008 14:25:06 +0100
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, bryan.wu@analog.com,
       dhowells@redhat.com, Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [patch 1/4] AVR32: cleanup - use _AC macro to define PAGE_SIZE
Message-ID: <20080203142506.2003e5cf@siona>
In-Reply-To: <47a5a660.19e7300a.0584.329a@mx.google.com>
References: <20080203112217.126814108@gmail.com>
	<47a5a660.19e7300a.0584.329a@mx.google.com>
Organization: Atmel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 978
Lines: 27

[removed bogus @atmel.co address from Cc]

On Sun, 03 Feb 2008 14:22:18 +0300
Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>

Applied, thanks.

I found myself having to grep through include/linux to figure out what
this _AC macro was really all about, so I added this to the description:

    PAGE_SIZE is used both from assembly and C code. We want to have type
    specifiers when using it from C, but this will make the assembler
    confused, so we need to make it conditional.
    
    This is exactly what the _AC macro is for, so using it allows us to
    get rid of a few lines of cpp noise.

My first thought was "Autoconf", and it sent shivers down my spine ;-)

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/