Received-SPF: pass (google.com: domain of linux-kernel+bounces-194143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 29 May 2024 14:15:18 +0100
From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regulator: gpio: Correct default GPIO state to LOW
Message-ID: <ee5798e5-bcc4-4715-9c93-913094160b97@sirena.org.uk>
References: <b80d65600641e6dcf00da53ae797f4a40a80e2d0.1716976062.git.geert+renesas@glider.be>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="U4bdCLzVLSiyC7ix"
Content-Disposition: inline
In-Reply-To: <b80d65600641e6dcf00da53ae797f4a40a80e2d0.1716976062.git.geert+renesas@glider.be>


--U4bdCLzVLSiyC7ix
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 29, 2024 at 11:49:51AM +0200, Geert Uytterhoeven wrote:
> According to the GPIO regulator DT bindings[1], the default GPIO state
> is LOW.  However, the driver defaults to HIGH.

> Before the conversion to descriptors in commit d6cd33ad71029a3f
> ("regulator: gpio: Convert to use descriptors"), the default state used
> by the driver was rather ill-defined, too:

That was 4 years ago...

> I have no idea if this has any impact.
> I guess most/all DTS files have proper gpios-states properties?

That seems optimistic, and a grep in mainline shows some users but not
really as many as I'd intuitively expect.

> -			/* Default to high per specification */
> +			/* Default to low per specification */
>  			if (ret)
> -				config->gflags[i] = GPIOD_OUT_HIGH;
> +				config->gflags[i] = GPIOD_OUT_LOW;
>  			else

The risk here is that we start glitching the power where previously we
didn't.  This does make me nervous.

--U4bdCLzVLSiyC7ix
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZXKmUACgkQJNaLcl1U
h9B9Gwf/R2iAIKgEctcw6myFMUeu271otHOu/guyQ+Ko2nLT21+UkH3EiiU5p4b3
cY20iuEK4tmSJPUueJDiwdXAlPOZhQ8JFxIZvXPm0ZIMWDNdMECgb/LkRjJFTN46
WAjtna5x94CON+5t0Bx+OMpM/obwIYqvYWhAZPR8boURfOULjQed3Qs4UzB5O7A2
c9QLLGmeAcCjknN1Xc9OJgVe7sfHp86mwyivy5/5QAvmYPCDJYbt8dPFqg34Rjec
Xk2lJxw1LE6kD0xYg/60lxTEWeiuBJAsX7aVXdxHf8+dP5Y1qgTWwoYY8f9ww81W
X/EozJGbyVxrkmP6w29IaAXV1Ol0Kg==
=DNcl
-----END PGP SIGNATURE-----

--U4bdCLzVLSiyC7ix--