Received-SPF: pass (google.com: domain of linux-kernel+bounces-194213-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240528210319.1242-1-mario.limonciello@amd.com>
 <CADnq5_OzPT1MVnsqXs2vjr1L2_6jeM6x7jgs4ZtYpNzdDHM6uA@mail.gmail.com> <87r0dkiv4o.fsf@intel.com>
In-Reply-To: <87r0dkiv4o.fsf@intel.com>
From: Alex Deucher <alexdeucher@gmail.com>
Date: Wed, 29 May 2024 09:55:01 -0400
Message-ID: <CADnq5_NiJ9a7uYPGj9iuePTRBFKGhhFA6G982bxO2kHe-_5ASA@mail.gmail.com>
Subject: Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>, dri-devel@lists.freedesktop.org, 
	amd-gfx@lists.freedesktop.org, 
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, 
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, 
	linux-kernel@vger.kernel.org, Chris Bainbridge <chris.bainbridge@gmail.com>, 
	hughsient@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 29, 2024 at 9:51=E2=80=AFAM Jani Nikula <jani.nikula@linux.inte=
l.com> wrote:
>
> On Wed, 29 May 2024, Alex Deucher <alexdeucher@gmail.com> wrote:
> > On Tue, May 28, 2024 at 5:03=E2=80=AFPM Mario Limonciello
> > <mario.limonciello@amd.com> wrote:
> >>
> >> If the lid on a laptop is closed when eDP connectors are populated
> >> then it remains enabled when the initial framebuffer configuration
> >> is built.
> >>
> >> When creating the initial framebuffer configuration detect the ACPI
> >> lid status and if it's closed disable any eDP connectors.
> >>
> >> Reported-by: Chris Bainbridge <chris.bainbridge@gmail.com>
> >> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349
> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> >
> > Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> >
> > Do you have drm-misc access or do you need someone to apply this for yo=
u?
>
> I've bounced this to intel-gfx and intel-xe lists to get CI testing. I'd
> appreciate holding off on merging until we have results.

Sure.

Alex

>
> Thanks,
> Jani.
>
> >
> > Alex
> >
> >> ---
> >> Cc: hughsient@gmail.com
> >> v1->v2:
> >>  * Match LVDS as well
> >> ---
> >>  drivers/gpu/drm/drm_client_modeset.c | 30 +++++++++++++++++++++++++++=
+
> >>  1 file changed, 30 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/dr=
m_client_modeset.c
> >> index 31af5cf37a09..0b0411086e76 100644
> >> --- a/drivers/gpu/drm/drm_client_modeset.c
> >> +++ b/drivers/gpu/drm/drm_client_modeset.c
> >> @@ -8,6 +8,7 @@
> >>   */
> >>
> >>  #include "drm/drm_modeset_lock.h"
> >> +#include <acpi/button.h>
> >>  #include <linux/module.h>
> >>  #include <linux/mutex.h>
> >>  #include <linux/slab.h>
> >> @@ -257,6 +258,34 @@ static void drm_client_connectors_enabled(struct =
drm_connector **connectors,
> >>                 enabled[i] =3D drm_connector_enabled(connectors[i], fa=
lse);
> >>  }
> >>
> >> +static void drm_client_match_edp_lid(struct drm_device *dev,
> >> +                                    struct drm_connector **connectors=
,
> >> +                                    unsigned int connector_count,
> >> +                                    bool *enabled)
> >> +{
> >> +       int i;
> >> +
> >> +       for (i =3D 0; i < connector_count; i++) {
> >> +               struct drm_connector *connector =3D connectors[i];
> >> +
> >> +               switch (connector->connector_type) {
> >> +               case DRM_MODE_CONNECTOR_LVDS:
> >> +               case DRM_MODE_CONNECTOR_eDP:
> >> +                       if (!enabled[i])
> >> +                               continue;
> >> +                       break;
> >> +               default:
> >> +                       continue;
> >> +               }
> >> +
> >> +               if (!acpi_lid_open()) {
> >> +                       drm_dbg_kms(dev, "[CONNECTOR:%d:%s] lid is clo=
sed, disabling\n",
> >> +                                   connector->base.id, connector->nam=
e);
> >> +                       enabled[i] =3D false;
> >> +               }
> >> +       }
> >> +}
> >> +
> >>  static bool drm_client_target_cloned(struct drm_device *dev,
> >>                                      struct drm_connector **connectors=
,
> >>                                      unsigned int connector_count,
> >> @@ -844,6 +873,7 @@ int drm_client_modeset_probe(struct drm_client_dev=
 *client, unsigned int width,
> >>                 memset(crtcs, 0, connector_count * sizeof(*crtcs));
> >>                 memset(offsets, 0, connector_count * sizeof(*offsets))=
;
> >>
> >> +               drm_client_match_edp_lid(dev, connectors, connector_co=
unt, enabled);
> >>                 if (!drm_client_target_cloned(dev, connectors, connect=
or_count, modes,
> >>                                               offsets, enabled, width,=
 height) &&
> >>                     !drm_client_target_preferred(dev, connectors, conn=
ector_count, modes,
> >> --
> >> 2.43.0
> >>
>
> --
> Jani Nikula, Intel