Received-SPF: pass (google.com: domain of linux-kernel+bounces-194219-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240516062455.106266-1-alexander.stein@ew.tq-group.com> <20240516062455.106266-3-alexander.stein@ew.tq-group.com>
In-Reply-To: <20240516062455.106266-3-alexander.stein@ew.tq-group.com>
From: Robert Foss <rfoss@kernel.org>
Date: Wed, 29 May 2024 16:02:41 +0200
Message-ID: <CAN6tsi6k3Fv5oQaWbDakaq6_=f-gmVY21OsQ5vxAdepUvU5VBQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] drm/bridge: tc358767: Only print GPIO debug output
 if they actually occur
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, 
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, 
	Jernej Skrabec <jernej.skrabec@gmail.com>, 
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, 
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 16, 2024 at 8:25=E2=80=AFAM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Currently the output the following output is printed upon each interrupt:
>  tc358767 1-000f: GPIO0:
> This spams the kernel log while debugging an IRQ storm from the bridge.
> Only print the debug output if the GPIO hotplug event actually happened.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/gpu/drm/bridge/tc358767.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/t=
c358767.c
> index de62a7e2eafec..8874713bdd4a4 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -2146,11 +2146,11 @@ static irqreturn_t tc_irq_handler(int irq, void *=
arg)
>                 bool h =3D val & INT_GPIO_H(tc->hpd_pin);
>                 bool lc =3D val & INT_GPIO_LC(tc->hpd_pin);
>
> -               dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin,
> -                       h ? "H" : "", lc ? "LC" : "");
> -
> -               if (h || lc)
> +               if (h || lc) {
> +                       dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin,
> +                               h ? "H" : "", lc ? "LC" : "");
>                         drm_kms_helper_hotplug_event(tc->bridge.dev);
> +               }
>         }
>
>         regmap_write(tc->regmap, INTSTS_G, val);
> --
> 2.34.1
>
>

Reviewed-by: Robert Foss <rfoss@kernel.org>