Received-SPF: pass (google.com: domain of linux-kernel+bounces-194209-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 29 May 2024 10:52:59 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: "Steinar H. Gunderson" <sesse@google.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	irogers@google.com, Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v7 1/4] perf report: Support LLVM for addr2line()
Message-ID: <ZlczO4D8J1lgWBZj@x1>
References: <20240526182212.544525-1-sesse@google.com>
 <CAM9d7chY7CzMx9sSYeagDK81PsE=soGmn4AUxXAE7rHp=jmx3Q@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAM9d7chY7CzMx9sSYeagDK81PsE=soGmn4AUxXAE7rHp=jmx3Q@mail.gmail.com>

On Tue, May 28, 2024 at 08:56:47PM -0700, Namhyung Kim wrote:
> On Sun, May 26, 2024 at 11:22 AM Steinar H. Gunderson <sesse@google.com> wrote:
> > +#elif defined(HAVE_LIBBFD_SUPPORT)
 
> Hmm.. it's unfortunate that we have only one addr2line
> implementation at a time.  Maybe we can do the same thing
> like in annotate with objdump so that it can fallback to another
> method when failing.  But it'd require more changes beyond
> this work and I'm not sure if it's really worth it.

Right, I think we shouldn't delay processing these patches because of
that, we can do it as follow up patches, both for fallbacks in case we
can detect problems like we did with capstone -> objdump disasm and also
to be able to compare outputs in 'perf test' shell scripts, discounting
known/expected minor differences.

- Arnaldo