Received-SPF: pass (google.com: domain of linux-kernel+bounces-194251-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-491-g033e30d24-fm-20240520.001-g033e30d2
Precedence: bulk
MIME-Version: 1.0
Message-Id: <436667b5-308a-4a0b-b66e-230667ce0cc3@app.fastmail.com>
In-Reply-To: 
 <CAHp75VdRuK_sOF=25xP0azp8sOJ8DY_SRpLq9mUSaNEmWj5EAg@mail.gmail.com>
References: <20240529095009.1895618-1-arnd@kernel.org>
 <CAHp75VdRuK_sOF=25xP0azp8sOJ8DY_SRpLq9mUSaNEmWj5EAg@mail.gmail.com>
Date: Wed, 29 May 2024 16:13:57 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
 "Arnd Bergmann" <arnd@kernel.org>
Cc: "Daniel Scally" <djrscally@gmail.com>,
 "Hans de Goede" <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: int3472: make common part a separate module
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, May 29, 2024, at 15:41, Andy Shevchenko wrote:
> On Wed, May 29, 2024 at 12:50=E2=80=AFPM Arnd Bergmann <arnd@kernel.or=
g> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Linking an object file into multiple modules is not supported
>> and causes a W=3D1 warning:
>>
>> scripts/Makefile.build:236: drivers/platform/x86/intel/int3472/Makefi=
le: common.o is added to multiple modules: intel_skl_int3472_discrete in=
tel_skl_int3472_tps68470
>>
>> Split out the common part here into a separate module to make it
>> more reliable.
>
> ...
>
>>  obj-$(CONFIG_INTEL_SKL_INT3472)                +=3D intel_skl_int347=
2_discrete.o \
>> -                                          intel_skl_int3472_tps68470=
o
>
>> +                                          intel_skl_int3472_tps68470=
o \
>> +                                          intel_skl_int3472_common.o
>
> A nit: Can this be put above instead?

I've changed it like this now, is that what you meant?


obj-$(CONFIG_INTEL_SKL_INT3472)         +=3D intel_skl_int3472_common.o \
                                           intel_skl_int3472_discrete.o \
                                           intel_skl_int3472_tps68470.o \

intel_skl_int3472_common-y      +=3D common.o
intel_skl_int3472_discrete-y    :=3D discrete.o clk_and_regulator.o led.o
intel_skl_int3472_tps68470-y    :=3D tps68470.o tps68470_board_data.o

> ...
>
>> +EXPORT_SYMBOL_GPL(skl_int3472_get_sensor_adev_and_name);
>
> Are these namespaced?

No, is there any advantage to making them namespaced?

It's only a few symbols and they have proper prefixes.

     Arnd