Received-SPF: pass (google.com: domain of linux-kernel+bounces-194269-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240529095009.1895618-1-arnd@kernel.org> <CAHp75VdRuK_sOF=25xP0azp8sOJ8DY_SRpLq9mUSaNEmWj5EAg@mail.gmail.com>
 <436667b5-308a-4a0b-b66e-230667ce0cc3@app.fastmail.com>
In-Reply-To: <436667b5-308a-4a0b-b66e-230667ce0cc3@app.fastmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 29 May 2024 17:28:05 +0300
Message-ID: <CAHp75VcVdwxv5Mm3GEv7SmsCiN3ZACpejNb7V_Ld1NBTxcXixQ@mail.gmail.com>
Subject: Re: [PATCH] platform/x86: int3472: make common part a separate module
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>, Daniel Scally <djrscally@gmail.com>, 
	Hans de Goede <hdegoede@redhat.com>, =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, 
	platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 29, 2024 at 5:14=E2=80=AFPM Arnd Bergmann <arnd@arndb.de> wrote=
:
> On Wed, May 29, 2024, at 15:41, Andy Shevchenko wrote:
> > On Wed, May 29, 2024 at 12:50=E2=80=AFPM Arnd Bergmann <arnd@kernel.org=
> wrote:

..

> >>  obj-$(CONFIG_INTEL_SKL_INT3472)                +=3D intel_skl_int3472=
_discrete.o \
> >> -                                          intel_skl_int3472_tps68470.=
o
> >
> >> +                                          intel_skl_int3472_tps68470.=
o \
> >> +                                          intel_skl_int3472_common.o
> >
> > A nit: Can this be put above instead?
>
> I've changed it like this now, is that what you meant?
>
>
> obj-$(CONFIG_INTEL_SKL_INT3472)         +=3D intel_skl_int3472_common.o \
>                                            intel_skl_int3472_discrete.o \
>                                            intel_skl_int3472_tps68470.o \

Without the last trailing \, but yes.

> intel_skl_int3472_common-y      +=3D common.o
> intel_skl_int3472_discrete-y    :=3D discrete.o clk_and_regulator.o led.o
> intel_skl_int3472_tps68470-y    :=3D tps68470.o tps68470_board_data.o

..

> >> +EXPORT_SYMBOL_GPL(skl_int3472_get_sensor_adev_and_name);
> >
> > Are these namespaced?
>
> No, is there any advantage to making them namespaced?

Yes, to clean up the global namespace.

> It's only a few symbols and they have proper prefixes.

It's different from the exported namespace.
The function prefixes are needed due to C language, as we can't have
two functions named the same. The export OTOH is what used for linking
modules and if there is no need to have it exported globally, if, for
example, compiling in this one.

So, can we move to the exported namespace at the same time?

--=20
With Best Regards,
Andy Shevchenko