Received-SPF: pass (google.com: domain of linux-kernel+bounces-194289-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Gerald Loacker <gerald.loacker@wolfvision.net>
Date: Wed, 29 May 2024 16:42:45 +0200
Subject: [PATCH v2 1/3] drm/panel: sitronix-st7789v: fix timing for
 jt240mhqs_hwt_ek_e3 panel
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240409-bugfix-jt240mhqs_hwt_ek_e3-timing-v2-1-e4821802443d@wolfvision.net>
References: <20240409-bugfix-jt240mhqs_hwt_ek_e3-timing-v2-0-e4821802443d@wolfvision.net>
In-Reply-To: <20240409-bugfix-jt240mhqs_hwt_ek_e3-timing-v2-0-e4821802443d@wolfvision.net>
To: Neil Armstrong <neil.armstrong@linaro.org>, 
 Jessica Zhang <quic_jesszhan@quicinc.com>, Sam Ravnborg <sam@ravnborg.org>, 
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, 
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, 
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, 
 Gerald Loacker <gerald.loacker@wolfvision.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cS9lN3c1MFc4L0QxcFVPYXBuaDBzd0xZTGVCMGJzdXFrSjA3NHFHa29KNzhS?=
 =?utf-8?B?WU9zcUx4U2J3QjU5bGZlRjRoUWFXb2c3cTRDdE5samJjMTNQQitUYUR3OVUz?=
 =?utf-8?B?a0YyQTJJMVpydENkMVZ6WGhNRTlrK3BnQ1YyMGxNeGlqSENBeW5FdWRqNTJT?=
 =?utf-8?B?Si83cnBiVHlrNnpRZkxLa3F5a3BYeCtFcGJlWnVaak9VT3c0SlhPYit3R0Ux?=
 =?utf-8?B?WUxRS1FsWUM0WisveFo3V3BJTUh5dGIvOXA0dk0wRnJsUzdEeE5RUTJhMVI5?=
 =?utf-8?B?K3FscGtaZHZJTTUyZkdJa0tVTFk2K0srNDdQdTYwZEtkb0pvQmFoeVlXZHlx?=
 =?utf-8?B?dnRiaEVtVTJTNGZQKzJMSkM5L3VUVERFaU5iSUs5b3JvdFU1NTdrNFhWV0ds?=
 =?utf-8?B?SEZzZDRRZGlhS1kwTk5SRHlrWWt4ZlBjMXpFcWRod0JjbWJjaU4xeUx3Zys3?=
 =?utf-8?B?MU12NUsyM3Ard2VZb3VCZjA2M0pJeXROeXVqcGFac1NhS3BqS0NmOWlXNVhw?=
 =?utf-8?B?QVNnb0plRHovU3g2bnRMWmVrLzVZalEwUnUzcWczWW8rajM1clhIODVFMGlX?=
 =?utf-8?B?UTh4TTBFWm1FMFRockVMbS9wWG5CN2ZCdXZBV2Q2eEJ3bXVwRDF1VkttSlZI?=
 =?utf-8?B?SzVDZ0x3WnJwRFRKRHVJa1RCN2V0ZEhWeDJSdFQ3d1YyOFBvSjlZekx2d0Y5?=
 =?utf-8?B?eGhCdGl1b1Q0azNxbWxxTHhYYUZWUUx1NTZpK2hRVnp0ODh2c0JZSm9aQ2p6?=
 =?utf-8?B?ZTd1RG9Cdjl1NnhoTVpaKzdjbFcxUFdyTi9hTjQxZ0hkL3BtUklIMEpuRnFQ?=
 =?utf-8?B?dWIya1Q0aktCK3ZtaVVtNDRPTnA5cStOa3NiRGx0bmgxM0V3V25kR0crOTlH?=
 =?utf-8?B?L1hGL2V2bTJTSENBZ3JCQnhYUkxMRzVlL0tMdjhnM2dJM2lhanEvdERLKzV4?=
 =?utf-8?B?RXlFaGZ3WGVqRVFtTHEvQU8zTGg2WDF2QXl1QWc2SHNTbHRCTTgrN2xLNFdY?=
 =?utf-8?B?MGdTUW1PaGlSNmxzR1ZqMDVxcllVTldzUlFQckdmWjUrbGRkNzFsL3B3T0RS?=
 =?utf-8?B?TUR3V2VHS1FDOXVlWFdoOHZaQ2Z3eWY3VS9ieEhRRnBLaGwrMFhlU1dOeEpx?=
 =?utf-8?B?UnUzUlpVWm1NaHF5T083cUhJMlBWdmwvNHN4KzllZk50Qk9DelRTUGFRV2hz?=
 =?utf-8?B?andPSGMvS01zbVpGWTFpRW9xeTBSNEZHNnpsOEFQaDJaOVVnb2lhbm5aUEdr?=
 =?utf-8?B?UzBQUzBEbVFIYzZjdU1mL095aEVLYVl5WnJSOFY0NTU3SVJWR1pYNGlIcmNX?=
 =?utf-8?B?Zi9oWkpnamdIWTA0Z2l1VU4xMnJtVE9zRWtEOTk4ME80OTVTS3orQ2k5ZDhT?=
 =?utf-8?B?aTFNakc0SVhpdWt6U2l3a2wyUmFGbnVrVXhSYjlybW9aWlByTUsxMlNpVTA2?=
 =?utf-8?B?Y3NJSkt3bmdvM3RMZGkxV3FtY0YxRDBUbnFrUWFjMjQ1Nkw2R2FWWFVhMHVW?=
 =?utf-8?B?NnFWWjdXSDdqT0xsZ3RKN2RYeit1UGlVRnFmV0U1bUhOTDNYdFI4SFlLYlBs?=
 =?utf-8?B?RjFRdTFQUTE2T001Y2NFRnFUbTJnSTFiRXRwN3FuZjJOV0Ewem85a25pajF6?=
 =?utf-8?B?ZDBUUmFpWGYrL0xNYnJXZnlsNXdyTE44TE4zNlJlVVZTK2xITlh0MTVIZXN2?=
 =?utf-8?B?TENhd0ZFeVZhSEd0THZqdXpoRzlZekVrMmw4N1FvWlFGMEFOcHNnWkVYcUQ2?=
 =?utf-8?B?Z3RZek5XbFAzQ1VuUmoxb0tobWh4TWpqb0c4d1BrN21xaTBwdzl2QlBaQVNw?=
 =?utf-8?B?ZEJpSEF6MzZiZnVDWWRUblRpd2RQMjlOT0tVdU44RTE3MERUR2REV1BpcnJB?=
 =?utf-8?B?L2xXSkJvWDlDUUUxeFJvLzlPSDE4cXRkQU9RVE1jejVYKy8waTQ4NWRrNjVS?=
 =?utf-8?B?SDhLYkRZTnM2M3FCUkMwUGxGVEI4RXdsbS9qQ3o1R0lDcnhGYk01c2pwdlAz?=
 =?utf-8?B?dlB1b3UzcGh3TE5LT09ZaE1SR3JKZjlsZXgzL0dlTFlmSVlQWElkZUNnUjhi?=
 =?utf-8?B?M1JlMi93YWxOR0NnWTcrK01SNkI2dmZ2SmRJNXVkd3RwSlcwZFlESlVJK1Rv?=
 =?utf-8?B?ZGFPS3B6RU4vZnBqUmdyTTVkdDY0UXJMMHBoWjJtT1JqSXNzZWZqWUdPMjFS?=
 =?utf-8?B?Z3c9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: f57a71c1-6784-4620-2d3e-08dc7feda126
X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB4539.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 14:42:56.8135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q4Yx/ReX7Ur1vKGPNUJSgb1GYaK/2TqprVU13NfQimCaDm1+sYXmNQuaSAJM5MWh5HeFvirWlkpzrCa9U4oVptzu+ucgZfDQjGOOhSKHuDQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9032

Flickering was observed when using partial mode. Moving the vsync to the
same position as used by the default sitronix-st7789v timing resolves this
issue.

Fixes: 0fbbe96bfa08 ("drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support")
Acked-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
---
 drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
index 88e80fe98112..32e5c0348038 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
@@ -286,9 +286,9 @@ static const struct drm_display_mode jt240mhqs_hwt_ek_e3_mode = {
 	.hsync_end = 240 + 28 + 10,
 	.htotal = 240 + 28 + 10 + 10,
 	.vdisplay = 280,
-	.vsync_start = 280 + 8,
-	.vsync_end = 280 + 8 + 4,
-	.vtotal = 280 + 8 + 4 + 4,
+	.vsync_start = 280 + 48,
+	.vsync_end = 280 + 48 + 4,
+	.vtotal = 280 + 48 + 4 + 4,
 	.width_mm = 43,
 	.height_mm = 37,
 	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,

-- 
2.37.2